Passed
Push — 4 ( 9b9339...6b1c5e )
by Steve
06:47
created

SearchContext   B

Complexity

Total Complexity 43

Size/Duplication

Total Lines 368
Duplicated Lines 0 %

Importance

Changes 0
Metric Value
eloc 104
dl 0
loc 368
rs 8.96
c 0
b 0
f 0
wmc 43

18 Methods

Rating   Name   Duplication   Size   Complexity  
A getFilter() 0 6 2
A setFilters() 0 3 1
A getFilters() 0 3 1
A addFilter() 0 3 1
A getSearchParams() 0 3 1
A removeFilterByName() 0 3 1
A getResults() 0 6 1
B getSummary() 0 38 8
A setSearchParams() 0 9 2
A getFields() 0 3 1
A setFields() 0 3 1
A removeFieldByName() 0 3 1
A addField() 0 3 1
A clearEmptySearchFields() 0 3 1
A __construct() 0 5 3
A getSearchFields() 0 3 2
A applyBaseTableFields() 0 11 2
C getQuery() 0 65 13

How to fix   Complexity   

Complex Class

Complex classes like SearchContext often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes.

Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.

While breaking up the class, it is a good idea to analyze how other classes use SearchContext, and based on these observations, apply Extract Interface, too.

1
<?php
2
3
namespace SilverStripe\ORM\Search;
4
5
use SilverStripe\Control\HTTPRequest;
6
use SilverStripe\Core\ClassInfo;
7
use SilverStripe\Core\Injector\Injectable;
8
use SilverStripe\Core\Injector\Injector;
9
use SilverStripe\Forms\FieldList;
10
use SilverStripe\Forms\FormField;
11
use SilverStripe\ORM\DataObject;
12
use SilverStripe\ORM\DataList;
13
use SilverStripe\ORM\Filters\SearchFilter;
14
use SilverStripe\ORM\ArrayList;
15
use SilverStripe\View\ArrayData;
16
use SilverStripe\Forms\SelectField;
17
use SilverStripe\Forms\CheckboxField;
18
use InvalidArgumentException;
19
use Exception;
20
21
/**
22
 * Manages searching of properties on one or more {@link DataObject}
23
 * types, based on a given set of input parameters.
24
 * SearchContext is intentionally decoupled from any controller-logic,
25
 * it just receives a set of search parameters and an object class it acts on.
26
 *
27
 * The default output of a SearchContext is either a {@link SQLSelect} object
28
 * for further refinement, or a {@link SS_List} that can be used to display
29
 * search results, e.g. in a {@link TableListField} instance.
30
 *
31
 * In case you need multiple contexts, consider namespacing your request parameters
32
 * by using {@link FieldList->namespace()} on the $fields constructor parameter.
33
 *
34
 * Each DataObject subclass can have multiple search contexts for different cases,
35
 * e.g. for a limited frontend search and a fully featured backend search.
36
 * By default, you can use {@link DataObject->getDefaultSearchContext()} which is automatically
37
 * scaffolded. It uses {@link DataObject::$searchable_fields} to determine which fields
38
 * to include.
39
 *
40
 * @see http://doc.silverstripe.com/doku.php?id=searchcontext
41
 */
42
class SearchContext
43
{
44
    use Injectable;
45
46
    /**
47
     * DataObject subclass to which search parameters relate to.
48
     * Also determines as which object each result is provided.
49
     *
50
     * @var string
51
     */
52
    protected $modelClass;
53
54
    /**
55
     * FormFields mapping to {@link DataObject::$db} properties
56
     * which are supposed to be searchable.
57
     *
58
     * @var FieldList
59
     */
60
    protected $fields;
61
62
    /**
63
     * Array of {@link SearchFilter} subclasses.
64
     *
65
     * @var SearchFilter[]
66
     */
67
    protected $filters;
68
69
    /**
70
     * Key/value pairs of search fields to search terms
71
     *
72
     * @var array
73
     */
74
    protected $searchParams = [];
75
76
    /**
77
     * The logical connective used to join WHERE clauses. Defaults to AND.
78
     * @var string
79
     */
80
    public $connective = 'AND';
81
82
    /**
83
     * A key value pair of values that should be searched for.
84
     * The keys should match the field names specified in {@link self::$fields}.
85
     * Usually these values come from a submitted searchform
86
     * in the form of a $_REQUEST object.
87
     * CAUTION: All values should be treated as insecure client input.
88
     *
89
     * @param string $modelClass The base {@link DataObject} class that search properties related to.
90
     *                      Also used to generate a set of result objects based on this class.
91
     * @param FieldList $fields Optional. FormFields mapping to {@link DataObject::$db} properties
92
     *                      which are to be searched. Derived from modelclass using
93
     *                      {@link DataObject::scaffoldSearchFields()} if left blank.
94
     * @param array $filters Optional. Derived from modelclass if left blank
95
     */
96
    public function __construct($modelClass, $fields = null, $filters = null)
97
    {
98
        $this->modelClass = $modelClass;
99
        $this->fields = ($fields) ? $fields : new FieldList();
100
        $this->filters = ($filters) ? $filters : [];
101
    }
102
103
    /**
104
     * Returns scaffolded search fields for UI.
105
     *
106
     * @return FieldList
107
     */
108
    public function getSearchFields()
109
    {
110
        return ($this->fields) ? $this->fields : singleton($this->modelClass)->scaffoldSearchFields();
111
        // $this->fields is causing weirdness, so we ignore for now, using the default scaffolding
112
        //return singleton($this->modelClass)->scaffoldSearchFields();
113
    }
114
115
    /**
116
     * @todo move to SQLSelect
117
     * @todo fix hack
118
     */
119
    protected function applyBaseTableFields()
120
    {
121
        $classes = ClassInfo::dataClassesFor($this->modelClass);
122
        $baseTable = DataObject::getSchema()->baseDataTable($this->modelClass);
123
        $fields = ["\"{$baseTable}\".*"];
124
        if ($this->modelClass != $classes[0]) {
125
            $fields[] = '"' . $classes[0] . '".*';
126
        }
127
        //$fields = array_keys($model->db());
128
        $fields[] = '"' . $classes[0] . '".\"ClassName\" AS "RecordClassName"';
129
        return $fields;
130
    }
131
132
    /**
133
     * Returns a SQL object representing the search context for the given
134
     * list of query parameters.
135
     *
136
     * @param array $searchParams Map of search criteria, mostly taken from $_REQUEST.
137
     *  If a filter is applied to a relationship in dot notation,
138
     *  the parameter name should have the dots replaced with double underscores,
139
     *  for example "Comments__Name" instead of the filter name "Comments.Name".
140
     * @param array|bool|string $sort Database column to sort on.
141
     *  Falls back to {@link DataObject::$default_sort} if not provided.
142
     * @param array|bool|string $limit
143
     * @param DataList $existingQuery
144
     * @return DataList
145
     * @throws Exception
146
     */
147
    public function getQuery($searchParams, $sort = false, $limit = false, $existingQuery = null)
148
    {
149
        /** DataList $query */
150
        $query = null;
151
        if ($existingQuery) {
152
            if (!($existingQuery instanceof DataList)) {
0 ignored issues
show
introduced by
$existingQuery is always a sub-type of SilverStripe\ORM\DataList.
Loading history...
153
                throw new InvalidArgumentException("existingQuery must be DataList");
154
            }
155
            if ($existingQuery->dataClass() != $this->modelClass) {
156
                throw new InvalidArgumentException("existingQuery's dataClass is " . $existingQuery->dataClass()
157
                    . ", $this->modelClass expected.");
158
            }
159
            $query = $existingQuery;
160
        } else {
161
            $query = DataList::create($this->modelClass);
162
        }
163
164
        if (is_array($limit)) {
165
            $query = $query->limit(
166
                isset($limit['limit']) ? $limit['limit'] : null,
167
                isset($limit['start']) ? $limit['start'] : null
168
            );
169
        } else {
170
            $query = $query->limit($limit);
171
        }
172
173
        /** @var DataList $query */
174
        $query = $query->sort($sort);
175
        $this->setSearchParams($searchParams);
176
177
        foreach ($this->searchParams as $key => $value) {
178
            $key = str_replace('__', '.', $key);
179
            if ($filter = $this->getFilter($key)) {
180
                $filter->setModel($this->modelClass);
181
                $filter->setValue($value);
182
                if (!$filter->isEmpty()) {
183
                    $modelObj = Injector::inst()->create($this->modelClass);
184
                    if (isset($modelObj->searchableFields()[$key]['match_any'])) {
185
                        $query = $query->alterDataQuery(function ($dataQuery) use ($modelObj, $key, $value) {
186
                            $searchFields = $modelObj->searchableFields()[$key]['match_any'];
187
                            $sqlSearchFields = [];
188
                            foreach ($searchFields as $dottedRelation) {
189
                                $relation = substr($dottedRelation, 0, strpos($dottedRelation, '.'));
190
                                $relations = explode('.', $dottedRelation);
191
                                $fieldName = array_pop($relations);
192
                                $relationModelName = $dataQuery->applyRelation($relation);
193
                                $relationPrefix = $dataQuery->applyRelationPrefix($relation);
194
                                $columnName = $modelObj->getSchema()
195
                                    ->sqlColumnForField($relationModelName, $fieldName, $relationPrefix);
196
                                $sqlSearchFields[$columnName] = $value;
197
                            }
198
                            $dataQuery = $dataQuery->whereAny($sqlSearchFields);
0 ignored issues
show
Unused Code introduced by
The assignment to $dataQuery is dead and can be removed.
Loading history...
199
                        });
200
                    } else {
201
                        $query = $query->alterDataQuery([$filter, 'apply']);
202
                    }
203
                }
204
            }
205
        }
206
207
        if ($this->connective != "AND") {
208
            throw new Exception("SearchContext connective '$this->connective' not supported after ORM-rewrite.");
209
        }
210
211
        return $query;
212
    }
213
214
    /**
215
     * Returns a result set from the given search parameters.
216
     *
217
     * @todo rearrange start and limit params to reflect DataObject
218
     *
219
     * @param array $searchParams
220
     * @param array|bool|string $sort
221
     * @param array|bool|string $limit
222
     * @return DataList
223
     * @throws Exception
224
     */
225
    public function getResults($searchParams, $sort = false, $limit = false)
226
    {
227
        $searchParams = array_filter((array)$searchParams, [$this, 'clearEmptySearchFields']);
228
229
        // getQuery actually returns a DataList
230
        return $this->getQuery($searchParams, $sort, $limit);
231
    }
232
233
    /**
234
     * Callback map function to filter fields with empty values from
235
     * being included in the search expression.
236
     *
237
     * @param mixed $value
238
     * @return boolean
239
     */
240
    public function clearEmptySearchFields($value)
241
    {
242
        return ($value != '');
243
    }
244
245
    /**
246
     * Accessor for the filter attached to a named field.
247
     *
248
     * @param string $name
249
     * @return SearchFilter
250
     */
251
    public function getFilter($name)
252
    {
253
        if (isset($this->filters[$name])) {
254
            return $this->filters[$name];
255
        } else {
256
            return null;
257
        }
258
    }
259
260
    /**
261
     * Get the map of filters in the current search context.
262
     *
263
     * @return SearchFilter[]
264
     */
265
    public function getFilters()
266
    {
267
        return $this->filters;
268
    }
269
270
    /**
271
     * Overwrite the current search context filter map.
272
     *
273
     * @param array $filters
274
     */
275
    public function setFilters($filters)
276
    {
277
        $this->filters = $filters;
278
    }
279
280
    /**
281
     * Adds a instance of {@link SearchFilter}.
282
     *
283
     * @param SearchFilter $filter
284
     */
285
    public function addFilter($filter)
286
    {
287
        $this->filters[$filter->getFullName()] = $filter;
288
    }
289
290
    /**
291
     * Removes a filter by name.
292
     *
293
     * @param string $name
294
     */
295
    public function removeFilterByName($name)
296
    {
297
        unset($this->filters[$name]);
298
    }
299
300
    /**
301
     * Get the list of searchable fields in the current search context.
302
     *
303
     * @return FieldList
304
     */
305
    public function getFields()
306
    {
307
        return $this->fields;
308
    }
309
310
    /**
311
     * Apply a list of searchable fields to the current search context.
312
     *
313
     * @param FieldList $fields
314
     */
315
    public function setFields($fields)
316
    {
317
        $this->fields = $fields;
318
    }
319
320
    /**
321
     * Adds a new {@link FormField} instance.
322
     *
323
     * @param FormField $field
324
     */
325
    public function addField($field)
326
    {
327
        $this->fields->push($field);
328
    }
329
330
    /**
331
     * Removes an existing formfield instance by its name.
332
     *
333
     * @param string $fieldName
334
     */
335
    public function removeFieldByName($fieldName)
336
    {
337
        $this->fields->removeByName($fieldName);
338
    }
339
340
    /**
341
     * Set search param values
342
     *
343
     * @param array|HTTPRequest $searchParams
344
     * @return $this
345
     */
346
    public function setSearchParams($searchParams)
347
    {
348
        // hack to work with $searchParams when it's an Object
349
        if ($searchParams instanceof HTTPRequest) {
350
            $this->searchParams = $searchParams->getVars();
351
        } else {
352
            $this->searchParams = $searchParams;
353
        }
354
        return $this;
355
    }
356
357
    /**
358
     * @return array
359
     */
360
    public function getSearchParams()
361
    {
362
        return $this->searchParams;
363
    }
364
365
    /**
366
     * Gets a list of what fields were searched and the values provided
367
     * for each field. Returns an ArrayList of ArrayData, suitable for
368
     * rendering on a template.
369
     *
370
     * @return ArrayList
371
     */
372
    public function getSummary()
373
    {
374
        $list = ArrayList::create();
375
        foreach ($this->searchParams as $searchField => $searchValue) {
376
            if (empty($searchValue)) {
377
                continue;
378
            }
379
            $filter = $this->getFilter($searchField);
380
            if (!$filter) {
381
                continue;
382
            }
383
384
            $field = $this->fields->fieldByName($filter->getFullName());
0 ignored issues
show
Bug introduced by
Are you sure the assignment to $field is correct as $this->fields->fieldByNa...$filter->getFullName()) targeting SilverStripe\Forms\FieldList::fieldByName() seems to always return null.

This check looks for function or method calls that always return null and whose return value is assigned to a variable.

class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
$object = $a->getObject();

The method getObject() can return nothing but null, so it makes no sense to assign that value to a variable.

The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes.

Loading history...
385
            if (!$field) {
386
                continue;
387
            }
388
389
            // For dropdowns, checkboxes, etc, get the value that was presented to the user
390
            // e.g. not an ID
391
            if ($field instanceof SelectField) {
392
                $source = $field->getSource();
393
                if (isset($source[$searchValue])) {
394
                    $searchValue = $source[$searchValue];
395
                }
396
            } else {
397
                // For checkboxes, it suffices to simply include the field in the list, since it's binary
398
                if ($field instanceof CheckboxField) {
399
                    $searchValue = null;
400
                }
401
            }
402
403
            $list->push(ArrayData::create([
404
                'Field' => $field->Title(),
405
                'Value' => $searchValue,
406
            ]));
407
        }
408
409
        return $list;
410
    }
411
}
412