Completed
Push — master ( 2b0509...87ac3e )
by Sam
09:00
created
src/Forms/GridField/GridFieldEditButton.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -65,7 +65,7 @@  discard block
 block discarded – undo
65 65
      * Which columns are handled by this component
66 66
      *
67 67
      * @param GridField $gridField
68
-     * @return array
68
+     * @return string[]
69 69
      */
70 70
     public function getColumnsHandled($gridField)
71 71
     {
@@ -87,7 +87,7 @@  discard block
 block discarded – undo
87 87
      * @param GridField $gridField
88 88
      * @param DataObject $record
89 89
      * @param string $columnName
90
-     * @return string The HTML for the column
90
+     * @return \SilverStripe\ORM\FieldType\DBHTMLText The HTML for the column
91 91
      */
92 92
     public function getColumnContent($gridField, $record, $columnName)
93 93
     {
Please login to merge, or discard this patch.
src/Forms/GridField/GridFieldExportButton.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -75,7 +75,7 @@  discard block
 block discarded – undo
75 75
      * export is an action button
76 76
      *
77 77
      * @param GridField $gridField
78
-     * @return array
78
+     * @return string[]
79 79
      */
80 80
     public function getActions($gridField)
81 81
     {
@@ -149,7 +149,7 @@  discard block
 block discarded – undo
149 149
      * Generate export fields for CSV.
150 150
      *
151 151
      * @param GridField $gridField
152
-     * @return array
152
+     * @return string
153 153
      */
154 154
     public function generateExportFileData($gridField)
155 155
     {
Please login to merge, or discard this patch.
src/Forms/GridField/GridFieldPrintButton.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -392,7 +392,7 @@
 block discarded – undo
392 392
     /**
393 393
      * Get location of all editor.css files
394 394
      *
395
-     * @return array
395
+     * @return string[]
396 396
      */
397 397
     protected function getEditorCSS() {
398 398
         $editor = array();
Please login to merge, or discard this patch.
src/Forms/HTMLEditor/EmbedShortcodeProvider.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -17,7 +17,7 @@
 block discarded – undo
17 17
     /**
18 18
      * Gets the list of shortcodes provided by this handler
19 19
      *
20
-     * @return mixed
20
+     * @return string[]
21 21
      */
22 22
     public static function get_shortcodes()
23 23
     {
Please login to merge, or discard this patch.
src/Forms/HTMLEditor/HTMLEditorConfig.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -148,14 +148,14 @@
 block discarded – undo
148 148
      * Get the current value of an option
149 149
      *
150 150
      * @param string $key The key of the option to get
151
-     * @return mixed The value of the specified option
151
+     * @return string The value of the specified option
152 152
      */
153 153
     abstract public function getOption($key);
154 154
 
155 155
     /**
156 156
      * Set the value of one option
157 157
      * @param string $key The key of the option to set
158
-     * @param mixed $value The value of the option to set
158
+     * @param string $value The value of the option to set
159 159
      * @return $this
160 160
      */
161 161
     abstract public function setOption($key, $value);
Please login to merge, or discard this patch.
src/Forms/HTMLEditor/HTMLEditorField.php 1 patch
Doc Comments   +5 added lines, -2 removed lines patch added patch discarded remove patch
@@ -73,7 +73,7 @@  discard block
 block discarded – undo
73 73
     /**
74 74
      * Assign a new configuration instance or identifier
75 75
      *
76
-     * @param string|HTMLEditorConfig $config
76
+     * @param string $config
77 77
      * @return $this
78 78
      */
79 79
     public function setEditorConfig($config)
@@ -88,7 +88,7 @@  discard block
 block discarded – undo
88 88
      *
89 89
      * @param string $name The internal field name, passed to forms.
90 90
      * @param string $title The human-readable field label.
91
-     * @param mixed $value The value of the field.
91
+     * @param integer $value The value of the field.
92 92
      * @param string $config HTMLEditorConfig identifier to be used. Default to the active one.
93 93
      */
94 94
     public function __construct($name, $title = null, $value = '', $config = null)
@@ -136,6 +136,9 @@  discard block
 block discarded – undo
136 136
         $record->{$this->name} = $htmlValue->getContent();
137 137
     }
138 138
 
139
+    /**
140
+     * @param string|null $value
141
+     */
139 142
     public function setValue($value)
140 143
     {
141 144
         // Regenerate links prior to preview, so that the editor can see them.
Please login to merge, or discard this patch.
src/Forms/HTMLEditor/HTMLEditorField_Embed.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -142,7 +142,7 @@
 block discarded – undo
142 142
     }
143 143
 
144 144
     /**
145
-     * @return AdapterInterface
145
+     * @return Embed
146 146
      */
147 147
     public function getEmbed()
148 148
     {
Please login to merge, or discard this patch.
src/Forms/HTMLEditor/HTMLEditorField_Toolbar.php 1 patch
Doc Comments   +5 added lines, -1 removed lines patch added patch discarded remove patch
@@ -67,6 +67,10 @@  discard block
 block discarded – undo
67 67
      */
68 68
     protected $name;
69 69
 
70
+    /**
71
+     * @param Controller|null $controller
72
+     * @param string $name
73
+     */
70 74
     public function __construct($controller, $name)
71 75
     {
72 76
         parent::__construct();
@@ -508,7 +512,7 @@  discard block
 block discarded – undo
508 512
     /**
509 513
      * Find all anchors available on the given page.
510 514
      *
511
-     * @return array
515
+     * @return string
512 516
      * @throws HTTPResponse_Exception
513 517
      */
514 518
     public function getanchors()
Please login to merge, or discard this patch.
src/Forms/HTMLEditor/HTMLEditorSanitiser.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -52,7 +52,7 @@
 block discarded – undo
52 52
     /**
53 53
      * Given a TinyMCE pattern (close to unix glob style), create a regex that does the match
54 54
      *
55
-     * @param $str - The TinyMCE pattern
55
+     * @param string|null $str - The TinyMCE pattern
56 56
      * @return string - The equivalent regex
57 57
      */
58 58
     protected function patternToRegex($str)
Please login to merge, or discard this patch.