| Total Complexity | 45 |
| Total Lines | 369 |
| Duplicated Lines | 0 % |
| Changes | 1 | ||
| Bugs | 0 | Features | 0 |
Complex classes like SearchContext often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use SearchContext, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 41 | class SearchContext |
||
| 42 | { |
||
| 43 | use Injectable; |
||
| 44 | |||
| 45 | /** |
||
| 46 | * DataObject subclass to which search parameters relate to. |
||
| 47 | * Also determines as which object each result is provided. |
||
| 48 | * |
||
| 49 | * @var string |
||
| 50 | */ |
||
| 51 | protected $modelClass; |
||
| 52 | |||
| 53 | /** |
||
| 54 | * FormFields mapping to {@link DataObject::$db} properties |
||
| 55 | * which are supposed to be searchable. |
||
| 56 | * |
||
| 57 | * @var FieldList |
||
| 58 | */ |
||
| 59 | protected $fields; |
||
| 60 | |||
| 61 | /** |
||
| 62 | * Array of {@link SearchFilter} subclasses. |
||
| 63 | * |
||
| 64 | * @var SearchFilter[] |
||
| 65 | */ |
||
| 66 | protected $filters; |
||
| 67 | |||
| 68 | /** |
||
| 69 | * Key/value pairs of search fields to search terms |
||
| 70 | * |
||
| 71 | * @var array |
||
| 72 | */ |
||
| 73 | protected $searchParams = []; |
||
| 74 | |||
| 75 | /** |
||
| 76 | * The logical connective used to join WHERE clauses. Defaults to AND. |
||
| 77 | * @var string |
||
| 78 | */ |
||
| 79 | public $connective = 'AND'; |
||
| 80 | |||
| 81 | /** |
||
| 82 | * A key value pair of values that should be searched for. |
||
| 83 | * The keys should match the field names specified in {@link self::$fields}. |
||
| 84 | * Usually these values come from a submitted searchform |
||
| 85 | * in the form of a $_REQUEST object. |
||
| 86 | * CAUTION: All values should be treated as insecure client input. |
||
| 87 | * |
||
| 88 | * @param string $modelClass The base {@link DataObject} class that search properties related to. |
||
| 89 | * Also used to generate a set of result objects based on this class. |
||
| 90 | * @param FieldList $fields Optional. FormFields mapping to {@link DataObject::$db} properties |
||
| 91 | * which are to be searched. Derived from modelclass using |
||
| 92 | * {@link DataObject::scaffoldSearchFields()} if left blank. |
||
| 93 | * @param array $filters Optional. Derived from modelclass if left blank |
||
| 94 | */ |
||
| 95 | public function __construct($modelClass, $fields = null, $filters = null) |
||
| 96 | { |
||
| 97 | $this->modelClass = $modelClass; |
||
| 98 | $this->fields = ($fields) ? $fields : new FieldList(); |
||
| 99 | $this->filters = ($filters) ? $filters : []; |
||
| 100 | } |
||
| 101 | |||
| 102 | /** |
||
| 103 | * Returns scaffolded search fields for UI. |
||
| 104 | * |
||
| 105 | * @return FieldList |
||
| 106 | */ |
||
| 107 | public function getSearchFields() |
||
| 110 | // $this->fields is causing weirdness, so we ignore for now, using the default scaffolding |
||
| 111 | //return singleton($this->modelClass)->scaffoldSearchFields(); |
||
| 112 | } |
||
| 113 | |||
| 114 | /** |
||
| 115 | * @todo move to SQLSelect |
||
| 116 | * @todo fix hack |
||
| 117 | */ |
||
| 118 | protected function applyBaseTableFields() |
||
| 129 | } |
||
| 130 | |||
| 131 | /** |
||
| 132 | * Returns a SQL object representing the search context for the given |
||
| 133 | * list of query parameters. |
||
| 134 | * |
||
| 135 | * @param array $searchParams Map of search criteria, mostly taken from $_REQUEST. |
||
| 136 | * If a filter is applied to a relationship in dot notation, |
||
| 137 | * the parameter name should have the dots replaced with double underscores, |
||
| 138 | * for example "Comments__Name" instead of the filter name "Comments.Name". |
||
| 139 | * @param array|bool|string $sort Database column to sort on. |
||
| 140 | * Falls back to {@link DataObject::$default_sort} if not provided. |
||
| 141 | * @param array|bool|string $limit |
||
| 142 | * @param DataList $existingQuery |
||
| 143 | * @param bool $disjunctive Use OR to connect WHERE clauses between fields instead of AND |
||
| 144 | * @return DataList |
||
| 145 | * @throws Exception |
||
| 146 | */ |
||
| 147 | public function getQuery($searchParams, $sort = false, $limit = false, $existingQuery = null, $disjunctive = false) |
||
| 148 | { |
||
| 149 | /** DataList $query */ |
||
| 150 | $query = null; |
||
| 151 | if ($existingQuery) { |
||
| 152 | if (!($existingQuery instanceof DataList)) { |
||
|
|
|||
| 153 | throw new InvalidArgumentException("existingQuery must be DataList"); |
||
| 154 | } |
||
| 155 | if ($existingQuery->dataClass() != $this->modelClass) { |
||
| 156 | throw new InvalidArgumentException("existingQuery's dataClass is " . $existingQuery->dataClass() |
||
| 157 | . ", $this->modelClass expected."); |
||
| 158 | } |
||
| 159 | $query = $existingQuery; |
||
| 160 | } else { |
||
| 161 | $query = DataList::create($this->modelClass); |
||
| 162 | } |
||
| 163 | |||
| 164 | if (is_array($limit)) { |
||
| 165 | $query = $query->limit( |
||
| 166 | isset($limit['limit']) ? $limit['limit'] : null, |
||
| 167 | isset($limit['start']) ? $limit['start'] : null |
||
| 168 | ); |
||
| 169 | } else { |
||
| 170 | $query = $query->limit($limit); |
||
| 171 | } |
||
| 172 | |||
| 173 | /** @var DataList $query */ |
||
| 174 | $query = $query->sort($sort); |
||
| 175 | |||
| 176 | if ($disjunctive) { |
||
| 177 | // TODO: not setting $this->setSearchParams($searchParams); as it's messing up the front end |
||
| 178 | // by adding it tags that don't make sense |
||
| 179 | foreach ($searchParams as $key => $value) { |
||
| 180 | if ($filter = $this->getFilter($key)) { |
||
| 181 | // TODO: replace with some sort of reverse lookup on DataListFilter config in case someone |
||
| 182 | // adds their own filter type that doesn't end in 'Filter' |
||
| 183 | $parts = explode('\\', get_class($filter)); |
||
| 184 | $classNoNamespace = end($parts); |
||
| 185 | if (preg_match('#^([A-Za-z0-9]+)Filter$#', $classNoNamespace, $matches)) { |
||
| 186 | $modifier = $matches[1]; // e.g. PartialMatch |
||
| 187 | $searchParams[$key . ':' . $modifier] = $value; |
||
| 188 | unset($searchParams[$key]); |
||
| 189 | } |
||
| 190 | } |
||
| 191 | } |
||
| 192 | return $query->filterAny($searchParams); |
||
| 193 | } |
||
| 194 | |||
| 195 | $this->setSearchParams($searchParams); |
||
| 196 | foreach ($this->searchParams as $key => $value) { |
||
| 197 | $key = str_replace('__', '.', $key); |
||
| 198 | if ($filter = $this->getFilter($key)) { |
||
| 199 | $filter->setModel($this->modelClass); |
||
| 200 | $filter->setValue($value); |
||
| 201 | if (!$filter->isEmpty()) { |
||
| 202 | $query = $query->alterDataQuery([$filter, 'apply']); |
||
| 203 | } |
||
| 204 | } |
||
| 205 | } |
||
| 206 | |||
| 207 | if ($this->connective != "AND") { |
||
| 208 | throw new Exception("SearchContext connective '$this->connective' not supported after ORM-rewrite."); |
||
| 209 | } |
||
| 210 | |||
| 211 | return $query; |
||
| 212 | } |
||
| 213 | |||
| 214 | /** |
||
| 215 | * Returns a result set from the given search parameters. |
||
| 216 | * |
||
| 217 | * @todo rearrange start and limit params to reflect DataObject |
||
| 218 | * |
||
| 219 | * @param array $searchParams |
||
| 220 | * @param array|bool|string $sort |
||
| 221 | * @param array|bool|string $limit |
||
| 222 | * @return DataList |
||
| 223 | * @throws Exception |
||
| 224 | */ |
||
| 225 | public function getResults($searchParams, $sort = false, $limit = false) |
||
| 226 | { |
||
| 227 | $searchParams = array_filter((array)$searchParams, [$this, 'clearEmptySearchFields']); |
||
| 228 | |||
| 229 | // getQuery actually returns a DataList |
||
| 230 | return $this->getQuery($searchParams, $sort, $limit); |
||
| 231 | } |
||
| 232 | |||
| 233 | /** |
||
| 234 | * Callback map function to filter fields with empty values from |
||
| 235 | * being included in the search expression. |
||
| 236 | * |
||
| 237 | * @param mixed $value |
||
| 238 | * @return boolean |
||
| 239 | */ |
||
| 240 | public function clearEmptySearchFields($value) |
||
| 241 | { |
||
| 242 | return ($value != ''); |
||
| 243 | } |
||
| 244 | |||
| 245 | /** |
||
| 246 | * Accessor for the filter attached to a named field. |
||
| 247 | * |
||
| 248 | * @param string $name |
||
| 249 | * @return SearchFilter |
||
| 250 | */ |
||
| 251 | public function getFilter($name) |
||
| 257 | } |
||
| 258 | } |
||
| 259 | |||
| 260 | /** |
||
| 261 | * Get the map of filters in the current search context. |
||
| 262 | * |
||
| 263 | * @return SearchFilter[] |
||
| 264 | */ |
||
| 265 | public function getFilters() |
||
| 266 | { |
||
| 267 | return $this->filters; |
||
| 268 | } |
||
| 269 | |||
| 270 | /** |
||
| 271 | * Overwrite the current search context filter map. |
||
| 272 | * |
||
| 273 | * @param array $filters |
||
| 274 | */ |
||
| 275 | public function setFilters($filters) |
||
| 278 | } |
||
| 279 | |||
| 280 | /** |
||
| 281 | * Adds a instance of {@link SearchFilter}. |
||
| 282 | * |
||
| 283 | * @param SearchFilter $filter |
||
| 284 | */ |
||
| 285 | public function addFilter($filter) |
||
| 288 | } |
||
| 289 | |||
| 290 | /** |
||
| 291 | * Removes a filter by name. |
||
| 292 | * |
||
| 293 | * @param string $name |
||
| 294 | */ |
||
| 295 | public function removeFilterByName($name) |
||
| 296 | { |
||
| 297 | unset($this->filters[$name]); |
||
| 298 | } |
||
| 299 | |||
| 300 | /** |
||
| 301 | * Get the list of searchable fields in the current search context. |
||
| 302 | * |
||
| 303 | * @return FieldList |
||
| 304 | */ |
||
| 305 | public function getFields() |
||
| 306 | { |
||
| 307 | return $this->fields; |
||
| 308 | } |
||
| 309 | |||
| 310 | /** |
||
| 311 | * Apply a list of searchable fields to the current search context. |
||
| 312 | * |
||
| 313 | * @param FieldList $fields |
||
| 314 | */ |
||
| 315 | public function setFields($fields) |
||
| 316 | { |
||
| 317 | $this->fields = $fields; |
||
| 318 | } |
||
| 319 | |||
| 320 | /** |
||
| 321 | * Adds a new {@link FormField} instance. |
||
| 322 | * |
||
| 323 | * @param FormField $field |
||
| 324 | */ |
||
| 325 | public function addField($field) |
||
| 326 | { |
||
| 327 | $this->fields->push($field); |
||
| 328 | } |
||
| 329 | |||
| 330 | /** |
||
| 331 | * Removes an existing formfield instance by its name. |
||
| 332 | * |
||
| 333 | * @param string $fieldName |
||
| 334 | */ |
||
| 335 | public function removeFieldByName($fieldName) |
||
| 336 | { |
||
| 337 | $this->fields->removeByName($fieldName); |
||
| 338 | } |
||
| 339 | |||
| 340 | /** |
||
| 341 | * Set search param values |
||
| 342 | * |
||
| 343 | * @param array|HTTPRequest $searchParams |
||
| 344 | * @return $this |
||
| 345 | */ |
||
| 346 | public function setSearchParams($searchParams) |
||
| 347 | { |
||
| 348 | // hack to work with $searchParams when it's an Object |
||
| 349 | if ($searchParams instanceof HTTPRequest) { |
||
| 350 | $this->searchParams = $searchParams->getVars(); |
||
| 351 | } else { |
||
| 352 | $this->searchParams = $searchParams; |
||
| 353 | } |
||
| 354 | return $this; |
||
| 355 | } |
||
| 356 | |||
| 357 | /** |
||
| 358 | * @return array |
||
| 359 | */ |
||
| 360 | public function getSearchParams() |
||
| 363 | } |
||
| 364 | |||
| 365 | /** |
||
| 366 | * Gets a list of what fields were searched and the values provided |
||
| 367 | * for each field. Returns an ArrayList of ArrayData, suitable for |
||
| 368 | * rendering on a template. |
||
| 369 | * |
||
| 370 | * @return ArrayList |
||
| 371 | */ |
||
| 372 | public function getSummary() |
||
| 410 | } |
||
| 411 | } |
||
| 412 |