Completed
Pull Request — master (#4795)
by Damian
21:26 queued 21:26
created
forms/gridfield/GridFieldPaginator.php 1 patch
Doc Comments   +2 added lines patch added patch discarded remove patch
@@ -50,6 +50,7 @@  discard block
 block discarded – undo
50 50
 	 *
51 51
 	 * By default, this is set to true so that it's clearer what's happening, but the predefined
52 52
 	 * {@link GridFieldConfig} subclasses set this to false for flexibility.
53
+	 * @param boolean $throwExceptionOnBadDataType
53 54
 	 */
54 55
 	public function setThrowExceptionOnBadDataType($throwExceptionOnBadDataType) {
55 56
 		$this->throwExceptionOnBadDataType = $throwExceptionOnBadDataType;
@@ -65,6 +66,7 @@  discard block
 block discarded – undo
65 66
 	/**
66 67
 	 * Check that this dataList is of the right data type.
67 68
 	 * Returns false if it's a bad data type, and if appropriate, throws an exception.
69
+	 * @param SS_List $dataList
68 70
 	 */
69 71
 	protected function checkDataType($dataList) {
70 72
 		if($dataList instanceof SS_Limitable) {
Please login to merge, or discard this patch.
forms/gridfield/GridFieldPrintButton.php 1 patch
Doc Comments   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -66,7 +66,7 @@  discard block
 block discarded – undo
66 66
 	 *
67 67
 	 * @param GridField
68 68
 	 *
69
-	 * @return array
69
+	 * @return string[]
70 70
 	 */
71 71
 	public function getActions($gridField) {
72 72
 		return array('print');
@@ -100,6 +100,7 @@  discard block
 block discarded – undo
100 100
 
101 101
 	/**
102 102
 	 * Handle the print, for both the action button and the URL
103
+ 	 * @param GridField $gridField
103 104
  	 */
104 105
 	public function handlePrint($gridField, $request = null) {
105 106
 		set_time_limit(60);
Please login to merge, or discard this patch.
forms/gridfield/GridFieldSortableHeader.php 1 patch
Doc Comments   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -29,6 +29,7 @@  discard block
 block discarded – undo
29 29
 	 *
30 30
 	 * By default, this is set to true so that it's clearer what's happening, but the predefined
31 31
 	 * {@link GridFieldConfig} subclasses set this to false for flexibility.
32
+	 * @param boolean $throwExceptionOnBadDataType
32 33
 	 */
33 34
 	public function setThrowExceptionOnBadDataType($throwExceptionOnBadDataType) {
34 35
 		$this->throwExceptionOnBadDataType = $throwExceptionOnBadDataType;
@@ -61,7 +62,7 @@  discard block
 block discarded – undo
61 62
 	 * Specify sortings with fieldname as the key, and actual fieldname to sort as value.
62 63
 	 * Example: array("MyCustomTitle"=>"Title", "MyCustomBooleanField" => "ActualBooleanField")
63 64
 	 *
64
-	 * @param array $casting
65
+	 * @param array $sorting
65 66
 	 */
66 67
 	public function setFieldSorting($sorting) {
67 68
 		$this->fieldSorting = $sorting;
Please login to merge, or discard this patch.
forms/gridfield/GridState.php 1 patch
Doc Comments   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -24,8 +24,7 @@
 block discarded – undo
24 24
 
25 25
 	/**
26 26
 	 *
27
-	 * @param GridField $name
28
-	 * @param string $data - json encoded string
27
+	 * @param GridField $grid
29 28
 	 */
30 29
 	public function __construct($grid, $value = null) {
31 30
 		$this->grid = $grid;
Please login to merge, or discard this patch.
forms/HiddenField.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -10,7 +10,7 @@
 block discarded – undo
10 10
 	/**
11 11
 	 * @param array $properties
12 12
 	 *
13
-	 * @return HTMLText
13
+	 * @return string
14 14
 	 */
15 15
 	public function FieldHolder($properties = array()) {
16 16
 		return $this->Field($properties);
Please login to merge, or discard this patch.
forms/HtmlEditorField.php 1 patch
Doc Comments   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -46,7 +46,7 @@  discard block
 block discarded – undo
46 46
 	 *
47 47
 	 * @param string $name The internal field name, passed to forms.
48 48
 	 * @param string $title The human-readable field label.
49
-	 * @param mixed $value The value of the field.
49
+	 * @param integer $value The value of the field.
50 50
 	 * @param string $config HTMLEditorConfig identifier to be used. Default to the active one.
51 51
 	 */
52 52
 	public function __construct($name, $title = null, $value = '', $config = null) {
@@ -174,7 +174,7 @@  discard block
 block discarded – undo
174 174
 	/**
175 175
 	 * Searches the SiteTree for display in the dropdown
176 176
 	 *
177
-	 * @return callback
177
+	 * @return DataList
178 178
 	 */
179 179
 	public function siteTreeSearchCallback($sourceObject, $labelField, $search) {
180 180
 		return DataObject::get($sourceObject)->filterAny(array(
@@ -454,7 +454,7 @@  discard block
 block discarded – undo
454 454
 	/**
455 455
 	 * Find all anchors available on the given page.
456 456
 	 *
457
-	 * @return array
457
+	 * @return string
458 458
 	 */
459 459
 	public function getanchors() {
460 460
 		$id = (int)$this->getRequest()->getVar('PageID');
@@ -1006,7 +1006,7 @@  discard block
 block discarded – undo
1006 1006
 	/**
1007 1007
 	 * Get OEmbed type
1008 1008
 	 *
1009
-	 * @return string
1009
+	 * @return boolean
1010 1010
 	 */
1011 1011
 	public function getType() {
1012 1012
 		return $this->oembed->type;
Please login to merge, or discard this patch.
forms/HtmlEditorSanitiser.php 1 patch
Doc Comments   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -39,7 +39,7 @@  discard block
 block discarded – undo
39 39
 	/**
40 40
 	 * Given a TinyMCE pattern (close to unix glob style), create a regex that does the match
41 41
 	 *
42
-	 * @param $str - The TinyMCE pattern
42
+	 * @param string|null $str - The TinyMCE pattern
43 43
 	 * @return string - The equivalent regex
44 44
 	 */
45 45
 	protected function patternToRegex($str) {
@@ -180,6 +180,7 @@  discard block
 block discarded – undo
180 180
 	/**
181 181
 	 * Given an attribute name, return the rule structure for that attribute
182 182
 	 * @param string $name - The attribute name
183
+	 * @param stdClass $elementRule
183 184
 	 * @return stdClass - The attribute rule
184 185
 	 */
185 186
 	protected function getRuleForAttribute($elementRule, $name) {
Please login to merge, or discard this patch.
forms/InlineFormAction.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -14,7 +14,7 @@
 block discarded – undo
14 14
 
15 15
 	/**
16 16
 	 * Create a new action button.
17
-	 * @param action The method to call when the button is clicked
17
+	 * @param action string method to call when the button is clicked
18 18
 	 * @param title The label on the button
19 19
 	 * @param extraClass A CSS class to apply to the button in addition to 'action'
20 20
 	 */
Please login to merge, or discard this patch.
forms/MoneyField.php 1 patch
Doc Comments   +8 added lines patch added patch discarded remove patch
@@ -32,6 +32,10 @@  discard block
 block discarded – undo
32 32
 	 */
33 33
 	protected $fieldCurrency = null;
34 34
 
35
+	/**
36
+	 * @param string $name
37
+	 * @param string $title
38
+	 */
35 39
 	public function __construct($name, $title = null, $value = "") {
36 40
 		// naming with underscores to prevent values from actually being saved somewhere
37 41
 		$this->fieldAmount = new NumericField("{$name}[Amount]", _t('MoneyField.FIELDLABELAMOUNT', 'Amount'));
@@ -135,6 +139,7 @@  discard block
 block discarded – undo
135 139
 	/**
136 140
 	 * @todo Implement removal of readonly state with $bool=false
137 141
 	 * @todo Set readonly state whenever field is recreated, e.g. in setAllowedCurrencies()
142
+	 * @param boolean $bool
138 143
 	 */
139 144
 	public function setReadonly($bool) {
140 145
 		parent::setReadonly($bool);
@@ -175,6 +180,9 @@  discard block
 block discarded – undo
175 180
 		return $this->allowedCurrencies;
176 181
 	}
177 182
 
183
+	/**
184
+	 * @param string $locale
185
+	 */
178 186
 	public function setLocale($locale) {
179 187
 		$this->_locale = $locale;
180 188
 		return $this;
Please login to merge, or discard this patch.