SilverStripe\ORM\Tests\DataObjectTest\TreeNode

Complexity

Total Complexity

2

Size/Duplication

Total Lines	40
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	write()	0	10	1
A	resetCounts()	0	7	1

<?php

namespace SilverStripe\ORM\Tests\DataObjectTest;

use SilverStripe\Dev\TestOnly;
use SilverStripe\ORM\Connect\Query;
use SilverStripe\ORM\DataObject;
use SilverStripe\ORM\DB;
use SilverStripe\ORM\HasManyList;
use SilverStripe\ORM\Hierarchy\Hierarchy;
use SilverStripe\ORM\ManyManyList;
use SilverStripe\ORM\Queries\SQLUpdate;

/**
 * The purpose of this test class is to test recursive writes and make sure we don't get stuck in an infinite loop.
 * @property int $WriteCount Number of times this object was written sine the last call of `resetCount`
 */
class TreeNode extends DataObject implements TestOnly
{
    private static $table_name = 'DataObjectTest_TreeNode';

The private property $table_name is not used, and could be removed.

    private static $db = [

The private property $db is not used, and could be removed.

        'Title' => 'Varchar',
        'WriteCount' => 'Int'
    ];

    private static $has_one = [

The private property $has_one is not used, and could be removed.

        'Parent' => self::class,
        'Cycle' => self::class,
    ];

    private static $has_many = [

The private property $has_many is not used, and could be removed.

        'Children' => self::class,
    ];

    public function write($showDebug = false, $forceInsert = false, $forceWrite = false, $writeComponents = false)
    {
        // Force the component to fetch its Parent and Cycle relation so we have components to recursively write
        $this->Parent;

The property Parent does not exist on SilverStripe\ORM\Tests\DataObjectTest\TreeNode. Since you implemented __get, consider adding a @property annotation.

        $this->Cycle;

The property Cycle does not exist on SilverStripe\ORM\Tests\DataObjectTest\TreeNode. Since you implemented __get, consider adding a @property annotation.

        // Count a write attempts
        $this->WriteCount++;

        return parent::write($showDebug, $forceInsert, $forceWrite, $writeComponents);
    }

    /**
     * Reset the WriteCount on all TreeNodes
     */
    public function resetCounts()
    {
        $update = new SQLUpdate(
            sprintf('"%s"', self::baseTable()),

The method SilverStripe\ORM\DataObject::baseTable() is not static, but was called statically.

            ['"WriteCount"' => 0]
        );
        $results = $update->execute();

The assignment to $results is dead and can be removed.

    }
}