Completed
Pull Request — master (#4975)
by Peter
12:14 queued 14s
created
model/DB.php 1 patch
Doc Comments   +5 added lines, -4 removed lines patch added patch discarded remove patch
@@ -217,9 +217,8 @@  discard block
 block discarded – undo
217 217
 	 * Given the database configuration, this method will create the correct
218 218
 	 * subclass of {@link SS_Database}.
219 219
 	 *
220
-	 * @param array $database A map of options. The 'type' is the name of the subclass of SS_Database to use. For the
220
+	 * @param array $databaseConfig A map of options. The 'type' is the name of the subclass of SS_Database to use. For the
221 221
 	 *                        rest of the options, see the specific class.
222
-	 * @param string $name identifier for the connection
223 222
 	 *
224 223
 	 * @return SS_Database
225 224
 	 */
@@ -413,7 +412,7 @@  discard block
 block discarded – undo
413 412
 
414 413
 	/**
415 414
 	 * Create a new table.
416
-	 * @param string $tableName The name of the table
415
+	 * @param string $table The name of the table
417 416
 	 * @param array$fields A map of field names to field types
418 417
 	 * @param array $indexes A map of indexes
419 418
 	 * @param array $options An map of additional options.  The available keys are as follows:
@@ -500,6 +499,8 @@  discard block
 block discarded – undo
500 499
 
501 500
 	/**
502 501
 	 * @deprecated since version 4.0 Use DB::require_field instead
502
+	 * @param string $table
503
+	 * @param string $field
503 504
 	 */
504 505
 	public static function requireField($table, $field, $spec) {
505 506
 		Deprecation::notice('4.0', 'Use DB::require_field instead');
@@ -563,7 +564,7 @@  discard block
 block discarded – undo
563 564
 	/**
564 565
 	 * Checks a table's integrity and repairs it if necessary.
565 566
 	 *
566
-	 * @param string $tableName The name of the table.
567
+	 * @param string $table The name of the table.
567 568
 	 * @return boolean Return true if the table has integrity after the method is complete.
568 569
 	 */
569 570
 	public static function check_and_repair_table($table) {
Please login to merge, or discard this patch.
model/fieldtypes/CompositeDBField.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -205,6 +205,9 @@
 block discarded – undo
205 205
 		return null;
206 206
 	}
207 207
 
208
+	/**
209
+	 * @param string $field
210
+	 */
208 211
 	public function hasField($field) {
209 212
 		$fields = $this->compositeDatabaseFields();
210 213
 		return isset($fields[$field]);
Please login to merge, or discard this patch.
model/fieldtypes/Currency.php 1 patch
Doc Comments   +6 added lines patch added patch discarded remove patch
@@ -23,6 +23,9 @@  discard block
 block discarded – undo
23 23
 	 */
24 24
 	private static $currency_symbol = '$';
25 25
 
26
+	/**
27
+	 * @param string $name
28
+	 */
26 29
 	public function __construct($name = null, $wholeSize = 9, $decimalSize = 2, $defaultValue = 0) {
27 30
 		parent::__construct($name, $wholeSize, $decimalSize, $defaultValue);
28 31
 	}
@@ -46,6 +49,9 @@  discard block
 block discarded – undo
46 49
 		else return $val;
47 50
 	}
48 51
 
52
+	/**
53
+	 * @param string $value
54
+	 */
49 55
 	public function setValue($value, $record = null, $markChanged = true) {
50 56
 		$matches = null;
51 57
 		if(is_numeric($value)) {
Please login to merge, or discard this patch.
model/fieldtypes/Date.php 1 patch
Doc Comments   +5 added lines, -2 removed lines patch added patch discarded remove patch
@@ -20,6 +20,9 @@  discard block
 block discarded – undo
20 20
  */
21 21
 class Date extends DBField {
22 22
 
23
+	/**
24
+	 * @param string|null $value
25
+	 */
23 26
 	public function setValue($value, $record = null, $markChanged = true) {
24 27
 		if($value === false || $value === null || (is_string($value) && !strlen($value))) {
25 28
 			// don't try to evaluate empty values with strtotime() below, as it returns "1970-01-01" when it should be
@@ -102,7 +105,7 @@  discard block
 block discarded – undo
102 105
 
103 106
 	/**
104 107
 	 * Returns the day of the month.
105
-	 * @param boolean $includeOrdinals Include ordinal suffix to day, e.g. "th" or "rd"
108
+	 * @param boolean $includeOrdinal Include ordinal suffix to day, e.g. "th" or "rd"
106 109
 	 * @return string
107 110
 	 */
108 111
 	public function DayOfMonth($includeOrdinal = false) {
@@ -156,7 +159,7 @@  discard block
 block discarded – undo
156 159
 	 * Return a date formatted as per a CMS user's settings.
157 160
 	 *
158 161
 	 * @param Member $member
159
-	 * @return boolean | string A date formatted as per user-defined settings.
162
+	 * @return false|string | string A date formatted as per user-defined settings.
160 163
 	 */
161 164
 	public function FormatFromSettings($member = null) {
162 165
 		require_once 'Zend/Date.php';
Please login to merge, or discard this patch.
model/fieldtypes/Datetime.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -97,7 +97,7 @@  discard block
 block discarded – undo
97 97
 	 * Return a date and time formatted as per a CMS user's settings.
98 98
 	 *
99 99
 	 * @param Member $member
100
-	 * @return boolean | string A time and date pair formatted as per user-defined settings.
100
+	 * @return false|string | string A time and date pair formatted as per user-defined settings.
101 101
 	 */
102 102
 	public function FormatFromSettings($member = null) {
103 103
 		require_once 'Zend/Date.php';
@@ -176,7 +176,7 @@  discard block
 block discarded – undo
176 176
 	 * Use {@link clear_mock_now()} to revert to the current system date.
177 177
 	 * Caution: This sets a fixed date that doesn't increment with time.
178 178
 	 *
179
-	 * @param SS_Datetime|string $datetime Either in object format, or as a SS_Datetime compatible string.
179
+	 * @param string $datetime Either in object format, or as a SS_Datetime compatible string.
180 180
 	 */
181 181
 	public static function set_mock_now($datetime) {
182 182
 		if($datetime instanceof SS_Datetime) {
Please login to merge, or discard this patch.
model/fieldtypes/DBClassName.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -180,6 +180,9 @@
 block discarded – undo
180 180
 		return $classNames;
181 181
 	}
182 182
 
183
+	/**
184
+	 * @param DBClassNameTest_ObjectSubClass $record
185
+	 */
183 186
 	public function setValue($value, $record = null, $markChanged = true) {
184 187
 		parent::setValue($value, $record, $markChanged);
185 188
 
Please login to merge, or discard this patch.
model/fieldtypes/Decimal.php 1 patch
Doc Comments   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -15,7 +15,7 @@  discard block
 block discarded – undo
15 15
 	 * @param string $name
16 16
 	 * @param int $wholeSize
17 17
 	 * @param int $decimalSize
18
-	 * @param float $defaultValue
18
+	 * @param integer $defaultValue
19 19
 	 */
20 20
 	public function __construct($name = null, $wholeSize = 9, $decimalSize = 2, $defaultValue = 0) {
21 21
 		$this->wholeSize = is_int($wholeSize) ? $wholeSize : 9;
@@ -27,14 +27,14 @@  discard block
 block discarded – undo
27 27
 	}
28 28
 
29 29
 	/**
30
-	 * @return float
30
+	 * @return string
31 31
 	 */
32 32
 	public function Nice() {
33 33
 		return number_format($this->value, $this->decimalSize);
34 34
 	}
35 35
 
36 36
 	/**
37
-	 * @return int
37
+	 * @return double
38 38
 	 */
39 39
 	public function Int() {
40 40
 		return floor($this->value);
@@ -80,7 +80,7 @@  discard block
 block discarded – undo
80 80
 	}
81 81
 
82 82
 	/**
83
-	 * @return float
83
+	 * @return integer
84 84
 	 */
85 85
 	public function nullValue() {
86 86
 		return 0;
Please login to merge, or discard this patch.
model/fieldtypes/HTMLText.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -36,6 +36,9 @@
 block discarded – undo
36 36
 
37 37
 	protected $whitelist = false;
38 38
 
39
+	/**
40
+	 * @param string $name
41
+	 */
39 42
 	public function __construct($name = null, $options = array()) {
40 43
 		if(is_string($options)) {
41 44
 			$options = array('whitelist' => $options);
Please login to merge, or discard this patch.
model/fieldtypes/Money.php 1 patch
Doc Comments   +7 added lines patch added patch discarded remove patch
@@ -92,6 +92,7 @@  discard block
 block discarded – undo
92 92
 
93 93
 	/**
94 94
 	 * @param string
95
+	 * @param string|null $currency
95 96
 	 */
96 97
 	public function setCurrency($currency, $markChanged = true) {
97 98
 		$this->setField('Currency', $currency, $markChanged);
@@ -142,6 +143,8 @@  discard block
 block discarded – undo
142 143
 	}
143 144
 
144 145
 	/**
146
+	 * @param string $currency
147
+	 * @param string $locale
145 148
 	 * @return string
146 149
 	 */
147 150
 	public function getSymbol($currency = null, $locale = null) {
@@ -153,6 +156,8 @@  discard block
 block discarded – undo
153 156
 	}
154 157
 
155 158
 	/**
159
+	 * @param string $currency
160
+	 * @param string $locale
156 161
 	 * @return string
157 162
 	 */
158 163
 	public function getShortName($currency = null, $locale = null) {
@@ -163,6 +168,8 @@  discard block
 block discarded – undo
163 168
 	}
164 169
 
165 170
 	/**
171
+	 * @param string $currency
172
+	 * @param string $locale
166 173
 	 * @return string
167 174
 	 */
168 175
 	public function getCurrencyName($currency = null, $locale = null) {
Please login to merge, or discard this patch.