Completed
Pull Request — master (#6829)
by Simon
09:20
created
src/Security/MemberAuthenticator/ChangePasswordHandler.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -169,7 +169,7 @@
 block discarded – undo
169 169
     /**
170 170
      * Return a link to this request handler.
171 171
      * The link returned is supplied in the constructor
172
-     * @param null $action
172
+     * @param string $action
173 173
      * @return string
174 174
      */
175 175
     public function link($action = null)
Please login to merge, or discard this patch.
src/Forms/Form.php 1 patch
Doc Comments   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -596,6 +596,7 @@  discard block
 block discarded – undo
596 596
      * Set actions that are exempt from validation
597 597
      *
598 598
      * @param array
599
+     * @param string[] $actions
599 600
      * @return $this
600 601
      */
601 602
     public function setValidationExemptActions($actions)
@@ -1045,7 +1046,7 @@  discard block
 block discarded – undo
1045 1046
      * If set to false then the form method is only used to construct the default
1046 1047
      * form.
1047 1048
      *
1048
-     * @param $bool boolean
1049
+     * @param boolean $bool boolean
1049 1050
      * @return $this
1050 1051
      */
1051 1052
     public function setStrictFormMethodCheck($bool)
Please login to merge, or discard this patch.
src/Security/MemberAuthenticator/MemberAuthenticator.php 1 patch
Doc Comments   +1 added lines patch added patch discarded remove patch
@@ -53,6 +53,7 @@
 block discarded – undo
53 53
      * @param array $data Form submitted data
54 54
      * @param ValidationResult $result
55 55
      * @param Member|null This third parameter is used in the CMSAuthenticator(s)
56
+     * @param Member $member
56 57
      * @return Member Found member, regardless of successful login
57 58
      */
58 59
     protected function authenticateMember($data, &$result = null, $member = null)
Please login to merge, or discard this patch.
src/Security/Security.php 1 patch
Doc Comments   +5 added lines, -4 removed lines patch added patch discarded remove patch
@@ -227,7 +227,7 @@  discard block
 block discarded – undo
227 227
     protected static $currentUser;
228 228
 
229 229
     /**
230
-     * @return array
230
+     * @return Authenticator[]
231 231
      */
232 232
     public static function getAuthenticators()
233 233
     {
@@ -292,7 +292,7 @@  discard block
 block discarded – undo
292 292
      * Get all registered authenticators
293 293
      *
294 294
      * @param int $service The type of service that is requested
295
-     * @return array Return an array of Authenticator objects
295
+     * @return Authenticator[] Return an array of Authenticator objects
296 296
      */
297 297
     public function getApplicableAuthenticators($service = Authenticator::LOGIN)
298 298
     {
@@ -626,7 +626,7 @@  discard block
 block discarded – undo
626 626
      * Combine the given forms into a formset with a tabbed interface
627 627
      *
628 628
      * @param array|Form[] $forms
629
-     * @return string
629
+     * @return DBHTMLText
630 630
      */
631 631
     protected function generateLoginFormSet($forms)
632 632
     {
@@ -1203,6 +1203,7 @@  discard block
 block discarded – undo
1203 1203
 
1204 1204
     /**
1205 1205
      * For the database_is_ready call to return a certain value - used for testing
1206
+     * @param boolean $isReady
1206 1207
      */
1207 1208
     public static function force_database_is_ready($isReady)
1208 1209
     {
@@ -1223,7 +1224,7 @@  discard block
 block discarded – undo
1223 1224
     /**
1224 1225
      * Set to true to ignore access to disallowed actions, rather than returning permission failure
1225 1226
      * Note that this is just a flag that other code needs to check with Security::ignore_disallowed_actions()
1226
-     * @param $flag True or false
1227
+     * @param boolean $flag True or false
1227 1228
      */
1228 1229
     public static function set_ignore_disallowed_actions($flag)
1229 1230
     {
Please login to merge, or discard this patch.