silverstripe / silverstripe-framework

src/Core/Cache/CacheFactory.php

Doc Comments -2 removed lines

@@ -12,8 +12,6 @@
      * Note: While the returned object is used as a singleton (by the originating Injector->get() call),
      * this cache object shouldn't be a singleton itself - it has varying constructor args for the same service name.
      *
-     * @param string $class
-     * @param array $args
      * @return CacheInterface
      */
     public function create($service, array $params = array());

admin/code/LeftAndMain.php

Doc Comments +2 added lines, -2 removed lines

@@ -1002,7 +1002,7 @@ 
      * {@link SSViewer::get_templates_by_class()}
      *
      * @param string $suffix
-     * @return array
+     * @return string
      */
     public function getTemplatesWithSuffix($suffix)
     {
@@ -2154,7 +2154,7 @@ 
     }
 
     /**
-     * @return String
+     * @return DBField
      */
     public function Locale()
     {

src/Control/Director.php

Doc Comments +2 added lines, -2 removed lines

@@ -925,7 +925,7 @@ 
     /**
      * Returns true if the given file exists. Filename should be relative to the site root.
      *
-     * @param $file
+     * @param string $file
      *
      * @return bool
      */
@@ -1153,7 +1153,7 @@ 
      * Can also be checked with {@link Director::isDev()}, {@link Director::isTest()}, and
      * {@link Director::isLive()}.
      *
-     * @return bool
+     * @return string
      */
     public static function get_environment_type()
     {

src/Core/Manifest/Module.php

Doc Comments +4 added lines

@@ -28,6 +28,10 @@
      */
     protected $composerData = null;
 
+    /**
+     * @param string $path
+     * @param string $base
+     */
     public function __construct($path, $base)
     {
         $this->path = rtrim($path, '/\\');

src/Dev/FunctionalTest.php

Doc Comments +2 added lines, -2 removed lines

@@ -226,7 +226,7 @@ 
      * Find an attribute in a SimpleXMLElement object by name.
      * @param SimpleXMLElement $object
      * @param string $attribute Name of attribute to find
-     * @return SimpleXMLElement object of the attribute
+     * @return boolean object of the attribute
      */
     public function findAttribute($object, $attribute)
     {
@@ -260,7 +260,7 @@ 
      * Note:   characters are stripped from the content; make sure that your assertions take this into account.
      *
      * @param string $selector A basic CSS selector, e.g. 'li.jobs h3'
-     * @param array|string $expectedMatches The content of at least one of the matched tags
+     * @param string[] $expectedMatches The content of at least one of the matched tags
      * @param string $message
      * @throws PHPUnit_Framework_AssertionFailedError
      */

src/Dev/SapphireTest.php

Doc Comments +7 added lines, -4 removed lines

@@ -184,6 +184,9 @@ 
         return self::$is_running_test;
     }
 
+    /**
+     * @param boolean $bool
+     */
     public static function set_is_running_test($bool)
     {
         self::$is_running_test = $bool;
@@ -658,10 +661,10 @@ 
     /**
      * Assert that the matching email was sent since the last call to clearEmails()
      * All of the parameters can either be a string, or, if they start with "/", a PREG-compatible regular expression.
-     * @param $to
+     * @param string $to
      * @param $from
-     * @param $subject
-     * @param $content
+     * @param string $subject
+     * @param string $content
      * @return array Contains the keys: 'type', 'to', 'from', 'subject', 'content', 'plainContent', 'attachedFiles',
      *               'customHeaders', 'htmlContent', inlineImages'
      */
@@ -894,7 +897,7 @@ 
      * @param string $expectedSQL
      * @param string $actualSQL
      * @param string $message
-     * @param float|int $delta
+     * @param integer $delta
      * @param integer $maxDepth
      * @param boolean $canonicalize
      * @param boolean $ignoreCase

src/Security/PasswordEncryptor_Blowfish.php

Doc Comments +5 added lines

@@ -165,6 +165,11 @@
         return sprintf('%02d', self::$cost) . '$' . substr($generator->randomToken('sha1'), 0, 22);
     }
 
+    /**
+     * @param string|false $hash
+     * @param string $password
+     * @param string $salt
+     */
     public function check($hash, $password, $salt = null, $member = null)
     {
         if (strpos($hash, '$2y$') === 0) {

tests/php/Assets/Storage/AssetStoreTest/TestAssetStore.php

Doc Comments +6 added lines

@@ -163,6 +163,9 @@ 
     }
 
 
+    /**
+     * @param string $fileID
+     */
     public function getOriginalFilename($fileID)
     {
         return parent::getOriginalFilename($fileID);
@@ -173,6 +176,9 @@ 
         return parent::removeVariant($fileID);
     }
 
+    /**
+     * @param null|string $variant
+     */
     public function getDefaultConflictResolution($variant)
     {
         return parent::getDefaultConflictResolution($variant);

src/Forms/Form.php

Doc Comments +3 added lines, -2 removed lines

@@ -494,7 +494,7 @@ 
      * The callback can opt out of handling specific responses by returning NULL,
      * in which case the default form behaviour will kick in.
      *
-     * @param $callback
+     * @param \Closure $callback
      * @return self
      */
     public function setValidationResponseCallback($callback)
@@ -596,6 +596,7 @@ 
      * Set actions that are exempt from validation
      *
      * @param array
+     * @param string[] $actions
      * @return $this
      */
     public function setValidationExemptActions($actions)
@@ -1043,7 +1044,7 @@ 
      * If set to false (the default), then the form method is only used to construct the default
      * form.
      *
-     * @param $bool boolean
+     * @param boolean $bool boolean
      * @return $this
      */
     public function setStrictFormMethodCheck($bool)