Completed
Pull Request — master (#6699)
by Sam
09:28
created
src/Forms/HTMLEditor/HTMLEditorField.php 1 patch
Doc Comments   +5 added lines, -2 removed lines patch added patch discarded remove patch
@@ -79,7 +79,7 @@  discard block
 block discarded – undo
79 79
     /**
80 80
      * Assign a new configuration instance or identifier
81 81
      *
82
-     * @param string|HTMLEditorConfig $config
82
+     * @param string $config
83 83
      * @return $this
84 84
      */
85 85
     public function setEditorConfig($config)
@@ -94,7 +94,7 @@  discard block
 block discarded – undo
94 94
      *
95 95
      * @param string $name The internal field name, passed to forms.
96 96
      * @param string $title The human-readable field label.
97
-     * @param mixed $value The value of the field.
97
+     * @param integer $value The value of the field.
98 98
      * @param string $config HTMLEditorConfig identifier to be used. Default to the active one.
99 99
      */
100 100
     public function __construct($name, $title = null, $value = '', $config = null)
@@ -142,6 +142,9 @@  discard block
 block discarded – undo
142 142
         $record->{$this->name} = $htmlValue->getContent();
143 143
     }
144 144
 
145
+    /**
146
+     * @param string|null $value
147
+     */
145 148
     public function setValue($value, $data = null)
146 149
     {
147 150
         // Regenerate links prior to preview, so that the editor can see them.
Please login to merge, or discard this patch.
src/Forms/MemberDatetimeOptionsetField.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -156,6 +156,9 @@
 block discarded – undo
156 156
         return parent::setSubmittedValue($value);
157 157
     }
158 158
 
159
+    /**
160
+     * @param string $value
161
+     */
159 162
     public function setValue($value, $data = null)
160 163
     {
161 164
         if (is_array($value)) {
Please login to merge, or discard this patch.
src/Forms/MoneyField.php 1 patch
Doc Comments   +9 added lines, -2 removed lines patch added patch discarded remove patch
@@ -57,6 +57,10 @@  discard block
 block discarded – undo
57 57
         return $this->fieldAmount;
58 58
     }
59 59
 
60
+    /**
61
+     * @param string $name
62
+     * @param string $title
63
+     */
60 64
     public function __construct($name, $title = null, $value = "")
61 65
     {
62 66
         $this->setName($name);
@@ -210,7 +214,7 @@  discard block
 block discarded – undo
210 214
      *
211 215
      * (see @link MoneyFieldTest_CustomSetter_Object for more information)
212 216
      *
213
-     * @param DataObjectInterface|Object $dataObject
217
+     * @param DataObjectInterface $dataObject
214 218
      */
215 219
     public function saveInto(DataObjectInterface $dataObject)
216 220
     {
@@ -238,6 +242,9 @@  discard block
 block discarded – undo
238 242
         return $clone;
239 243
     }
240 244
 
245
+    /**
246
+     * @param boolean $bool
247
+     */
241 248
     public function setReadonly($bool)
242 249
     {
243 250
         parent::setReadonly($bool);
@@ -261,7 +268,7 @@  discard block
 block discarded – undo
261 268
     /**
262 269
      * Set list of currencies. Currencies should be in the 3-letter ISO 4217 currency code.
263 270
      *
264
-     * @param array $currencies
271
+     * @param string[] $currencies
265 272
      * @return $this
266 273
      */
267 274
     public function setAllowedCurrencies($currencies)
Please login to merge, or discard this patch.
src/Forms/NumericField.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -279,7 +279,7 @@
 block discarded – undo
279 279
      * Get number of digits to show to the right of the decimal point.
280 280
      * 0 for integer, any number for floating point, or null to flexible
281 281
      *
282
-     * @return int|null
282
+     * @return string
283 283
      */
284 284
     public function getScale()
285 285
     {
Please login to merge, or discard this patch.
src/Forms/SelectionGroup_Item.php 1 patch
Doc Comments   +6 added lines patch added patch discarded remove patch
@@ -37,6 +37,9 @@  discard block
 block discarded – undo
37 37
         return $this->title;
38 38
     }
39 39
 
40
+    /**
41
+     * @param string $title
42
+     */
40 43
     function setTitle($title)
41 44
     {
42 45
         $this->title = $title;
@@ -48,6 +51,9 @@  discard block
 block discarded – undo
48 51
         return $this->value;
49 52
     }
50 53
 
54
+    /**
55
+     * @param string $Value
56
+     */
51 57
     function setValue($Value, $data = null)
52 58
     {
53 59
         $this->value = $Value;
Please login to merge, or discard this patch.
src/i18n/i18n.php 1 patch
Doc Comments   -6 removed lines patch added patch discarded remove patch
@@ -141,12 +141,6 @@
 block discarded – undo
141 141
      * @param string $entity Entity that identifies the string. It must be in the form
142 142
      * "Namespace.Entity" where Namespace will be usually the class name where this
143 143
      * string is used and Entity identifies the string inside the namespace.
144
-     * @param mixed $arg,... Additional arguments are parsed as such:
145
-     *  - Next string argument is a default. Pass in a `|` pipe-delimited value with `{count}`
146
-     *    to do pluralisation.
147
-     *  - Any other string argument after default is context for i18nTextCollector
148
-     *  - Any array argument in any order is an injection parameter list. Pass in a `count`
149
-     *    injection parameter to pluralise.
150 144
      * @return string
151 145
      */
152 146
     public static function _t($entity, $arg = null)
Please login to merge, or discard this patch.
src/ORM/FieldType/DBDatetime.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -85,7 +85,7 @@
 block discarded – undo
85 85
      * Return a date and time formatted as per a CMS user's settings.
86 86
      *
87 87
      * @param Member $member
88
-     * @return boolean | string A time and date pair formatted as per user-defined settings.
88
+     * @return null|string | string A time and date pair formatted as per user-defined settings.
89 89
      */
90 90
     public function FormatFromSettings($member = null)
91 91
     {
Please login to merge, or discard this patch.
src/ORM/FieldType/DBTime.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -26,6 +26,9 @@
 block discarded – undo
26 26
      */
27 27
     const ISO_TIME = 'HH:mm:ss';
28 28
 
29
+    /**
30
+     * @param string $value
31
+     */
29 32
     public function setValue($value, $record = null, $markChanged = true)
30 33
     {
31 34
         $value = $this->parseTime($value);
Please login to merge, or discard this patch.
src/ORM/FieldType/DBDate.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -245,7 +245,7 @@  discard block
 block discarded – undo
245 245
      * Return a date formatted as per a CMS user's settings.
246 246
      *
247 247
      * @param Member $member
248
-     * @return boolean | string A date formatted as per user-defined settings.
248
+     * @return null|string | string A date formatted as per user-defined settings.
249 249
      */
250 250
     public function FormatFromSettings($member = null)
251 251
     {
@@ -551,7 +551,7 @@  discard block
 block discarded – undo
551 551
      * Attempt to split date string into year, month, day, and timestamp components.
552 552
      *
553 553
      * @param string $value
554
-     * @return array
554
+     * @return string[]
555 555
      */
556 556
     protected function explodeDateString($value)
557 557
     {
Please login to merge, or discard this patch.