Completed
Pull Request — master (#6699)
by Sam
09:28
created
admin/code/CMSMenu.php 1 patch
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -117,7 +117,7 @@  discard block
 block discarded – undo
117 117
      * @param array $attributes an array of attributes to include on the link.
118 118
      * @param string $iconClass
119 119
      *
120
-     * @return boolean The result of the operation.
120
+     * @return boolean|null The result of the operation.
121 121
      */
122 122
     public static function add_link($code, $menuTitle, $url, $priority = -1, $attributes = null, $iconClass = null)
123 123
     {
@@ -140,7 +140,7 @@  discard block
 block discarded – undo
140 140
      * @param array $attributes an array of attributes to include on the link.
141 141
      * @param string $iconClass
142 142
      *
143
-     * @return bool Success
143
+     * @return boolean|null Success
144 144
      */
145 145
     public static function add_menu_item(
146 146
         $code,
@@ -322,7 +322,7 @@  discard block
 block discarded – undo
322 322
      * @param array $attributes an array of attributes to include on the link.
323 323
      * @param string $iconClass
324 324
      *
325
-     * @return bool Success
325
+     * @return boolean|null Success
326 326
      */
327 327
     public static function replace_menu_item(
328 328
         $code,
Please login to merge, or discard this patch.
admin/thirdparty/jstree/_demo/_inc/class._database.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -92,6 +92,9 @@
 block discarded – undo
92 92
 		return $return;
93 93
 	}
94 94
 
95
+	/**
96
+	 * @param boolean $index
97
+	 */
95 98
 	function f($index) {
96 99
 		return stripslashes($this->row[$index]);
97 100
 	}
Please login to merge, or discard this patch.
admin/thirdparty/jstree/_demo/_inc/class._database_i.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -92,6 +92,9 @@
 block discarded – undo
92 92
 		return $return;
93 93
 	}
94 94
 
95
+	/**
96
+	 * @param boolean $index
97
+	 */
95 98
 	function f($index) {
96 99
 		return stripslashes($this->row[$index]);
97 100
 	}
Please login to merge, or discard this patch.
src/Assets/Flysystem/AssetAdapter.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -42,6 +42,9 @@
 block discarded – undo
42 42
         ]
43 43
     );
44 44
 
45
+    /**
46
+     * @param string $root
47
+     */
45 48
     public function __construct($root = null, $writeFlags = LOCK_EX, $linkHandling = self::DISALLOW_LINKS)
46 49
     {
47 50
         // Get root path, and ensure that this exists and is safe
Please login to merge, or discard this patch.
src/Forms/FieldList.php 1 patch
Doc Comments   +6 added lines, -2 removed lines patch added patch discarded remove patch
@@ -89,6 +89,9 @@  discard block
 block discarded – undo
89 89
         $this->sequentialSaveableSet = null;
90 90
     }
91 91
 
92
+    /**
93
+     * @param FormField[] $list
94
+     */
92 95
     protected function collateDataFields(&$list, $saveableOnly = false)
93 96
     {
94 97
         if (!isset($list)) {
@@ -198,7 +201,7 @@  discard block
 block discarded – undo
198 201
      * Removes a number of fields from a Tab/TabSet within this FieldList.
199 202
      *
200 203
      * @param string $tabName The name of the Tab or TabSet field
201
-     * @param array $fields A list of fields, e.g. array('Name', 'Email')
204
+     * @param string[] $fields A list of fields, e.g. array('Name', 'Email')
202 205
      */
203 206
     public function removeFieldsFromTab($tabName, $fields)
204 207
     {
@@ -625,7 +628,7 @@  discard block
 block discarded – undo
625 628
     }
626 629
 
627 630
     /**
628
-     * @param $field
631
+     * @param CompositeField $field
629 632
      * @return $this
630 633
      */
631 634
     public function setContainerField($field)
@@ -707,6 +710,7 @@  discard block
 block discarded – undo
707 710
      * the children collection. Doesn't work recursively.
708 711
      *
709 712
      * @param string|FormField
713
+     * @param string $field
710 714
      * @return int Position in children collection (first position starts with 0).
711 715
      * Returns FALSE if the field can't be found.
712 716
      */
Please login to merge, or discard this patch.
src/Forms/GridField/GridFieldPrintButton.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -77,7 +77,7 @@
 block discarded – undo
77 77
      *
78 78
      * @param GridField
79 79
      *
80
-     * @return array
80
+     * @return string[]
81 81
      */
82 82
     public function getActions($gridField)
83 83
     {
Please login to merge, or discard this patch.
src/ORM/DataObjectSchema.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -701,7 +701,7 @@
 block discarded – undo
701 701
      * @param string $parentClass Parent class name
702 702
      * @param string $component ManyMany name
703 703
      * @param string|array $specification Declaration of many_many relation type
704
-     * @return array
704
+     * @return string[]
705 705
      */
706 706
     protected function parseManyManyComponent($parentClass, $component, $specification)
707 707
     {
Please login to merge, or discard this patch.
src/Security/CMSSecurity.php 1 patch
Doc Comments   +6 added lines patch added patch discarded remove patch
@@ -41,6 +41,9 @@  discard block
 block discarded – undo
41 41
         Requirements::javascript(FRAMEWORK_ADMIN_DIR . '/client/dist/js/vendor.js');
42 42
     }
43 43
 
44
+    /**
45
+     * @param string $action
46
+     */
44 47
     public function Link($action = null)
45 48
     {
46 49
         /** @skipUpgrade */
@@ -60,6 +63,9 @@  discard block
 block discarded – undo
60 63
         return null;
61 64
     }
62 65
 
66
+    /**
67
+     * @param string $title
68
+     */
63 69
     public function getResponseController($title)
64 70
     {
65 71
         // Use $this to prevent use of Page to render underlying templates
Please login to merge, or discard this patch.
src/Forms/DatetimeField.php 1 patch
Doc Comments   +17 added lines, -1 removed lines patch added patch discarded remove patch
@@ -54,6 +54,10 @@  discard block
 block discarded – undo
54 54
      */
55 55
     protected $dateTimeOrder = '{date} {time}';
56 56
 
57
+    /**
58
+     * @param string $name
59
+     * @param string $title
60
+     */
57 61
     public function __construct($name, $title = null, $value = "")
58 62
     {
59 63
         $this->timeField = TimeField::create($name . '[time]', false);
@@ -61,6 +65,9 @@  discard block
 block discarded – undo
61 65
         parent::__construct($name, $title, $value);
62 66
     }
63 67
 
68
+    /**
69
+     * @param Form $form
70
+     */
64 71
     public function setForm($form)
65 72
     {
66 73
         parent::setForm($form);
@@ -69,6 +76,9 @@  discard block
 block discarded – undo
69 76
         return $this;
70 77
     }
71 78
 
79
+    /**
80
+     * @param string $name
81
+     */
72 82
     public function setName($name)
73 83
     {
74 84
         parent::setName($name);
@@ -152,7 +162,7 @@  discard block
 block discarded – undo
152 162
     /**
153 163
      * Assign value from iso8601 string
154 164
      *
155
-     * @param mixed $value
165
+     * @param string $value
156 166
      * @param mixed $data
157 167
      * @return $this
158 168
      */
@@ -260,6 +270,9 @@  discard block
 block discarded – undo
260 270
         return $this;
261 271
     }
262 272
 
273
+    /**
274
+     * @param boolean $bool
275
+     */
263 276
     public function setReadonly($bool)
264 277
     {
265 278
         parent::setReadonly($bool);
@@ -345,6 +358,9 @@  discard block
 block discarded – undo
345 358
         return $this->dateField->getLocale();
346 359
     }
347 360
 
361
+    /**
362
+     * @param RequiredFields $validator
363
+     */
348 364
     public function validate($validator)
349 365
     {
350 366
         $dateValid = $this->dateField->validate($validator);
Please login to merge, or discard this patch.