ChangeSet::getDescription() - Code Metrics - Inspection of "Merge pull request #5304 from open-sausages/pulls/..." - silverstripe/silverstripe-framework - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 954f36...38025f )

by Hamish

created 2016-04-14 02:02 UTC

ChangeSet::getDescription() F

↳ Parent: ChangeSet

Complexity

Conditions	16
Paths	651

Size

Total Lines	107
Code Lines	58

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
c	1
b	0
f	1
dl	0
loc	107
rs	2.3966
cc	16
eloc	58
nc	651
nop	0

How to fix Long Method Complexity

<?php

// namespace SilverStripe\Framework\Model\Versioning

/**
 * The ChangeSet model tracks several VersionedAndStaged objects for later publication as a single
 * atomic action
 *
 * @method HasManyList Changes()
 * @method Member Owner()
 * @property string $Name
 * @property string $State
 *
 * @package framework
 * @subpackage model
 */
class ChangeSet extends DataObject {

	private static $singular_name = 'Campaign';

	private static $plural_name = 'Campaigns';

	/** An active changeset */
	const STATE_OPEN = 'open';

	/** A changeset which is reverted and closed */
	const STATE_REVERTED = 'reverted';

	/** A changeset which is published and closed */
	const STATE_PUBLISHED = 'published';

	private static $db = array(
		'Name'  => 'Varchar',
		'State' => "Enum('open,published,reverted','open')",
	);

	private static $has_many = array(
		'Changes' => 'ChangeSetItem',
	);

	private static $defaults = array(
		'State' => 'open'
	);

	private static $has_one = array(
		'Owner' => 'Member',
	);

	private static $casting = array(
		'Description' => 'Text',
	);

	/**
	 * List of classes to set apart in description
	 *
	 * @config
	 * @var array
	 */
	private static $important_classes = array(
		'SiteTree',
		'File',
	);

	/**
	 * Default permission to require for publishers.
	 * Publishers must either be able to use the campaign admin, or have all admin access.
	 *
	 * Also used as default permission for ChangeSetItem default permission.
	 *
	 * @config
	 * @var array
	 */
	private static $required_permission = array('CMS_ACCESS_CampaignAdmin', 'CMS_ACCESS_LeftAndMain');

	/**
	 * Publish this changeset, then closes it.
	 *
	 * @throws Exception
	 */
	public function publish() {
		// Logical checks prior to publish
		if($this->State !== static::STATE_OPEN) {
			throw new BadMethodCallException(
				"ChangeSet can't be published if it has been already published or reverted."
			);
		}
		if(!$this->isSynced()) {
			throw new ValidationException(
				"ChangeSet does not include all necessary changes and cannot be published."
			);
		}
		if(!$this->canPublish()) {
			throw new Exception("The current member does not have permission to publish this ChangeSet.");
		}

		DB::get_conn()->withTransaction(function(){
			foreach($this->Changes() as $change) {
				/** @var ChangeSetItem $change */
				$change->publish();
			}

			$this->State = static::STATE_PUBLISHED;
			$this->write();
		});
	}

	/**
	 * Add a new change to this changeset. Will automatically include all owned
	 * changes as those are dependencies of this item.
	 *
	 * @param DataObject $object
	 */
	public function addObject(DataObject $object) {
		if(!$this->isInDB()) {
			throw new BadMethodCallException("ChangeSet must be saved before adding items");
		}

		$references = [
			'ObjectID'    => $object->ID,
			'ObjectClass' => $object->ClassName
		];

		// Get existing item in case already added
		$item = $this->Changes()->filter($references)->first();

		if (!$item) {
			$item = new ChangeSetItem($references);
			$this->Changes()->add($item);
		}

		$item->ReferencedBy()->removeAll();

		$item->Added = ChangeSetItem::EXPLICITLY;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
		$item->write();


		$this->sync();
	}

	/**
	 * Remove an item from this changeset. Will automatically remove all changes
	 * which own (and thus depend on) the removed item.
	 *
	 * @param DataObject $object
	 */
	public function removeObject(DataObject $object) {
		$item = ChangeSetItem::get()->filter([
				'ObjectID' => $object->ID,
				'ObjectClass' => $object->ClassName,
				'ChangeSetID' => $this->ID
			])->first();

		if ($item) {
			// TODO: Handle case of implicit added item being removed.

			$item->delete();
		}

		$this->sync();
	}

	protected function implicitKey($item) {
		if ($item instanceof ChangeSetItem) return $item->ObjectClass.'.'.$item->ObjectID;
		return $item->ClassName.'.'.$item->ID;
	}

	protected function calculateImplicit() {
		/** @var string[][] $explicit List of all items that have been explicitly added to this ChangeSet */
		$explicit = array();

		/** @var string[][] $referenced List of all items that are "referenced" by items in $explicit */
		$referenced = array();

		/** @var string[][] $references List of which explicit items reference each thing in referenced */
		$references = array();

		foreach ($this->Changes()->filter(['Added' => ChangeSetItem::EXPLICITLY]) as $item) {
			$explicitKey = $this->implicitKey($item);
			$explicit[$explicitKey] = true;

			foreach ($item->findReferenced() as $referee) {
				$key = $this->implicitKey($referee);

				$referenced[$key] = [
					'ObjectID' => $referee->ID,
					'ObjectClass' => $referee->ClassName
				];

				$references[$key][] = $item->ID;
			}
		}

		/** @var string[][] $explicit List of all items that are either in $explicit, $referenced or both */
		$all = array_merge($referenced, $explicit);

		/** @var string[][] $implicit Anything that is in $all, but not in $explicit, is an implicit inclusion */
		$implicit = array_diff_key($all, $explicit);

		foreach($implicit as $key => $object) {
			$implicit[$key]['ReferencedBy'] = $references[$key];
		}

		return $implicit;
	}

	/**
	 * Add implicit changes that should be included in this changeset
	 *
	 * When an item is created or changed, all it's owned items which have
	 * changes are implicitly added
	 *
	 * When an item is deleted, it's owner (even if that owner does not have changes)
	 * is implicitly added
	 */
	public function sync() {
		// Start a transaction (if we can)
		DB::get_conn()->withTransaction(function() {

			// Get the implicitly included items for this ChangeSet
			$implicit = $this->calculateImplicit();

			// Adjust the existing implicit ChangeSetItems for this ChangeSet
			foreach ($this->Changes()->filter(['Added' => ChangeSetItem::IMPLICITLY]) as $item) {
				$objectKey = $this->implicitKey($item);

				// If a ChangeSetItem exists, but isn't in $implicit, it's no longer required, so delete it
				if (!array_key_exists($objectKey, $implicit)) {
					$item->delete();
				}
				// Otherwise it is required, so update ReferencedBy and remove from $implicit
				else {
					$item->ReferencedBy()->setByIDList($implicit[$objectKey]['ReferencedBy']);
					unset($implicit[$objectKey]);
				}
			}

			// Now $implicit is all those items that are implicitly included, but don't currently have a ChangeSetItem.
			// So create new ChangeSetItems to match

			foreach ($implicit as $key => $props) {
				$item = new ChangeSetItem($props);
				$item->Added = ChangeSetItem::IMPLICITLY;
				$item->ChangeSetID = $this->ID;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
				$item->ReferencedBy()->setByIDList($props['ReferencedBy']);
				$item->write();
			}
		});
	}

	/** Verify that any objects in this changeset include all owned changes */
	public function isSynced() {
		$implicit = $this->calculateImplicit();

		// Check the existing implicit ChangeSetItems for this ChangeSet

		foreach ($this->Changes()->filter(['Added' => ChangeSetItem::IMPLICITLY]) as $item) {
			$objectKey = $this->implicitKey($item);

			// If a ChangeSetItem exists, but isn't in $implicit -> validation failure
			if (!array_key_exists($objectKey, $implicit)) return false;
			// Exists, remove from $implicit
			unset($implicit[$objectKey]);
		}

		// If there's anything left in $implicit -> validation failure
		return empty($implicit);
	}

	public function canView($member = null) {
		return $this->can(__FUNCTION__, $member);
	}

	public function canEdit($member = null) {
		return $this->can(__FUNCTION__, $member);
	}

	public function canCreate($member = null, $context = array()) {
		return $this->can(__FUNCTION__, $member, $context);
	}

	public function canDelete($member = null) {
		return $this->can(__FUNCTION__, $member);
	}

	/**
	 * Check if this item is allowed to be published
	 *
	 * @param Member $member
	 * @return bool
	 */
	public function canPublish($member = null) {
		// All changes must be publishable
		foreach($this->Changes() as $change) {
			/** @var ChangeSetItem $change */
			if(!$change->canPublish($member)) {
				return false;
			}
		}

		// Default permission
		return $this->can(__FUNCTION__, $member);
	}

	/**
	 * Check if this changeset (if published) can be reverted
	 *
	 * @param Member $member
	 * @return bool
	 */
	public function canRevert($member = null) {
		// All changes must be publishable
		foreach($this->Changes() as $change) {
			/** @var ChangeSetItem $change */
			if(!$change->canRevert($member)) {
function notNullable(stdClass $x) { }

// Unsafe
function withoutCheck(stdClass $x = null) {
    notNullable($x);
}

// Safe - Alternative 1: Adding Additional Type-Check
function withCheck(stdClass $x = null) {
    if ($x instanceof stdClass) {
        notNullable($x);
    }
}

// Safe - Alternative 2: Changing Parameter
function withNonNullableParam(stdClass $x) {
    notNullable($x);
}
				return false;
			}
		}

		// Default permission
		return $this->can(__FUNCTION__, $member);
	}

	/**
	 * Default permissions for this changeset
	 *
	 * @param string $perm
	 * @param Member $member
	 * @param array $context
	 * @return bool
	 */
	public function can($perm, $member = null, $context = array()) {
		if(!$member) {
			$member = Member::currentUser();
		}

		// Allow extensions to bypass default permissions, but only if
		// each change can be individually published.
		$extended = $this->extendedCan($perm, $member, $context);
		if($extended !== null) {
			return $extended;
		}

		// Default permissions
		return (bool)Permission::checkMember($member, $this->config()->required_permission);
	}

	public function getCMSFields() {
		$fields = new FieldList();
		$fields->merge([
			TextField::create('Name'),
			ReadonlyField::create('State')
		]);
		$this->extend('updateCMSFields', $fields);
		return $fields;
	}

	/**
	 * Gets summary of items in changeset
	 *
	 * @return string
	 */
	public function getDescription() {
		// Initialise list of items to count
		$counted = [];
		$countedOther = 0;
		foreach($this->config()->important_classes as $type) {
			if(class_exists($type)) {
				$counted[$type] = 0;
			}
		}

		// Check each change item
		/** @var ChangeSetItem $change */
		foreach($this->Changes() as $change) {
			$found = false;
			foreach($counted as $class => $num) {
				if(is_a($change->ObjectClass, $class, true)) {
					$counted[$class]++;
					$found = true;
					break;
				}
			}
			if(!$found) {
				$countedOther++;
			}
		}

		// Describe set based on this output
		$counted = array_filter($counted);

		// Empty state
		if(empty($counted) && empty($countedOther)) {
			return '';
		}

		// Put all parts together
		$parts = [];
		foreach($counted as $class => $count) {
			$parts[] = DataObject::singleton($class)->i18n_pluralise($count);
		}

		// Describe non-important items
		if($countedOther) {
			if ($counted) {

				$parts[] = i18n::pluralise(
					_t('ChangeSet.DESCRIPTION_OTHER_ITEM', 'other item'),
					_t('ChangeSet.DESCRIPTION_OTHER_ITEMS', 'other items'),
					$countedOther
				);
			} else {
				$parts[] = i18n::pluralise(
					_t('ChangeSet.DESCRIPTION_ITEM', 'item'),
					_t('ChangeSet.DESCRIPTION_ITEMS', 'items'),
					$countedOther
				);
			}
		}

		// Figure out how to join everything together
		if(empty($parts)) {
			return '';
		}
		if(count($parts) === 1) {
			return $parts[0];
		}

		// Non-comma list
		if(count($parts) === 2) {
			return _t(
				'ChangeSet.DESCRIPTION_AND',
				'{first} and {second}',
				[
					'first' => $parts[0],
					'second' => $parts[1],
				]
			);
		}

		// First item
		$string = _t(
			'ChangeSet.DESCRIPTION_LIST_FIRST',
			'{item}',
			['item' => $parts[0]]
		);

		// Middle items
		for($i = 1; $i < count($parts) - 1; $i++) {
			$string = _t(
				'ChangeSet.DESCRIPTION_LIST_MID',
				'{list}, {item}',
				[
					'list' => $string,
					'item' => $parts[$i]
				]
			);
		}

		// Oxford comma
		$string = _t(
			'ChangeSet.DESCRIPTION_LIST_LAST',
			'{list}, and {item}',
			[
				'list' => $string,
				'item' => end($parts)
			]
		);
		return $string;
	}
}


1			<?php
2
3			// namespace SilverStripe\Framework\Model\Versioning
4
5			/**
6			* The ChangeSet model tracks several VersionedAndStaged objects for later publication as a single
7			* atomic action
8			*
9			* @method HasManyList Changes()
10			* @method Member Owner()
11			* @property string $Name
12			* @property string $State
13			*
14			* @package framework
15			* @subpackage model
16			*/
17			class ChangeSet extends DataObject {
18
19			private static $singular_name = 'Campaign';
20
21			private static $plural_name = 'Campaigns';
22
23			/** An active changeset */
24			const STATE_OPEN = 'open';
25
26			/** A changeset which is reverted and closed */
27			const STATE_REVERTED = 'reverted';
28
29			/** A changeset which is published and closed */
30			const STATE_PUBLISHED = 'published';
31
32			private static $db = array(
33			'Name' => 'Varchar',
34			'State' => "Enum('open,published,reverted','open')",
35			);
36
37			private static $has_many = array(
38			'Changes' => 'ChangeSetItem',
39			);
40
41			private static $defaults = array(
42			'State' => 'open'
43			);
44
45			private static $has_one = array(
46			'Owner' => 'Member',
47			);
48
49			private static $casting = array(
50			'Description' => 'Text',
51			);
52
53			/**
54			* List of classes to set apart in description
55			*
56			* @config
57			* @var array
58			*/
59			private static $important_classes = array(
60			'SiteTree',
61			'File',
62			);
63
64			/**
65			* Default permission to require for publishers.
66			* Publishers must either be able to use the campaign admin, or have all admin access.
67			*
68			* Also used as default permission for ChangeSetItem default permission.
69			*
70			* @config
71			* @var array
72			*/
73			private static $required_permission = array('CMS_ACCESS_CampaignAdmin', 'CMS_ACCESS_LeftAndMain');
74
75			/**
76			* Publish this changeset, then closes it.
77			*
78			* @throws Exception
79			*/
80			public function publish() {
81			// Logical checks prior to publish
82			if($this->State !== static::STATE_OPEN) {
83			throw new BadMethodCallException(
84			"ChangeSet can't be published if it has been already published or reverted."
85			);
86			}
87			if(!$this->isSynced()) {
88			throw new ValidationException(
89			"ChangeSet does not include all necessary changes and cannot be published."
90			);
91			}
92			if(!$this->canPublish()) {
93			throw new Exception("The current member does not have permission to publish this ChangeSet.");
94			}
95
96			DB::get_conn()->withTransaction(function(){
97			foreach($this->Changes() as $change) {
98			/** @var ChangeSetItem $change */
99			$change->publish();
100			}
101
102			$this->State = static::STATE_PUBLISHED;
103			$this->write();
104			});
105			}
106
107			/**
108			* Add a new change to this changeset. Will automatically include all owned
109			* changes as those are dependencies of this item.
110			*
111			* @param DataObject $object
112			*/
113			public function addObject(DataObject $object) {
114			if(!$this->isInDB()) {
115			throw new BadMethodCallException("ChangeSet must be saved before adding items");
116			}
117
118			$references = [
119			'ObjectID' => $object->ID,
120			'ObjectClass' => $object->ClassName
121			];
122
123			// Get existing item in case already added
124			$item = $this->Changes()->filter($references)->first();
125
126			if (!$item) {
127			$item = new ChangeSetItem($references);
128			$this->Changes()->add($item);
129			}
130
131			$item->ReferencedBy()->removeAll();
132
133			$item->Added = ChangeSetItem::EXPLICITLY;
			0 ignored issues – show Documentation introduced 2016-03-29 22:33 UTC by Report Bug Copy Issue Report The property `Added` does not exist on `object<DataObject>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
134			$item->write();
135
136
137			$this->sync();
138			}
139
140			/**
141			* Remove an item from this changeset. Will automatically remove all changes
142			* which own (and thus depend on) the removed item.
143			*
144			* @param DataObject $object
145			*/
146			public function removeObject(DataObject $object) {
147			$item = ChangeSetItem::get()->filter([
148			'ObjectID' => $object->ID,
149			'ObjectClass' => $object->ClassName,
150			'ChangeSetID' => $this->ID
151			])->first();
152
153			if ($item) {
154			// TODO: Handle case of implicit added item being removed.
155
156			$item->delete();
157			}
158
159			$this->sync();
160			}
161
162			protected function implicitKey($item) {
163			if ($item instanceof ChangeSetItem) return $item->ObjectClass.'.'.$item->ObjectID;
164			return $item->ClassName.'.'.$item->ID;
165			}
166
167			protected function calculateImplicit() {
168			/** @var string[][] $explicit List of all items that have been explicitly added to this ChangeSet */
169			$explicit = array();
170
171			/** @var string[][] $referenced List of all items that are "referenced" by items in $explicit */
172			$referenced = array();
173
174			/** @var string[][] $references List of which explicit items reference each thing in referenced */
175			$references = array();
176
177			foreach ($this->Changes()->filter(['Added' => ChangeSetItem::EXPLICITLY]) as $item) {
178			$explicitKey = $this->implicitKey($item);
179			$explicit[$explicitKey] = true;
180
181			foreach ($item->findReferenced() as $referee) {
182			$key = $this->implicitKey($referee);
183
184			$referenced[$key] = [
185			'ObjectID' => $referee->ID,
186			'ObjectClass' => $referee->ClassName
187			];
188
189			$references[$key][] = $item->ID;
190			}
191			}
192
193			/** @var string[][] $explicit List of all items that are either in $explicit, $referenced or both */
194			$all = array_merge($referenced, $explicit);
195
196			/** @var string[][] $implicit Anything that is in $all, but not in $explicit, is an implicit inclusion */
197			$implicit = array_diff_key($all, $explicit);
198
199			foreach($implicit as $key => $object) {
200			$implicit[$key]['ReferencedBy'] = $references[$key];
201			}
202
203			return $implicit;
204			}
205
206			/**
207			* Add implicit changes that should be included in this changeset
208			*
209			* When an item is created or changed, all it's owned items which have
210			* changes are implicitly added
211			*
212			* When an item is deleted, it's owner (even if that owner does not have changes)
213			* is implicitly added
214			*/
215			public function sync() {
216			// Start a transaction (if we can)
217			DB::get_conn()->withTransaction(function() {
218
219			// Get the implicitly included items for this ChangeSet
220			$implicit = $this->calculateImplicit();
221
222			// Adjust the existing implicit ChangeSetItems for this ChangeSet
223			foreach ($this->Changes()->filter(['Added' => ChangeSetItem::IMPLICITLY]) as $item) {
224			$objectKey = $this->implicitKey($item);
225
226			// If a ChangeSetItem exists, but isn't in $implicit, it's no longer required, so delete it
227			if (!array_key_exists($objectKey, $implicit)) {
228			$item->delete();
229			}
230			// Otherwise it is required, so update ReferencedBy and remove from $implicit
231			else {
232			$item->ReferencedBy()->setByIDList($implicit[$objectKey]['ReferencedBy']);
233			unset($implicit[$objectKey]);
234			}
235			}
236
237			// Now $implicit is all those items that are implicitly included, but don't currently have a ChangeSetItem.
238			// So create new ChangeSetItems to match
239
240			foreach ($implicit as $key => $props) {
241			$item = new ChangeSetItem($props);
242			$item->Added = ChangeSetItem::IMPLICITLY;
243			$item->ChangeSetID = $this->ID;
			0 ignored issues – show Documentation introduced 2016-03-29 22:33 UTC by Report Bug Copy Issue Report The property `ChangeSetID` does not exist on `object<ChangeSetItem>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
244			$item->ReferencedBy()->setByIDList($props['ReferencedBy']);
245			$item->write();
246			}
247			});
248			}
249
250			/** Verify that any objects in this changeset include all owned changes */
251			public function isSynced() {
252			$implicit = $this->calculateImplicit();
253
254			// Check the existing implicit ChangeSetItems for this ChangeSet
255
256			foreach ($this->Changes()->filter(['Added' => ChangeSetItem::IMPLICITLY]) as $item) {
257			$objectKey = $this->implicitKey($item);
258
259			// If a ChangeSetItem exists, but isn't in $implicit -> validation failure
260			if (!array_key_exists($objectKey, $implicit)) return false;
261			// Exists, remove from $implicit
262			unset($implicit[$objectKey]);
263			}
264
265			// If there's anything left in $implicit -> validation failure
266			return empty($implicit);
267			}
268
269			public function canView($member = null) {
270			return $this->can(__FUNCTION__, $member);
271			}
272
273			public function canEdit($member = null) {
274			return $this->can(__FUNCTION__, $member);
275			}
276
277			public function canCreate($member = null, $context = array()) {
278			return $this->can(__FUNCTION__, $member, $context);
279			}
280
281			public function canDelete($member = null) {
282			return $this->can(__FUNCTION__, $member);
283			}
284
285			/**
286			* Check if this item is allowed to be published
287			*
288			* @param Member $member
289			* @return bool
290			*/
291			public function canPublish($member = null) {
292			// All changes must be publishable
293			foreach($this->Changes() as $change) {
294			/** @var ChangeSetItem $change */
295			if(!$change->canPublish($member)) {
296			return false;
297			}
298			}
299
300			// Default permission
301			return $this->can(__FUNCTION__, $member);
302			}
303
304			/**
305			* Check if this changeset (if published) can be reverted
306			*
307			* @param Member $member
308			* @return bool
309			*/
310			public function canRevert($member = null) {
311			// All changes must be publishable
312			foreach($this->Changes() as $change) {
313			/** @var ChangeSetItem $change */
314			if(!$change->canRevert($member)) {
			0 ignored issues – show Bug introduced 2016-03-29 22:33 UTC by Report Bug Copy Issue Report It seems like `$member` defined by parameter `$member` on line `310` can be `null`; however, `ChangeSetItem::canRevert()` does not accept `null`, maybe add an additional type check? It seems like you allow that null is being passed for a parameter, however the function which is called does not seem to accept null. We recommend to add an additional type check (or disallow null for the parameter): function notNullable(stdClass $x) { } // Unsafe function withoutCheck(stdClass $x = null) { notNullable($x); } // Safe - Alternative 1: Adding Additional Type-Check function withCheck(stdClass $x = null) { if ($x instanceof stdClass) { notNullable($x); } } // Safe - Alternative 2: Changing Parameter function withNonNullableParam(stdClass $x) { notNullable($x); } Loading history...
315			return false;
316			}
317			}
318
319			// Default permission
320			return $this->can(__FUNCTION__, $member);
321			}
322
323			/**
324			* Default permissions for this changeset
325			*
326			* @param string $perm
327			* @param Member $member
328			* @param array $context
329			* @return bool
330			*/
331			public function can($perm, $member = null, $context = array()) {
332			if(!$member) {
333			$member = Member::currentUser();
334			}
335
336			// Allow extensions to bypass default permissions, but only if
337			// each change can be individually published.
338			$extended = $this->extendedCan($perm, $member, $context);
339			if($extended !== null) {
340			return $extended;
341			}
342
343			// Default permissions
344			return (bool)Permission::checkMember($member, $this->config()->required_permission);
345			}
346
347			public function getCMSFields() {
348			$fields = new FieldList();
349			$fields->merge([
350			TextField::create('Name'),
351			ReadonlyField::create('State')
352			]);
353			$this->extend('updateCMSFields', $fields);
354			return $fields;
355			}
356
357			/**
358			* Gets summary of items in changeset
359			*
360			* @return string
361			*/
362			public function getDescription() {
363			// Initialise list of items to count
364			$counted = [];
365			$countedOther = 0;
366			foreach($this->config()->important_classes as $type) {
367			if(class_exists($type)) {
368			$counted[$type] = 0;
369			}
370			}
371
372			// Check each change item
373			/** @var ChangeSetItem $change */
374			foreach($this->Changes() as $change) {
375			$found = false;
376			foreach($counted as $class => $num) {
377			if(is_a($change->ObjectClass, $class, true)) {
378			$counted[$class]++;
379			$found = true;
380			break;
381			}
382			}
383			if(!$found) {
384			$countedOther++;
385			}
386			}
387
388			// Describe set based on this output
389			$counted = array_filter($counted);
390
391			// Empty state
392			if(empty($counted) && empty($countedOther)) {
393			return '';
394			}
395
396			// Put all parts together
397			$parts = [];
398			foreach($counted as $class => $count) {
399			$parts[] = DataObject::singleton($class)->i18n_pluralise($count);
400			}
401
402			// Describe non-important items
403			if($countedOther) {
404			if ($counted) {
			0 ignored issues – show Bug Best Practice introduced 2016-04-11 23:05 UTC by Report Bug Copy Issue Report The expression `$counted` of type `array` is implicitly converted to a boolean; are you sure this is intended? If so, consider using `! empty($expr)` instead to make it clear that you intend to check for an array without elements. This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent. Consider making the comparison explicit by using `empty(..)` or `! empty(...)` instead. Loading history...
405			$parts[] = i18n::pluralise(
406			_t('ChangeSet.DESCRIPTION_OTHER_ITEM', 'other item'),
407			_t('ChangeSet.DESCRIPTION_OTHER_ITEMS', 'other items'),
408			$countedOther
409			);
410			} else {
411			$parts[] = i18n::pluralise(
412			_t('ChangeSet.DESCRIPTION_ITEM', 'item'),
413			_t('ChangeSet.DESCRIPTION_ITEMS', 'items'),
414			$countedOther
415			);
416			}
417			}
418
419			// Figure out how to join everything together
420			if(empty($parts)) {
421			return '';
422			}
423			if(count($parts) === 1) {
424			return $parts[0];
425			}
426
427			// Non-comma list
428			if(count($parts) === 2) {
429			return _t(
430			'ChangeSet.DESCRIPTION_AND',
431			'{first} and {second}',
432			[
433			'first' => $parts[0],
434			'second' => $parts[1],
435			]
436			);
437			}
438
439			// First item
440			$string = _t(
441			'ChangeSet.DESCRIPTION_LIST_FIRST',
442			'{item}',
443			['item' => $parts[0]]
444			);
445
446			// Middle items
447			for($i = 1; $i < count($parts) - 1; $i++) {
448			$string = _t(
449			'ChangeSet.DESCRIPTION_LIST_MID',
450			'{list}, {item}',
451			[
452			'list' => $string,
453			'item' => $parts[$i]
454			]
455			);
456			}
457
458			// Oxford comma
459			$string = _t(
460			'ChangeSet.DESCRIPTION_LIST_LAST',
461			'{list}, and {item}',
462			[
463			'list' => $string,
464			'item' => end($parts)
465			]
466			);
467			return $string;
468			}
469			}
470

silverstripe / silverstripe-framework

Push — master ( 954f36...38025f )

ChangeSet::getDescription() F

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like