silverstripe / silverstripe-framework

tests/php/Forms/NumericFieldTest.php

Doc Comments +3 added lines

@@ -29,6 +29,9 @@
         return str_replace(' ', $nbsp, trim($input));
     }
 
+    /**
+     * @param string $locale
+     */
     protected function checkInputValidation($locale, $tests)
     {
         i18n::set_locale($locale);

tests/php/Forms/UploadFieldTest.php

Doc Comments +4 added lines, -1 removed lines

@@ -1023,7 +1023,7 @@ 
      * Simulates a file upload
      *
      * @param  string $fileField   Name of the field to mock upload for
-     * @param  array  $tmpFileName Name of temporary file to upload
+     * @param  string  $tmpFileName Name of temporary file to upload
      * @return HTTPResponse form response
      */
     protected function mockFileUpload($fileField, $tmpFileName)
@@ -1036,6 +1036,9 @@ 
         );
     }
 
+    /**
+     * @param string $fileField
+     */
     protected function mockFileExists($fileField, $fileName)
     {
         return $this->get(

tests/php/ORM/ChangeSetTest/Permissions.php

Doc Comments +3 added lines

@@ -39,6 +39,9 @@
         return $this->can(__FUNCTION__, $member, $context);
     }
 
+    /**
+     * @param string $perm
+     */
     public function can($perm, $member = null, $context = array())
     {
         $perms = [

tests/php/ORM/HierarchyTest.php

Doc Comments +1 added lines, -1 removed lines

@@ -670,7 +670,7 @@
      * Get the HTML class attribute from a node in the sitetree
      *
      * @param  $html
-     * @param  $node
+     * @param  DataObject|null $node
      * @return string
      */
     protected function getNodeClassFromTree($html, $node)

tests/php/Security/GroupTest/MemberForm.php

Doc Comments +4 added lines

@@ -9,6 +9,10 @@
 class MemberForm extends Form
 {
 
+    /**
+     * @param \SilverStripe\Control\Controller $controller
+     * @param string $name
+     */
     public function __construct($controller, $name)
     {
         $fields = TestMember::singleton()->getCMSFields();

tests/php/Security/SecurityTest.php

Doc Comments +4 added lines

@@ -676,6 +676,8 @@ 
     /**
      * Execute a log-in form using Director::test().
      * Helper method for the tests above
+     * @param string $email
+     * @param string $password
      */
     public function doTestLoginForm($email, $password, $backURL = 'test/link')
     {
@@ -697,6 +699,8 @@ 
 
     /**
      * Helper method to execute a change password form
+     * @param string $oldPassword
+     * @param string $newPassword
      */
     public function doTestChangepasswordForm($oldPassword, $newPassword)
     {

tests/php/View/SSViewerCacheBlockTest/VersionedModel.php

Doc Comments +3 added lines

@@ -16,6 +16,9 @@
         Versioned::class
     );
 
+    /**
+     * @param string $entropy
+     */
     public function setEntropy($entropy)
     {
         $this->entropy = $entropy;

tests/php/View/SSViewerTest.php

Doc Comments +13 added lines

@@ -173,6 +173,10 @@ 
         );
     }
 
+    /**
+     * @param \SilverStripe\ORM\FieldType\DBHTMLText $result
+     * @param string[] $expected
+     */
     private function assertExpectedStrings($result, $expected)
     {
         foreach ($expected as $expectedStr) {
@@ -1088,6 +1092,10 @@ 
         $this->assertEquals('A A1 A1 i A1 ii A2 A3', $rationalisedResult);
     }
 
+    /**
+     * @param string $a
+     * @param string $b
+     */
     public function assertEqualIgnoringWhitespace($a, $b, $message = '')
     {
         $this->assertEquals(preg_replace('/\s+/', '', $a), preg_replace('/\s+/', '', $b), $message);
@@ -1819,6 +1827,11 @@ 
             $this->_renderWithSourceFileComments('SSViewerTestComments/'.$template['name'], $template['expected']);
         }
     }
+
+    /**
+     * @param string $name
+     * @param string $expected
+     */
     private function _renderWithSourceFileComments($name, $expected)
     {
         $viewer = new SSViewer(array($name));

admin/code/ModelAdmin.php

Doc Comments +4 added lines, -1 removed lines

@@ -152,6 +152,9 @@ 
         }
     }
 
+    /**
+     * @param string $action
+     */
     public function Link($action = null)
     {
         if (!$action) {
@@ -403,7 +406,7 @@ 
     /**
      * Generate a CSV import form for a single {@link DataObject} subclass.
      *
-     * @return Form|false
+     * @return Form
      */
     public function ImportForm()
     {