PostTest::testMarkAsSpamLink() - Code Metrics - Inspection of "Merge pull request #174 from helpfulrobot/add-stan..." - silverstripe/silverstripe-forum - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 691103...b765dd )

by Daniel

created 2015-11-21 12:16 UTC

PostTest::testMarkAsSpamLink() B

↳ Parent: PostTest

Complexity

Conditions	2
Paths	2

Size

Total Lines	45
Code Lines	20

Duplication

Lines	45
Ratio	100 %

Metric	Value
dl	45
loc	45
rs	8.8571
cc	2
eloc	20
nc	2
nop	0

<?php

class PostTest extends FunctionalTest {
namespace YourVendor;

class YourClass { }
	
	static $fixture_file = "forum/tests/ForumTest.yml";
class A {
    var $property;
}

	// fixes permission issues with these tests, we don't need to test versioning anyway.
	// without this, SiteTree::canView() would always return false even though CanViewType == Anyone.
	static $use_draft_site = true;
class A {
    var $property;
}

	public function setUp(){
		parent::setUp();

		//track the default state of tokens
		$this->useToken = SecurityToken::is_enabled();
class MyClass { }

$x = new MyClass();
$x->foo = true;

	}

	public function tearDown(){
		parent::tearDown();

		//if the token is turned on reset it before the next test run
		if($this->useToken) {
			SecurityToken::enable();
		} else {
			SecurityToken::disable();
		}
	}

	function testPermissions() {

		$member1 = $this->objFromFixture('Member', 'test1');
		$member2 = $this->objFromFixture('Member', 'test2');
		$moderator = $this->objFromFixture('Member', 'moderator');
		$admin = $this->objFromFixture('Member', 'admin');
		
		$postMember2 = $this->objFromFixture('Post', 'Post18');  
		
		// read only thread post
		$member1->logIn();
		$postReadonly = $this->objFromFixture('Post', 'ReadonlyThreadPost');
		$this->assertFalse($postReadonly->canEdit()); // Even though it's user's own

		$this->assertTrue($postReadonly->canView());

		$this->assertFalse($postReadonly->canCreate());

		$this->assertFalse($postReadonly->canDelete());

		
		// normal thread. They can post to these
		$member1->logIn();
		$this->assertFalse($postMember2->canEdit()); // Not user's post

		$this->assertTrue($postMember2->canView());

		$this->assertTrue($postMember2->canCreate());

		$this->assertFalse($postMember2->canDelete());

		
		// Check the user has full rights on his own post
		$member2->logIn();
		$this->assertTrue($postMember2->canEdit()); // User's post

		$this->assertTrue($postMember2->canView());

		$this->assertTrue($postMember2->canCreate());

		$this->assertTrue($postMember2->canDelete());


		// Moderator can delete posts, even if he doesn't own them
		$moderator->logIn();
		$this->assertFalse($postMember2->canEdit());

		$this->assertTrue($postMember2->canView());

		$this->assertTrue($postMember2->canCreate());

		$this->assertTrue($postMember2->canDelete());


		// Admins should have full rights, even if they're not moderators or own the post
		$admin->logIn();
		$this->assertTrue($postMember2->canEdit());

		$this->assertTrue($postMember2->canView());

		$this->assertTrue($postMember2->canCreate());

		$this->assertTrue($postMember2->canDelete());

	}
	
	function testGetTitle() {

		$post = $this->objFromFixture('Post', 'Post1');
		$reply = $this->objFromFixture('Post', 'Post2');
		
		$this->assertEquals($post->Title, "Test Thread");

		$this->assertEquals($reply->Title, "Re: Test Thread");

		
		$first = $this->objFromFixture('Post', 'Post3');
		$this->assertEquals($first->Title, 'Another Test Thread');

	}
	
	function testIssFirstPost() {

		$first = $this->objFromFixture('Post', 'Post1');
		$this->assertTrue($first->isFirstPost());

		
		$notFirst = $this->objFromFixture('Post', 'Post2');
		$this->assertFalse($notFirst->isFirstPost());

	}
	
	function testReplyLink() {

		$post = $this->objFromFixture('Post', 'Post1');
		$this->assertContains($post->Thread()->URLSegment .'/reply/'.$post->ThreadID , $post->ReplyLink());
	}
	
	function testShowLink() {

		$post = $this->objFromFixture('Post', 'Post1');
		Forum::$posts_per_page = 8;

		
		// test for show link on first page
		$this->assertContains($post->Thread()->URLSegment .'/show/'.$post->ThreadID, $post->ShowLink());
		
		// test for link that should be last post on the first page
		$eighthPost = $this->objFromFixture('Post', 'Post9');
		$this->assertContains($eighthPost->Thread()->URLSegment .'/show/'.$eighthPost->ThreadID.'#post'.$eighthPost->ID , $eighthPost->ShowLink());
		
		// test for a show link on a subpage
		$lastPost = $this->objFromFixture('Post', 'Post10');
		$this->assertContains($lastPost->Thread()->URLSegment .'/show/'. $lastPost->ThreadID . '?start=8#post'.$lastPost->ID, $lastPost->ShowLink());
		
		// this is the last post on page 2
		$lastPost = $this->objFromFixture('Post', 'Post17');
		$this->assertContains($lastPost->Thread()->URLSegment .'/show/'. $lastPost->ThreadID . '?start=8#post'.$lastPost->ID, $lastPost->ShowLink());
			
		// test for a show link on the last subpage
		$lastPost = $this->objFromFixture('Post', 'Post18');
		$this->assertContains($lastPost->Thread()->URLSegment .'/show/'. $lastPost->ThreadID . '?start=16#post'.$lastPost->ID, $lastPost->ShowLink());
	}
	
	function testEditLink() {

		$post = $this->objFromFixture('Post', 'Post1');

		// should be false since we're not logged in.
		if($member = Member::currentUser()) $member->logOut();
		
		$this->assertFalse($post->EditLink());		

		
		// logged in as the member. Should be able to edit it
		$member = $this->objFromFixture('Member', 'test1');
		$member->logIn();
		
		$this->assertContains($post->Thread()->URLSegment .'/editpost/'. $post->ID, $post->EditLink());
		
		// log in as another member who is not
		$member->logOut();
		
		$memberOther = $this->objFromFixture('Member', 'test2');
		$memberOther->logIn();
		
		$this->assertFalse($post->EditLink());

	}
	
	function testDeleteLink() {

		$post = $this->objFromFixture('Post', 'Post1');

		//enable token
		SecurityToken::enable();

		// should be false since we're not logged in.
		if($member = Member::currentUser()) $member->logOut();
		
		$this->assertFalse($post->EditLink());

		$this->assertFalse($post->DeleteLink());

		
		// logged in as the moderator. Should be able to delete the post.
		$member = $this->objFromFixture('Member', 'moderator');
		$member->logIn();
		
		$this->assertContains($post->Thread()->URLSegment .'/deletepost/'. $post->ID, $post->DeleteLink());
		
		// because this is the first post test for the class which is used in javascript
		$this->assertContains("class=\"deleteLink firstPost\"", $post->DeleteLink());

		$member->logOut();
		
		// log in as another member who is not in a position to delete this post
		$member = $this->objFromFixture('Member', 'test2');
		$member->logIn();
		
		$this->assertFalse($post->DeleteLink());

		
		// log in as someone who can moderate this post (and therefore delete it)
		$member = $this->objFromFixture('Member', 'moderator');
		$member->logIn();


		//check for the existance of a CSRF token
		$this->assertContains("SecurityID=", $post->DeleteLink());

		// should be able to edit post since they're moderators
		$this->assertContains($post->Thread()->URLSegment .'/deletepost/'. $post->ID, $post->DeleteLink());
		
		// test that a 2nd post doesn't have the first post ID hook
		$memberOthersPost = $this->objFromFixture('Post', 'Post2');
		
		$this->assertFalse(strstr($memberOthersPost->DeleteLink(), "firstPost"));


	}

	function testMarkAsSpamLink() {

		$post = $this->objFromFixture('Post', 'Post1');

		//enable token
		SecurityToken::enable();

		// should be false since we're not logged in.
		if($member = Member::currentUser()) $member->logOut();

		$this->assertFalse($post->EditLink());

		$this->assertFalse($post->MarkAsSpamLink());


		// logged in as the moderator. Should be able to mark the post as spam.
		$member = $this->objFromFixture('Member', 'moderator');
		$member->logIn();

		$this->assertContains($post->Thread()->URLSegment .'/markasspam/'. $post->ID, $post->MarkAsSpamLink());

		// because this is the first post test for the class which is used in javascript
		$this->assertContains("class=\"markAsSpamLink firstPost\"", $post->MarkAsSpamLink());

		$member->logOut();

		// log in as another member who is not in a position to mark post as spam this post
		$member = $this->objFromFixture('Member', 'test2');
		$member->logIn();

		$this->assertFalse($post->MarkAsSpamLink());


		// log in as someone who can moderate this post (and therefore mark as spam)
		$member = $this->objFromFixture('Member', 'moderator');
		$member->logIn();


		//check for the existance of a CSRF token
		$this->assertContains("SecurityID=", $post->MarkAsSpamLink());

		// should be able to edit post since they're moderators
		$this->assertContains($post->Thread()->URLSegment .'/markasspam/'. $post->ID, $post->MarkAsSpamLink());

		// test that a 2nd post doesn't have the first post ID hook
		$memberOthersPost = $this->objFromFixture('Post', 'Post2');

		$this->assertFalse(strstr($memberOthersPost->MarkAsSpamLink(), "firstPost"));

	}

	public function testBanAndGhostLink() {
		$post = $this->objFromFixture('Post', 'Post1');

		// should be false since we're not logged in.
		if($member = Member::currentUser()) $member->logOut();

		$this->assertFalse($post->EditLink());

		$this->assertFalse($post->BanLink());

		$this->assertFalse($post->GhostLink());


		// logged in as the moderator. Should be able to mark the post as spam.
		$member = $this->objFromFixture('Member', 'moderator');
		$member->logIn();

		$forum = $post->Thread()->Forum();
		$this->assertContains($forum->URLSegment . '/ban/' . $post->AuthorID, $post->BanLink());
		$this->assertContains($forum->URLSegment . '/ghost/' . $post->AuthorID, $post->GhostLink());

		$member->logOut();

		// log in as another member who is not in a position to mark post as spam this post
		$member = $this->objFromFixture('Member', 'test2');
		$member->logIn();

		$this->assertFalse($post->BanLink());

		$this->assertFalse($post->GhostLink());

	}
	
	function testGetUpdated() {

		$post = new Post();
		$post->Content = "Original Content";
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
		$post->write();

		$this->assertNull($post->Updated);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
		sleep(2);
		$post->Content = "Some Content Now";
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
		$post->write();
		
		$this->assertNotNull($post->Updated);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
	}
	
	function testRSSContent() {

		// @todo escaping tests. They are handled by bbcode parser tests?
	}
	
	function testRSSAuthor() {

		// @todo 
	}
}


1			<?php
2
3			class PostTest extends FunctionalTest {
			0 ignored issues – show Coding Style Compatibility introduced 2015-11-21 03:27 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history... Coding Style introduced 2015-11-21 03:27 UTC by Report Bug Copy Issue Report As per PSR2, the opening brace for this class should be on a new line. Loading history...
4
5			static $fixture_file = "forum/tests/ForumTest.yml";
			0 ignored issues – show Coding Style introduced 2015-11-21 03:27 UTC by Report Bug Copy Issue Report We recommend specifying an explicit visibility for the field `$fixture_file`. Loading history... Coding Style introduced 2015-11-21 03:27 UTC by Report Bug Copy Issue Report The visibility should be declared for property `$fixture_file`. The PSR-2 coding standard requires that all properties in a class have their visibility explicitly declared. If you declare a property using class A { var $property; } the property is implicitly global. To learn more about the PSR-2, please see the PHP-FIG site on the PSR-2. Loading history...
6
7			// fixes permission issues with these tests, we don't need to test versioning anyway.
8			// without this, SiteTree::canView() would always return false even though CanViewType == Anyone.
9			static $use_draft_site = true;
			0 ignored issues – show Coding Style introduced 2015-11-21 03:27 UTC by Report Bug Copy Issue Report We recommend specifying an explicit visibility for the field `$use_draft_site`. Loading history... Coding Style introduced 2015-11-21 03:27 UTC by Report Bug Copy Issue Report The visibility should be declared for property `$use_draft_site`. The PSR-2 coding standard requires that all properties in a class have their visibility explicitly declared. If you declare a property using class A { var $property; } the property is implicitly global. To learn more about the PSR-2, please see the PHP-FIG site on the PSR-2. Loading history...
10
11			public function setUp(){
12			parent::setUp();
13
14			//track the default state of tokens
15			$this->useToken = SecurityToken::is_enabled();
			0 ignored issues – show Bug introduced 2015-11-21 03:27 UTC by Report Bug Copy Issue Report The property `useToken` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
16
17			}
18
19			public function tearDown(){
20			parent::tearDown();
21
22			//if the token is turned on reset it before the next test run
23			if($this->useToken) {
24			SecurityToken::enable();
25			} else {
26			SecurityToken::disable();
27			}
28			}
29
30			function testPermissions() {
			0 ignored issues – show Best Practice introduced 2015-11-21 03:27 UTC by Report Bug Copy Issue Report It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
31			$member1 = $this->objFromFixture('Member', 'test1');
32			$member2 = $this->objFromFixture('Member', 'test2');
33			$moderator = $this->objFromFixture('Member', 'moderator');
34			$admin = $this->objFromFixture('Member', 'admin');
35

silverstripe / silverstripe-forum

Push — master ( 691103...b765dd )

PostTest::testMarkAsSpamLink() B

Complexity

Size

Duplication

Duplication Side-by-Side

Filter issues like