ForumThreadTest

Complexity

Total Complexity

7

Size/Duplication

Total Lines	100
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	6

7 Methods

Rating	Name	Duplication	Size	Complexity
A	testGetNumPosts()	0	5	1
A	testIncViews()	0	12	1
A	testGetLatestPost()	0	5	1
A	testGetFirstPost()	0	5	1
A	testSubscription()	0	13	1
A	testOnBeforeDelete()	0	15	1
B	testPermissions()	0	30	1

<?php

/**
 * @todo Write some more complex tests for testing the can*() functionality
 */
class ForumThreadTest extends FunctionalTest {

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

As per PSR2, the opening brace for this class should be on a new line.

	
	static $fixture_file = "forum/tests/ForumTest.yml";

We recommend specifying an explicit visibility for the field $fixture_file.

The visibility should be declared for property $fixture_file.

	// fixes permission issues with these tests, we don't need to test versioning anyway.
	// without this, SiteTree::canView() would always return false even though CanViewType == Anyone.
	static $use_draft_site = true;

We recommend specifying an explicit visibility for the field $use_draft_site.

The visibility should be declared for property $use_draft_site.

	function testGetNumPosts() {

It is generally recommended to explicitly declare the visibility for methods.

		$thread = $this->objFromFixture("ForumThread", "Thread1");
		
		$this->assertEquals($thread->getNumPosts(), 17);

The method assertEquals() does not seem to exist on object<ForumThreadTest>.

	}
	
	function testIncViews() {

It is generally recommended to explicitly declare the visibility for methods.

		$thread = $this->objFromFixture("ForumThread", "Thread1");
		
		// clear session
		Session::clear('ForumViewed-'.$thread->ID);
		
		$this->assertEquals($thread->NumViews, '10');

The method assertEquals() does not seem to exist on object<ForumThreadTest>.

		
		$thread->incNumViews();
		
		$this->assertEquals($thread->NumViews, '11');

The method assertEquals() does not seem to exist on object<ForumThreadTest>.

	}
	
	function testGetLatestPost() {

It is generally recommended to explicitly declare the visibility for methods.

		$thread = $this->objFromFixture("ForumThread", "Thread1");
		
		$this->assertEquals($thread->getLatestPost()->Content, "This is the last post to a long thread");

The method assertEquals() does not seem to exist on object<ForumThreadTest>.

	}
	
	function testGetFirstPost() {

It is generally recommended to explicitly declare the visibility for methods.

		$thread = $this->objFromFixture("ForumThread", "Thread1");
		
		$this->assertEquals($thread->getFirstPost()->Content, "This is my first post");

The method assertEquals() does not seem to exist on object<ForumThreadTest>.

	}
	
	function testSubscription() {

It is generally recommended to explicitly declare the visibility for methods.

		$thread = $this->objFromFixture("ForumThread", "Thread1");
		$thread2 = $this->objFromFixture("ForumThread", "Thread2");
		
		$member = $this->objFromFixture("Member", "test1");
		$member2 = $this->objFromFixture("Member", "test2");
		
		$this->assertTrue(ForumThread_Subscription::already_subscribed($thread->ID, $member->ID));

The method assertTrue() does not seem to exist on object<ForumThreadTest>.

		$this->assertTrue(ForumThread_Subscription::already_subscribed($thread->ID, $member2->ID));

The method assertTrue() does not seem to exist on object<ForumThreadTest>.

		
		$this->assertFalse(ForumThread_Subscription::already_subscribed($thread2->ID, $member->ID));

The method assertFalse() does not seem to exist on object<ForumThreadTest>.

		$this->assertFalse(ForumThread_Subscription::already_subscribed($thread2->ID, $member2->ID));

The method assertFalse() does not seem to exist on object<ForumThreadTest>.

	}
	
	function testOnBeforeDelete() {

It is generally recommended to explicitly declare the visibility for methods.

		$thread = new ForumThread();
		$thread->write();
		
		$post = new Post();
		$post->ThreadID = $thread->ID;

The property ThreadID does not exist on object<Post>. Since you implemented __set, maybe consider adding a @property annotation.

		$post->write();
		
		$postID = $post->ID;
		
		$thread->delete();
		
		$this->assertFalse(DataObject::get_by_id('Post', $postID));

The method assertFalse() does not seem to exist on object<ForumThreadTest>.

		$this->assertFalse(DataObject::get_by_id('ForumThread', $thread->ID));

The method assertFalse() does not seem to exist on object<ForumThreadTest>.

	}
	
	function testPermissions() {

It is generally recommended to explicitly declare the visibility for methods.

		$member = $this->objFromFixture('Member', 'test1');
		$this->session()->inst_set('loggedInAs', $member->ID);

		// read only thread. No one should be able to post to this (apart from the )
		$readonly = $this->objFromFixture('ForumThread', 'ReadonlyThread');
		$this->assertFalse($readonly->canPost());

The method assertFalse() does not seem to exist on object<ForumThreadTest>.

		$this->assertTrue($readonly->canView());

The method assertTrue() does not seem to exist on object<ForumThreadTest>.

		$this->assertFalse($readonly->canModerate());

The method assertFalse() does not seem to exist on object<ForumThreadTest>.

		
		// normal thread. They can post to these
		$thread = $this->objFromFixture('ForumThread', 'Thread1');
		$this->assertTrue($thread->canPost());

The method assertTrue() does not seem to exist on object<ForumThreadTest>.

		$this->assertTrue($thread->canView());

The method assertTrue() does not seem to exist on object<ForumThreadTest>.

		$this->assertFalse($thread->canModerate());

The method assertFalse() does not seem to exist on object<ForumThreadTest>.

		
		// normal thread in a read only 
		$disabledforum = $this->objFromFixture('ForumThread', 'ThreadWhichIsInInheritedForum');
		$this->assertFalse($disabledforum->canPost());

The method assertFalse() does not seem to exist on object<ForumThreadTest>.

		$this->assertFalse($disabledforum->canView());

The method assertFalse() does not seem to exist on object<ForumThreadTest>.

		$this->assertFalse($disabledforum->canModerate());

The method assertFalse() does not seem to exist on object<ForumThreadTest>.

		// Moderator can access threads nevertheless
		$member = $this->objFromFixture('Member', 'moderator');
		$member->logIn();

		$this->assertFalse($disabledforum->canPost());

The method assertFalse() does not seem to exist on object<ForumThreadTest>.

		$this->assertTrue($disabledforum->canView());

The method assertTrue() does not seem to exist on object<ForumThreadTest>.

		$this->assertTrue($disabledforum->canModerate());

The method assertTrue() does not seem to exist on object<ForumThreadTest>.

	}
}