ForumMemberProfileTest

Complexity

Total Complexity

3

Size/Duplication

Total Lines	120
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	3

3 Methods

Rating	Name	Duplication	Size	Complexity
B	testRegistrationWithHoneyPot()	0	37	1
B	testMemberProfileSuspensionNote()	0	24	1
A	testMemberProfileDisplays()	0	51	1

<?php

class ForumMemberProfileTest extends FunctionalTest {

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

As per PSR2, the opening brace for this class should be on a new line.

	
	static $fixture_file = "forum/tests/ForumTest.yml";

We recommend specifying an explicit visibility for the field $fixture_file.

The visibility should be declared for property $fixture_file.

	static $use_draft_site = true;

We recommend specifying an explicit visibility for the field $use_draft_site.

The visibility should be declared for property $use_draft_site.

	
	function testRegistrationWithHoneyPot() {

It is generally recommended to explicitly declare the visibility for methods.

		$origHoneypot = ForumHolder::$use_honeypot_on_register;
		$origSpamprotection = ForumHolder::$use_spamprotection_on_register;
		
		ForumHolder::$use_spamprotection_on_register = false;
		
		ForumHolder::$use_honeypot_on_register = false;
		$response = $this->get('ForumMemberProfile/register');
		$this->assertNotContains('RegistrationForm_username', $response->getBody(), 'Honeypot is disabled by default');
		
		ForumHolder::$use_honeypot_on_register = true;
		$response = $this->get('ForumMemberProfile/register');
		$this->assertContains('RegistrationForm_username', $response->getBody(), 'Honeypot can be enabled');
		
		// TODO Will fail if Member is decorated with further *required* fields,
		// through updateForumFields() or updateForumValidator()

42% of this comment could be valid code. Did you maybe forget this after debugging?

		$baseData = array(
			'Password' => array(
				'_Password' => 'text',
				'_ConfirmPassword' => 'text'
			),
			"Nickname" => 'test',
			"Email" => 'test@test.com', 
		);
		
		$invalidData = array_merge($baseData, array('action_doregister' => 1, 'username' => 'spamtastic'));
		$response = $this->post('ForumMemberProfile/RegistrationForm', $invalidData);
		$this->assertEquals(403, $response->getStatusCode());

The method assertEquals() does not seem to exist on object<ForumMemberProfileTest>.

		
		$validData = array_merge($baseData, array('action_doregister' => 1));
		$response = $this->post('ForumMemberProfile/RegistrationForm', $validData);
		// Weak check (registration might still fail), but good enough to know if the honeypot is working
		$this->assertEquals(200, $response->getStatusCode());

The method assertEquals() does not seem to exist on object<ForumMemberProfileTest>.

		
		ForumHolder::$use_honeypot_on_register = $origHoneypot;
		ForumHolder::$use_spamprotection_on_register = $origSpamprotection;
	}

	function testMemberProfileSuspensionNote() {

It is generally recommended to explicitly declare the visibility for methods.

		SS_Datetime::set_mock_now('2011-10-10');

		$normalMember = $this->objFromFixture('Member', 'test1');
		$this->loginAs($normalMember);
		$response = $this->get('ForumMemberProfile/edit/' . $normalMember->ID);

		$this->assertNotContains(
			_t('ForumRole.SUSPENSIONNOTE'),
			$response->getBody(),
			'Normal profiles don\'t show suspension note'
		);

		$suspendedMember = $this->objFromFixture('Member', 'suspended');
		$this->loginAs($suspendedMember);
		$response = $this->get('ForumMemberProfile/edit/' . $suspendedMember->ID);
		$this->assertContains(
			_t('ForumRole.SUSPENSIONNOTE'),
			$response->getBody(),
			'Suspended profiles show suspension note'
		);

		SS_Datetime::clear_mock_now();
	}
	
	function testMemberProfileDisplays() {

It is generally recommended to explicitly declare the visibility for methods.

		/* Get the profile of a secretive member */
		$this->get('ForumMemberProfile/show/' . $this->idFromFixture('Member', 'test1'));
		
		/* Check that it just contains the bare minimum 
		 
		Commented out by wrossiter since this was breaking with custom themes. A test like this should not fail
		because of a custom theme. Will reenable these tests when we tackle the new Member functionality
		
		$this->assertExactMatchBySelector("div#UserProfile label", array(
			"Nickname:",
			"Number of posts:",
			"Forum ranking:",
			"Avatar:",
		));
		$this->assertExactMatchBySelector("div#UserProfile p", array(
			'test1',
			'5',
			'n00b',
			'',
		));

		/* Get the profile of a public member */
		$this->get('ForumMemberProfile/show/' . $this->idFromFixture('Member', 'test2'));

		/* Check that it just contains everything 

59% of this comment could be valid code. Did you maybe forget this after debugging?

		
		$this->assertExactMatchBySelector("div#UserProfile label", array(
			"Nickname:",
			'First Name:',
			'Surname:',
			'Email:',
			'Occupation:',
			'Country:',
			'Number of posts:',
			'Forum ranking:',
			'Avatar:'
		));
		$this->assertExactMatchBySelector("div#UserProfile p", array(
			'test2',
			'Test',
			'Two',
			'',
			'OtherUser',
			'Australia',
			'8',
			'l33t',
			'',
		));
		 */
	}
}