View GitHub Repository silverstripe-forum

Schedule Inspection
Subscribe

Code Duplication    Length = 8-8 lines in 2 locations

code/pagetypes/ForumHolder.php 2 locations

@@ 686-693 (lines=8) @@
683 
                        ->sort('"Member"."Created" ASC')
684 
                        ->limit($SQL_start . ',100');
685 
                break;
686 
            case "name":
687 
//				$members = DataObject::get("Member", "\"GroupID\" = '$forumGroupID'", "\"Member\".\"Nickname\" ASC", "LEFT JOIN \"Group_Members\" ON \"Member\".\"ID\" = \"Group_Members\".\"MemberID\"", "{$SQL_start},100");
688 
                $members = Member::get()
689 
                        ->filter('Member.GroupID', $forumGroupID)
690 
                        ->leftJoin('Group_Members', '"Member"."ID" = "Group_Members"."MemberID"')
691 
                        ->sort('"Member"."Nickname" ASC')
692 
                        ->limit($SQL_start . ',100');
693 
                break;
694 
            case "country":
695 
//				$members = DataObject::get("Member", "\"GroupID\" = '$forumGroupID' AND \"Member\".\"CountryPublic\" = TRUE", "\"Member\".\"Country\" ASC", "LEFT JOIN \"Group_Members\" ON \"Member\".\"ID\" = \"Group_Members\".\"MemberID\"", "{$SQL_start},100");
696 
                $members = Member::get()
@@ 694-701 (lines=8) @@
691 
                        ->sort('"Member"."Nickname" ASC')
692 
                        ->limit($SQL_start . ',100');
693 
                break;
694 
            case "country":
695 
//				$members = DataObject::get("Member", "\"GroupID\" = '$forumGroupID' AND \"Member\".\"CountryPublic\" = TRUE", "\"Member\".\"Country\" ASC", "LEFT JOIN \"Group_Members\" ON \"Member\".\"ID\" = \"Group_Members\".\"MemberID\"", "{$SQL_start},100");
696 
                $members = Member::get()
697 
                        ->filter(array('Member.GroupID' => $forumGroupID, 'Member.CountryPublic' => true))
698 
                        ->leftJoin('Group_Members', '"Member"."ID" = "Group_Members"."MemberID"')
699 
                        ->sort('"Member"."Nickname" ASC')
700 
                        ->limit($SQL_start . ',100');
701 
                break;
702 
            case "posts":
703 
                $query = singleton('Member')->extendedSQL('', "\"NumPosts\" DESC", "{$SQL_start},100");
704 
                $query->select[] = "(SELECT COUNT(*) FROM \"Post\" WHERE \"Post\".\"AuthorID\" = \"Member\".\"ID\") AS \"NumPosts\"";