View GitHub Repository silverstripe-forum

Schedule Inspection
Subscribe

Code Duplication    Length = 8-8 lines in 2 locations

code/pagetypes/ForumHolder.php 2 locations

@@ 677-684 (lines=8) @@
674 
                        ->sort('"Member"."Created" ASC')
675 
                        ->limit($SQL_start . ',100');
676 
            break;
677 
            case "name":
678 
//				$members = DataObject::get("Member", "\"GroupID\" = '$forumGroupID'", "\"Member\".\"Nickname\" ASC", "LEFT JOIN \"Group_Members\" ON \"Member\".\"ID\" = \"Group_Members\".\"MemberID\"", "{$SQL_start},100");
679 
                $members = Member::get()
680 
                        ->filter('Member.GroupID', $forumGroupID)
681 
                        ->leftJoin('Group_Members', '"Member"."ID" = "Group_Members"."MemberID"')
682 
                        ->sort('"Member"."Nickname" ASC')
683 
                        ->limit($SQL_start . ',100');
684 
            break;
685 
            case "country":
686 
//				$members = DataObject::get("Member", "\"GroupID\" = '$forumGroupID' AND \"Member\".\"CountryPublic\" = TRUE", "\"Member\".\"Country\" ASC", "LEFT JOIN \"Group_Members\" ON \"Member\".\"ID\" = \"Group_Members\".\"MemberID\"", "{$SQL_start},100");
687 
                $members = Member::get()
@@ 685-692 (lines=8) @@
682 
                        ->sort('"Member"."Nickname" ASC')
683 
                        ->limit($SQL_start . ',100');
684 
            break;
685 
            case "country":
686 
//				$members = DataObject::get("Member", "\"GroupID\" = '$forumGroupID' AND \"Member\".\"CountryPublic\" = TRUE", "\"Member\".\"Country\" ASC", "LEFT JOIN \"Group_Members\" ON \"Member\".\"ID\" = \"Group_Members\".\"MemberID\"", "{$SQL_start},100");
687 
                $members = Member::get()
688 
                        ->filter(array('Member.GroupID' => $forumGroupID, 'Member.CountryPublic' => true))
689 
                        ->leftJoin('Group_Members', '"Member"."ID" = "Group_Members"."MemberID"')
690 
                        ->sort('"Member"."Nickname" ASC')
691 
                        ->limit($SQL_start . ',100');
692 
            break;
693 
            case "posts":
694 
                $query = singleton('Member')->extendedSQL('', "\"NumPosts\" DESC", "{$SQL_start},100");
695 
                $query->select[] = "(SELECT COUNT(*) FROM \"Post\" WHERE \"Post\".\"AuthorID\" = \"Member\".\"ID\") AS \"NumPosts\"";