ExternalLinksTest

Complexity

Total Complexity

9

Size/Duplication

Total Lines	149
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	10

5 Methods

Rating	Name	Duplication	Size	Complexity
A	tearDown()	0	4	1
A	setUpOnce()	0	7	2
A	setUp()	0	55	2
A	testLinks()	0	58	2
A	testReportExists()	0	9	2

<?php

class ExternalLinksTest extends SapphireTest {

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

	protected static $fixture_file = 'ExternalLinksTest.yml';

	protected $extraDataObjects = array(
		'ExternalLinksTest_Page'
	);

	public function setUpOnce() {
		if (class_exists('Phockito')) {
			Phockito::include_hamcrest(false);
		}

		parent::setUpOnce();
	}

	public function setUp() {

The return type could not be reliably inferred; please add a @return annotation.

		parent::setUp();

		Injector::nest();

		// Check dependencies
		if (!class_exists('Phockito')) {
			$this->skipTest = true;
			return $this->markTestSkipped("These tests need the Phockito module installed to run");

The method markTestSkipped() does not seem to exist on object<ExternalLinksTest>.

		}

		// Mock link checker
		$checker = Phockito::mock('LinkChecker');
		Phockito::when($checker)
			->checkLink('http://www.working.com')
			->return(200);

		Phockito::when($checker)
			->checkLink('http://www.broken.com/url/thing') // 404 on working site
			->return(404);

		Phockito::when($checker)
			->checkLink('http://www.broken.com') // 403 on working site
			->return(403);

		Phockito::when($checker)
			->checkLink('http://www.nodomain.com') // no ping
			->return(0);

		Phockito::when($checker)
			->checkLink('/internal/link')
			->return(null);

		Phockito::when($checker)
			->checkLink('[sitetree_link,id=9999]')
			->return(null);

		Phockito::when($checker)
			->checkLink('home')
			->return(null);

		Phockito::when($checker)
			->checkLink('broken-internal')
			->return(null);

		Phockito::when($checker)
			->checkLink('[sitetree_link,id=1]')
			->return(null);

		Phockito::when($checker)
			->checkLink(Hamcrest_Matchers::anything()) // anything else is 404
			->return(404);

		Injector::inst()->registerService($checker, 'LinkChecker');
	}

	public function tearDown() {
		Injector::unnest();
		parent::tearDown();
	}

	public function testLinks() {
		// Run link checker
		$task = CheckExternalLinksTask::create();
		$task->setSilent(true); // Be quiet during the test!
		$task->runLinksCheck();

		// Get all links checked
		$status = BrokenExternalPageTrackStatus::get_latest();
		$this->assertEquals('Completed', $status->Status);

The property Status does not exist on object<BrokenExternalPageTrackStatus>. Since you implemented __get, maybe consider adding a @property annotation.

The method assertEquals() does not seem to exist on object<ExternalLinksTest>.

		$this->assertEquals(5, $status->TotalPages);

The method assertEquals() does not seem to exist on object<ExternalLinksTest>.

		$this->assertEquals(5, $status->CompletedPages);

The method assertEquals() does not seem to exist on object<ExternalLinksTest>.

		// Check all pages have had the correct HTML adjusted
		for($i = 1; $i <= 5; $i++) {
			$page = $this->objFromFixture('ExternalLinksTest_Page', 'page'.$i);
			$this->assertNotEmpty($page->Content);

The method assertNotEmpty() does not seem to exist on object<ExternalLinksTest>.

			$this->assertEquals(

The method assertEquals() does not seem to exist on object<ExternalLinksTest>.

				$page->ExpectedContent,
				$page->Content,
				"Assert that the content of page{$i} has been updated"
			);
		}

		// Check that the correct report of broken links is generated
		$links = $status
			->BrokenLinks()
			->sort('Link');

		$this->assertEquals(4, $links->count());

The method assertEquals() does not seem to exist on object<ExternalLinksTest>.

		$this->assertEquals(

The method assertEquals() does not seem to exist on object<ExternalLinksTest>.

			array(
				'http://www.broken.com',
				'http://www.broken.com/url/thing',
				'http://www.broken.com/url/thing',
				'http://www.nodomain.com'
			),
			array_values($links->map('ID', 'Link')->toArray())
		);

		// Check response codes are correct
		$expected = array(
			'http://www.broken.com' => 403,
			'http://www.broken.com/url/thing' => 404,
			'http://www.nodomain.com' => 0
		);
		$actual = $links->map('Link', 'HTTPCode')->toArray();
		$this->assertEquals($expected, $actual);

The method assertEquals() does not seem to exist on object<ExternalLinksTest>.

		// Check response descriptions are correct
		i18n::set_locale('en_NZ');
		$expected = array(
			'http://www.broken.com' => '403 (Forbidden)',
			'http://www.broken.com/url/thing' => '404 (Not Found)',
			'http://www.nodomain.com' => '0 (Server Not Available)'
		);
		$actual = $links->map('Link', 'HTTPCodeDescription')->toArray();
		$this->assertEquals($expected, $actual);

The method assertEquals() does not seem to exist on object<ExternalLinksTest>.

	}

	/**
	 * Test that broken links appears in the reports list
	 */
	public function testReportExists() {
		$reports = SS_Report::get_reports();
		$reportNames = array();
		foreach($reports as $report) {
			$reportNames[] = $report->class;
		}
		$this->assertContains('BrokenExternalLinksReport',$reportNames,
			'BrokenExternalLinksReport is in reports list');
	}
}

class ExternalLinksTest_Page extends Page implements TestOnly {

PSR1 recommends that each class should be in its own file to aid autoloaders.

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

	private static $db = array(

The property $db is not used and could be removed.

		'ExpectedContent' => 'HTMLText'
	);
}