SilverStripe\EnvironmentCheck\Traits\Fetcher

Complexity

Total Complexity

2

Size/Duplication

Total Lines	34
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	getClientConfig()	0	4	1
A	fetchResponse()	0	6	1

<?php

namespace SilverStripe\EnvironmentCheck\Traits;

use GuzzleHttp\Client;
use Psr\Http\Message\ResponseInterface;

/**
 * Simple helper for fetching responses using Guzzle client.
 *
 * @package environmentcheck
 */
trait Fetcher
{
    /**
     * Configuration for the Guzzle client
     *
     * @var array
     */
    protected $clientConfig = [];

    /**
     * Merges configuration arrays and returns the result
     *
     * @param array $extraConfig
     * @return array
     */
    private function getClientConfig(array $extraConfig = []) : array
    {
        return array_merge($this->clientConfig, $extraConfig);
    }

    /**
     * Fetch a response for a URL using Guzzle client.
     *
     * @param string $url
     * @param array|null $extraConfig Extra configuration
     * @return ResponseInterface
     */
    public function fetchResponse(string $url, ? array $extraConfig = []) : ? ResponseInterface
    {
        $config = $this->getClientConfig($extraConfig);

It seems like $extraConfig defined by parameter $extraConfig on line 40 can also be of type null; however, SilverStripe\EnvironmentCheck\Traits\Fetcher::getClientConfig() does only seem to accept array, maybe add an additional type check?

        $client = new Client($config);
        return $client->get($url);
    }
}