SilverStripe\EnvironmentCheck\Tests\EnvironmentCheckerTest

Complexity

Total Complexity

7

Size/Duplication

Total Lines	94
Duplicated Lines	36.17 %

Coupling/Cohesion

Components	0
Dependencies	10

Importance

Changes

0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	setUpBeforeClass()	0	12	2
A	setUp()	0	5	1
A	tearDown()	0	5	1
A	testOnlyLogsWithErrors()	0	15	1
A	testLogsWithWarnings()	17	17	1
A	testLogsWithErrors()	17	17	1

<?php

namespace SilverStripe\EnvironmentCheck\Tests;

use Phockito;
use Psr\Log\LoggerInterface;
use SilverStripe\Core\Config\Config;
use SilverStripe\Core\Injector\Injector;
use SilverStripe\Dev\SapphireTest;
use SilverStripe\Dev\TestOnly;
use SilverStripe\EnvironmentCheck\EnvironmentCheck;
use SilverStripe\EnvironmentCheck\EnvironmentChecker;
use SilverStripe\EnvironmentCheck\EnvironmentCheckSuite;

/**
 * Class EnvironmentCheckerTest
 *
 * @package environmentcheck
 */
class EnvironmentCheckerTest extends SapphireTest
{
    /**
     * {@inheritDoc}
     * @var bool
     */
    protected $usesDatabase = true;

    /**
     * {@inheritDoc}
     */
    public static function setUpBeforeClass()
    {
        parent::setUpBeforeClass();

        Phockito::include_hamcrest();

        $logger = Injector::inst()->get(LoggerInterface::class);
        if ($logger instanceof \Monolog\Logger) {
            // It logs to stderr by default - disable
            $logger->pushHandler(new \Monolog\Handler\NullHandler);
        }
    }

    /**
     * {@inheritDoc}
     */
    public function setUp()
    {
        parent::setUp();
        Config::nest();
    }

    /**
     * {@inheritDoc}
     */
    public function tearDown()
    {
        Config::unnest();
        parent::tearDown();
    }

    public function testOnlyLogsWithErrors()
    {
        Config::modify()->set(EnvironmentChecker::class, 'log_results_warning', true);

The method modify() does not seem to exist on object<SilverStripe\Core\Config\Config>.

        Config::modify()->set(EnvironmentChecker::class, 'log_results_error', true);

The method modify() does not seem to exist on object<SilverStripe\Core\Config\Config>.

        EnvironmentCheckSuite::register('test suite', new EnvironmentCheckerTest_CheckNoErrors());
        $checker = Phockito::spy(
            EnvironmentChecker::class,
            'test suite',
            'test'
        );

        $response = $checker->index();

$response is not used, you could remove the assignment.

        Phockito::verify($checker, 0)->log(\anything(), \anything());
        EnvironmentCheckSuite::reset();
    }

    public function testLogsWithWarnings()

This method seems to be duplicated in your project.

    {
        Config::modify()->set(EnvironmentChecker::class, 'log_results_warning', true);

The method modify() does not seem to exist on object<SilverStripe\Core\Config\Config>.

        Config::modify()->set(EnvironmentChecker::class, 'log_results_error', false);

The method modify() does not seem to exist on object<SilverStripe\Core\Config\Config>.

        EnvironmentCheckSuite::register('test suite', new EnvironmentCheckerTest_CheckWarnings());
        EnvironmentCheckSuite::register('test suite', new EnvironmentCheckerTest_CheckErrors());
        $checker = Phockito::spy(
            EnvironmentChecker::class,
            'test suite',
            'test'
        );

        $response = $checker->index();

$response is not used, you could remove the assignment.

        Phockito::verify($checker, 1)->log(containsString('warning'), \anything());
        Phockito::verify($checker, 0)->log(containsString('error'), \anything());
        EnvironmentCheckSuite::reset();
    }

    public function testLogsWithErrors()

This method seems to be duplicated in your project.

    {
        Config::modify()->set(EnvironmentChecker::class, 'log_results_error', false);

The method modify() does not seem to exist on object<SilverStripe\Core\Config\Config>.

        Config::modify()->set(EnvironmentChecker::class, 'log_results_error', true);

The method modify() does not seem to exist on object<SilverStripe\Core\Config\Config>.

        EnvironmentCheckSuite::register('test suite', new EnvironmentCheckerTest_CheckWarnings());
        EnvironmentCheckSuite::register('test suite', new EnvironmentCheckerTest_CheckErrors());
        $checker = Phockito::spy(
            EnvironmentChecker::class,
            'test suite',
            'test'
        );

        $response = $checker->index();

$response is not used, you could remove the assignment.

        Phockito::verify($checker, 0)->log(containsString('warning'), \anything());
        Phockito::verify($checker, 1)->log(containsString('error'), \anything());
        EnvironmentCheckSuite::reset();
    }
}

class EnvironmentCheckerTest_CheckNoErrors implements EnvironmentCheck, TestOnly

PSR1 recommends that each class should be in its own file to aid autoloaders.

{
    public function check()
    {
        return [EnvironmentCheck::OK, ''];
    }
}

class EnvironmentCheckerTest_CheckWarnings implements EnvironmentCheck, TestOnly

PSR1 recommends that each class should be in its own file to aid autoloaders.

{
    public function check()
    {
        return [EnvironmentCheck::WARNING, 'test warning'];
    }
}

class EnvironmentCheckerTest_CheckErrors implements EnvironmentCheck, TestOnly

PSR1 recommends that each class should be in its own file to aid autoloaders.

{
    public function check()
    {
        return [EnvironmentCheck::ERROR, 'test error'];
    }
}