silverstripe / silverstripe-environmentcheck

code/checks/SMTPConnectCheck.php

Spacing +4 added lines, -4 removed lines

@@ -30,10 +30,10 @@ 
 	 */
 	function __construct($host = null, $port = null, $timeout = 15) {
 		$this->host = ($host) ? $host : ini_get('SMTP');
-		if(!$this->host) $this->host = 'localhost';
+		if (!$this->host) $this->host = 'localhost';
 		
 		$this->port = ($port) ? $port : ini_get('smtp_port');
-		if(!$this->port) $this->port = 25;
+		if (!$this->port) $this->port = 25;
 
 		$this->timeout = $timeout;
 	}
@@ -45,7 +45,7 @@ 
 	 */
 	function check() {
 		$f = @fsockopen($this->host, $this->port, $errno, $errstr, $this->timeout);
-		if(!$f) {
+		if (!$f) {
 			return array(
 				EnvironmentCheck::ERROR, 
 				sprintf("Couldn't connect to SMTP on %s:%s (Error: %s %s)", $this->host, $this->port, $errno, $errstr)
@@ -54,7 +54,7 @@ 
 
 		fwrite($f, "HELO its_me\r\n");
 		$response = fread($f, 26);
-		if(substr($response, 0, 3) != '220') {
+		if (substr($response, 0, 3) != '220') {
 			return array(
 				EnvironmentCheck::ERROR,
 				sprintf("Invalid mail server response: %s", $response)

Braces +6 added lines, -2 removed lines

@@ -30,10 +30,14 @@
 	 */
 	function __construct($host = null, $port = null, $timeout = 15) {
 		$this->host = ($host) ? $host : ini_get('SMTP');
-		if(!$this->host) $this->host = 'localhost';
+		if(!$this->host) {
+			$this->host = 'localhost';
+		}
 		
 		$this->port = ($port) ? $port : ini_get('smtp_port');
-		if(!$this->port) $this->port = 25;
+		if(!$this->port) {
+			$this->port = 25;
+		}
 
 		$this->timeout = $timeout;
 	}

Doc Comments +1 added lines, -1 removed lines

@@ -28,7 +28,7 @@
 	/**
 	 * @inheritdoc
 	 *
-	 * @return array
+	 * @return string[]
 	 *
 	 * @throws SS_HTTPResponse_Exception
 	 */

code/checks/SolrIndexCheck.php

Doc Comments +1 added lines, -1 removed lines

@@ -28,7 +28,7 @@
 	/**
 	 * @inheritdoc
 	 *
-	 * @return array
+	 * @return string[]
 	 *
 	 * @throws SS_HTTPResponse_Exception
 	 */