Completed
Pull Request — master (#60)
by
unknown
03:16
created
src/Checks/EnvTypeCheck.php 1 patch
Indentation   +24 added lines, -24 removed lines patch added patch discarded remove patch
@@ -13,28 +13,28 @@
 block discarded – undo
13 13
  */
14 14
 class EnvTypeCheck implements EnvironmentCheck
15 15
 {
16
-    /**
17
-     * Check the environment setting.
18
-     *
19
-     * @return array
20
-     */
21
-    public function check()
22
-    {
23
-        $envSetting = Director::get_environment_type();
24
-        switch ($envSetting) {
25
-            case 'live':
26
-                return [
27
-                    EnvironmentCheck::OK,
28
-                    "Env setting is 'live'",
29
-                ];
30
-            // Fallthrough
31
-            default:
32
-            case 'dev':
33
-            case 'test':
34
-                return [
35
-                    EnvironmentCheck::ERROR,
36
-                    "Env setting is '{$envSetting}' and may disclose information",
37
-                ];
38
-        }
39
-    }
16
+	/**
17
+	 * Check the environment setting.
18
+	 *
19
+	 * @return array
20
+	 */
21
+	public function check()
22
+	{
23
+		$envSetting = Director::get_environment_type();
24
+		switch ($envSetting) {
25
+			case 'live':
26
+				return [
27
+					EnvironmentCheck::OK,
28
+					"Env setting is 'live'",
29
+				];
30
+			// Fallthrough
31
+			default:
32
+			case 'dev':
33
+			case 'test':
34
+				return [
35
+					EnvironmentCheck::ERROR,
36
+					"Env setting is '{$envSetting}' and may disclose information",
37
+				];
38
+		}
39
+	}
40 40
 }
Please login to merge, or discard this patch.
tests/Checks/EnvTypeCheckTest.php 1 patch
Indentation   +45 added lines, -45 removed lines patch added patch discarded remove patch
@@ -14,60 +14,60 @@
 block discarded – undo
14 14
  */
15 15
 class EnvTypeCheckTest extends SapphireTest
16 16
 {
17
-    /**
18
-     * Check is OK when in live mode
19
-     *
20
-     * @return void
21
-     */
22
-    public function testEnvSettingLive()
23
-    {
24
-        /** @var Kernel $kernel */
25
-        $kernel = Injector::inst()->get(Kernel::class);
26
-        $kernel->setEnvironment('live');
17
+	/**
18
+	 * Check is OK when in live mode
19
+	 *
20
+	 * @return void
21
+	 */
22
+	public function testEnvSettingLive()
23
+	{
24
+		/** @var Kernel $kernel */
25
+		$kernel = Injector::inst()->get(Kernel::class);
26
+		$kernel->setEnvironment('live');
27 27
 
28
-        $this->assertTrue(Director::isLive());
28
+		$this->assertTrue(Director::isLive());
29 29
 
30
-        $checker = Injector::inst()->get(EnvTypeCheck::class);
31
-        $result = $checker->check();
30
+		$checker = Injector::inst()->get(EnvTypeCheck::class);
31
+		$result = $checker->check();
32 32
 
33
-        $this->assertSame($result[0], EnvironmentCheck::OK);
34
-    }
33
+		$this->assertSame($result[0], EnvironmentCheck::OK);
34
+	}
35 35
 
36
-    /**
37
-     * Check is ERROR when in test mode
38
-     *
39
-     * @return void
40
-     */
41
-    public function testEnvSettingTest()
42
-    {
43
-        /** @var Kernel $kernel */
44
-        $kernel = Injector::inst()->get(Kernel::class);
45
-        $kernel->setEnvironment('test');
36
+	/**
37
+	 * Check is ERROR when in test mode
38
+	 *
39
+	 * @return void
40
+	 */
41
+	public function testEnvSettingTest()
42
+	{
43
+		/** @var Kernel $kernel */
44
+		$kernel = Injector::inst()->get(Kernel::class);
45
+		$kernel->setEnvironment('test');
46 46
 
47
-        $this->assertTrue(Director::isTest());
47
+		$this->assertTrue(Director::isTest());
48 48
 
49
-        $checker = Injector::inst()->get(EnvTypeCheck::class);
50
-        $result = $checker->check();
49
+		$checker = Injector::inst()->get(EnvTypeCheck::class);
50
+		$result = $checker->check();
51 51
 
52
-        $this->assertSame($result[0], EnvironmentCheck::ERROR);
53
-    }
52
+		$this->assertSame($result[0], EnvironmentCheck::ERROR);
53
+	}
54 54
 
55
-    /**
56
-     * Check is ERROR when in dev mode
57
-     *
58
-     * @return void
59
-     */
60
-    public function testEnvSettingDev()
61
-    {
62
-        /** @var Kernel $kernel */
63
-        $kernel = Injector::inst()->get(Kernel::class);
64
-        $kernel->setEnvironment('dev');
55
+	/**
56
+	 * Check is ERROR when in dev mode
57
+	 *
58
+	 * @return void
59
+	 */
60
+	public function testEnvSettingDev()
61
+	{
62
+		/** @var Kernel $kernel */
63
+		$kernel = Injector::inst()->get(Kernel::class);
64
+		$kernel->setEnvironment('dev');
65 65
 
66
-        $this->assertTrue(Director::isDev());
66
+		$this->assertTrue(Director::isDev());
67 67
 
68
-        $checker = Injector::inst()->get(EnvTypeCheck::class);
69
-        $result = $checker->check();
68
+		$checker = Injector::inst()->get(EnvTypeCheck::class);
69
+		$result = $checker->check();
70 70
 
71
-        $this->assertSame($result[0], EnvironmentCheck::ERROR);
72
-    }
71
+		$this->assertSame($result[0], EnvironmentCheck::ERROR);
72
+	}
73 73
 }
Please login to merge, or discard this patch.
tests/Checks/CacheHeadersCheckTest.php 1 patch
Indentation   +72 added lines, -72 removed lines patch added patch discarded remove patch
@@ -15,87 +15,87 @@
 block discarded – undo
15 15
  */
16 16
 class CacheHeadersCheckTest extends SapphireTest
17 17
 {
18
-    /**
19
-     * Test that directives that must be included, are.
20
-     *
21
-     * @return void
22
-     */
23
-    public function testMustInclude()
24
-    {
25
-        // Create a mock and queue responses
26
-        $mock = new MockHandler([
27
-            new Response(200, ['Cache-Control' => 'must-revalidate', 'ETag' => '123']),
28
-            new Response(200, ['Cache-Control' =>'no-cache', 'ETag' => '123']),
29
-            new Response(200, ['ETag' => '123']),
30
-            new Response(200, ['Cache-Control' => 'must-revalidate, private', 'ETag' => '123']),
31
-        ]);
18
+	/**
19
+	 * Test that directives that must be included, are.
20
+	 *
21
+	 * @return void
22
+	 */
23
+	public function testMustInclude()
24
+	{
25
+		// Create a mock and queue responses
26
+		$mock = new MockHandler([
27
+			new Response(200, ['Cache-Control' => 'must-revalidate', 'ETag' => '123']),
28
+			new Response(200, ['Cache-Control' =>'no-cache', 'ETag' => '123']),
29
+			new Response(200, ['ETag' => '123']),
30
+			new Response(200, ['Cache-Control' => 'must-revalidate, private', 'ETag' => '123']),
31
+		]);
32 32
 
33
-        $handler = HandlerStack::create($mock);
34
-        $client = new Client(['handler' => $handler]);
33
+		$handler = HandlerStack::create($mock);
34
+		$client = new Client(['handler' => $handler]);
35 35
 
36
-        $cacheHeadersCheck = new CacheHeadersCheck('/', ['must-revalidate']);
37
-        $cacheHeadersCheck->client = $client;
36
+		$cacheHeadersCheck = new CacheHeadersCheck('/', ['must-revalidate']);
37
+		$cacheHeadersCheck->client = $client;
38 38
 
39
-        // Run checks for each response above
40
-        $this->assertContains(EnvironmentCheck::OK, $cacheHeadersCheck->check());
41
-        $this->assertContains(EnvironmentCheck::ERROR, $cacheHeadersCheck->check());
42
-        $this->assertContains(EnvironmentCheck::ERROR, $cacheHeadersCheck->check());
43
-        $this->assertContains(EnvironmentCheck::OK, $cacheHeadersCheck->check());
44
-    }
39
+		// Run checks for each response above
40
+		$this->assertContains(EnvironmentCheck::OK, $cacheHeadersCheck->check());
41
+		$this->assertContains(EnvironmentCheck::ERROR, $cacheHeadersCheck->check());
42
+		$this->assertContains(EnvironmentCheck::ERROR, $cacheHeadersCheck->check());
43
+		$this->assertContains(EnvironmentCheck::OK, $cacheHeadersCheck->check());
44
+	}
45 45
 
46
-    /**
47
-     * Test that directives that must be excluded, are.
48
-     *
49
-     * @return void
50
-     */
51
-    public function testMustExclude()
52
-    {
53
-        // Create a mock and queue responses
54
-        $mock = new MockHandler([
55
-            new Response(200, ['Cache-Control' => 'must-revalidate', 'ETag' => '123']),
56
-            new Response(200, ['Cache-Control' =>'no-cache', 'ETag' => '123']),
57
-            new Response(200, ['ETag' => '123']),
58
-            new Response(200, ['Cache-Control' =>'private, no-store', ' ETag' => '123']),
59
-        ]);
46
+	/**
47
+	 * Test that directives that must be excluded, are.
48
+	 *
49
+	 * @return void
50
+	 */
51
+	public function testMustExclude()
52
+	{
53
+		// Create a mock and queue responses
54
+		$mock = new MockHandler([
55
+			new Response(200, ['Cache-Control' => 'must-revalidate', 'ETag' => '123']),
56
+			new Response(200, ['Cache-Control' =>'no-cache', 'ETag' => '123']),
57
+			new Response(200, ['ETag' => '123']),
58
+			new Response(200, ['Cache-Control' =>'private, no-store', ' ETag' => '123']),
59
+		]);
60 60
 
61
-        $handler = HandlerStack::create($mock);
62
-        $client = new Client(['handler' => $handler]);
61
+		$handler = HandlerStack::create($mock);
62
+		$client = new Client(['handler' => $handler]);
63 63
 
64
-        $cacheHeadersCheck = new CacheHeadersCheck('/', [], ["no-store", "no-cache", "private"]);
65
-        $cacheHeadersCheck->client = $client;
64
+		$cacheHeadersCheck = new CacheHeadersCheck('/', [], ["no-store", "no-cache", "private"]);
65
+		$cacheHeadersCheck->client = $client;
66 66
 
67
-        // Run checks for each response above
68
-        $this->assertContains(EnvironmentCheck::OK, $cacheHeadersCheck->check());
69
-        $this->assertContains(EnvironmentCheck::ERROR, $cacheHeadersCheck->check());
70
-        $this->assertContains(EnvironmentCheck::OK, $cacheHeadersCheck->check());
71
-        $this->assertContains(EnvironmentCheck::ERROR, $cacheHeadersCheck->check());
72
-    }
67
+		// Run checks for each response above
68
+		$this->assertContains(EnvironmentCheck::OK, $cacheHeadersCheck->check());
69
+		$this->assertContains(EnvironmentCheck::ERROR, $cacheHeadersCheck->check());
70
+		$this->assertContains(EnvironmentCheck::OK, $cacheHeadersCheck->check());
71
+		$this->assertContains(EnvironmentCheck::ERROR, $cacheHeadersCheck->check());
72
+	}
73 73
 
74
-    /**
75
-     * Test that Etag header must exist in response.
76
-     *
77
-     * @return void
78
-     */
79
-    public function testEtag()
80
-    {
81
-        // Create a mock and queue responses
82
-        $mock = new MockHandler([
83
-            new Response(200, ['Cache-Control' => 'must-revalidate', 'ETag' => '123']),
84
-            new Response(200, ['Cache-Control' =>'no-cache']),
85
-            new Response(200, ['ETag' => '123']),
86
-            new Response(200, []),
87
-        ]);
74
+	/**
75
+	 * Test that Etag header must exist in response.
76
+	 *
77
+	 * @return void
78
+	 */
79
+	public function testEtag()
80
+	{
81
+		// Create a mock and queue responses
82
+		$mock = new MockHandler([
83
+			new Response(200, ['Cache-Control' => 'must-revalidate', 'ETag' => '123']),
84
+			new Response(200, ['Cache-Control' =>'no-cache']),
85
+			new Response(200, ['ETag' => '123']),
86
+			new Response(200, []),
87
+		]);
88 88
 
89
-        $handler = HandlerStack::create($mock);
90
-        $client = new Client(['handler' => $handler]);
89
+		$handler = HandlerStack::create($mock);
90
+		$client = new Client(['handler' => $handler]);
91 91
 
92
-        $cacheHeadersCheck = new CacheHeadersCheck('/');
93
-        $cacheHeadersCheck->client = $client;
92
+		$cacheHeadersCheck = new CacheHeadersCheck('/');
93
+		$cacheHeadersCheck->client = $client;
94 94
 
95
-        // Run checks for each response above
96
-        $this->assertContains(EnvironmentCheck::OK, $cacheHeadersCheck->check());
97
-        $this->assertContains(EnvironmentCheck::ERROR, $cacheHeadersCheck->check());
98
-        $this->assertContains(EnvironmentCheck::OK, $cacheHeadersCheck->check());
99
-        $this->assertContains(EnvironmentCheck::ERROR, $cacheHeadersCheck->check());
100
-    }
95
+		// Run checks for each response above
96
+		$this->assertContains(EnvironmentCheck::OK, $cacheHeadersCheck->check());
97
+		$this->assertContains(EnvironmentCheck::ERROR, $cacheHeadersCheck->check());
98
+		$this->assertContains(EnvironmentCheck::OK, $cacheHeadersCheck->check());
99
+		$this->assertContains(EnvironmentCheck::ERROR, $cacheHeadersCheck->check());
100
+	}
101 101
 }
Please login to merge, or discard this patch.
tests/Checks/SessionCheckTest.php 1 patch
Indentation   +50 added lines, -50 removed lines patch added patch discarded remove patch
@@ -15,62 +15,62 @@
 block discarded – undo
15 15
  */
16 16
 class SessionCheckTest extends SapphireTest
17 17
 {
18
-    /**
19
-     * @var SilverStripe\EnvironmentCheck\Checks\SessionCheck
20
-     */
21
-    public $sessionCheck = null;
18
+	/**
19
+	 * @var SilverStripe\EnvironmentCheck\Checks\SessionCheck
20
+	 */
21
+	public $sessionCheck = null;
22 22
 
23
-    /**
24
-     * Create a session check for use by tests.
25
-     *
26
-     * @return void
27
-     */
28
-    protected function setUp()
29
-    {
30
-        parent::setUp();
31
-        $this->sessionCheck = new SessionCheck('/');
32
-    }
23
+	/**
24
+	 * Create a session check for use by tests.
25
+	 *
26
+	 * @return void
27
+	 */
28
+	protected function setUp()
29
+	{
30
+		parent::setUp();
31
+		$this->sessionCheck = new SessionCheck('/');
32
+	}
33 33
 
34
-    /**
35
-     * Env check reports error when session cookies are being set.
36
-     *
37
-     * @return void
38
-     */
39
-    public function testSessionSet()
40
-    {
41
-        // Create a mock and queue two responses.
42
-        $mock = new MockHandler([
43
-            new Response(200, ['Set-Cookie' => 'PHPSESSID:foo']),
44
-            new Response(200, ['Set-Cookie' => 'SECSESSID:bar'])
45
-        ]);
34
+	/**
35
+	 * Env check reports error when session cookies are being set.
36
+	 *
37
+	 * @return void
38
+	 */
39
+	public function testSessionSet()
40
+	{
41
+		// Create a mock and queue two responses.
42
+		$mock = new MockHandler([
43
+			new Response(200, ['Set-Cookie' => 'PHPSESSID:foo']),
44
+			new Response(200, ['Set-Cookie' => 'SECSESSID:bar'])
45
+		]);
46 46
 
47
-        $handler = HandlerStack::create($mock);
48
-        $client = new Client(['handler' => $handler]);
49
-        $this->sessionCheck->client = $client;
47
+		$handler = HandlerStack::create($mock);
48
+		$client = new Client(['handler' => $handler]);
49
+		$this->sessionCheck->client = $client;
50 50
 
51
-        // Check for PHPSESSID
52
-        $this->assertContains(EnvironmentCheck::ERROR, $this->sessionCheck->check());
51
+		// Check for PHPSESSID
52
+		$this->assertContains(EnvironmentCheck::ERROR, $this->sessionCheck->check());
53 53
 
54
-        // Check for SECSESSID
55
-        $this->assertContains(EnvironmentCheck::ERROR, $this->sessionCheck->check());
56
-    }
54
+		// Check for SECSESSID
55
+		$this->assertContains(EnvironmentCheck::ERROR, $this->sessionCheck->check());
56
+	}
57 57
 
58
-    /**
59
-     * Env check responds OK when no session cookies are set in response.
60
-     *
61
-     * @return void
62
-     */
63
-    public function testSessionNotSet()
64
-    {
65
-        // Create a mock and queue two responses.
66
-        $mock = new MockHandler([
67
-            new Response(200)
68
-        ]);
58
+	/**
59
+	 * Env check responds OK when no session cookies are set in response.
60
+	 *
61
+	 * @return void
62
+	 */
63
+	public function testSessionNotSet()
64
+	{
65
+		// Create a mock and queue two responses.
66
+		$mock = new MockHandler([
67
+			new Response(200)
68
+		]);
69 69
 
70
-        $handler = HandlerStack::create($mock);
71
-        $client = new Client(['handler' => $handler]);
72
-        $this->sessionCheck->client = $client;
70
+		$handler = HandlerStack::create($mock);
71
+		$client = new Client(['handler' => $handler]);
72
+		$this->sessionCheck->client = $client;
73 73
 
74
-        $this->assertContains(EnvironmentCheck::OK, $this->sessionCheck->check());
75
-    }
74
+		$this->assertContains(EnvironmentCheck::OK, $this->sessionCheck->check());
75
+	}
76 76
 }
Please login to merge, or discard this patch.
src/Services/ClientFactory.php 1 patch
Indentation   +29 added lines, -29 removed lines patch added patch discarded remove patch
@@ -14,36 +14,36 @@
 block discarded – undo
14 14
  */
15 15
 class ClientFactory implements Factory
16 16
 {
17
-    use Configurable;
17
+	use Configurable;
18 18
 
19
-    /**
20
-     * Default config for Guzzle client.
21
-     *
22
-     * @var array
23
-     */
24
-    private static $default_config = [];
19
+	/**
20
+	 * Default config for Guzzle client.
21
+	 *
22
+	 * @var array
23
+	 */
24
+	private static $default_config = [];
25 25
 
26
-    /**
27
-     * Wrapper to create a Guzzle client.
28
-     *
29
-     * {@inheritdoc}
30
-     */
31
-    public function create($service, array $params = [])
32
-    {
33
-        return new GuzzleClient($this->getConfig($params));
34
-    }
26
+	/**
27
+	 * Wrapper to create a Guzzle client.
28
+	 *
29
+	 * {@inheritdoc}
30
+	 */
31
+	public function create($service, array $params = [])
32
+	{
33
+		return new GuzzleClient($this->getConfig($params));
34
+	}
35 35
 
36
-    /**
37
-     * Merge config provided from yaml with default config
38
-     *
39
-     * @param array $overrides
40
-     * @return array
41
-     */
42
-    public function getConfig(array $overrides)
43
-    {
44
-        return array_merge(
45
-            $this->config()->get('default_config'),
46
-            $overrides
47
-        );
48
-    }
36
+	/**
37
+	 * Merge config provided from yaml with default config
38
+	 *
39
+	 * @param array $overrides
40
+	 * @return array
41
+	 */
42
+	public function getConfig(array $overrides)
43
+	{
44
+		return array_merge(
45
+			$this->config()->get('default_config'),
46
+			$overrides
47
+		);
48
+	}
49 49
 }
Please login to merge, or discard this patch.
src/Traits/Fetcher.php 1 patch
Indentation   +34 added lines, -34 removed lines patch added patch discarded remove patch
@@ -11,41 +11,41 @@
 block discarded – undo
11 11
  */
12 12
 trait Fetcher
13 13
 {
14
-    /**
15
-     * Client for making requests, set vi Injector.
16
-     *
17
-     * @see SilverStripe\EnvironmentCheck\Services
18
-     *
19
-     * @var GuzzleHttp\Client
20
-     */
21
-    public $client = null;
14
+	/**
15
+	 * Client for making requests, set vi Injector.
16
+	 *
17
+	 * @see SilverStripe\EnvironmentCheck\Services
18
+	 *
19
+	 * @var GuzzleHttp\Client
20
+	 */
21
+	public $client = null;
22 22
 
23
-    /**
24
-     * Absolute URL for requests.
25
-     *
26
-     * @var string
27
-     */
28
-    protected $url;
23
+	/**
24
+	 * Absolute URL for requests.
25
+	 *
26
+	 * @var string
27
+	 */
28
+	protected $url;
29 29
 
30
-    /**
31
-     * Set URL for requests.
32
-     *
33
-     * @param string $url Relative URL
34
-     * @return self
35
-     */
36
-    public function setURL($url)
37
-    {
38
-        $this->url = Director::absoluteURL($url);
39
-        return $this;
40
-    }
30
+	/**
31
+	 * Set URL for requests.
32
+	 *
33
+	 * @param string $url Relative URL
34
+	 * @return self
35
+	 */
36
+	public function setURL($url)
37
+	{
38
+		$this->url = Director::absoluteURL($url);
39
+		return $this;
40
+	}
41 41
 
42
-    /**
43
-     * Getter for URL
44
-     *
45
-     * @return string
46
-     */
47
-    public function getURL()
48
-    {
49
-        return $this->url;
50
-    }
42
+	/**
43
+	 * Getter for URL
44
+	 *
45
+	 * @return string
46
+	 */
47
+	public function getURL()
48
+	{
49
+		return $this->url;
50
+	}
51 51
 }
Please login to merge, or discard this patch.