silverstripe / silverstripe-environmentcheck

src/Checks/FileAccessibilityAndValidationCheck.php

Doc Comments +1 added lines, -1 removed lines

@@ -74,7 +74,7 @@
     /**
      * {@inheritDoc}
      *
-     * @return array
+     * @return string[]
      */
     public function check()
     {

Spacing +4 added lines, -4 removed lines

@@ -67,7 +67,7 @@ 
     public function __construct($path, $fileTypeValidateFunc = 'noVidation', $checkType = null)
     {
         $this->path = $path;
-        $this->fileTypeValidateFunc = ($fileTypeValidateFunc)? $fileTypeValidateFunc : 'noVidation';
+        $this->fileTypeValidateFunc = ($fileTypeValidateFunc) ? $fileTypeValidateFunc : 'noVidation';
         $this->checkType = ($checkType) ? $checkType : self::CHECK_SINGLE;
     }
 
@@ -100,7 +100,7 @@ 
                 if ($this->checkType == self::CHECK_SINGLE && count($invalidFiles) < count($files)) {
                     $validFileList = PHP_EOL;
                     foreach ($validFiles as $vf) {
-                        $validFileList .= $vf . PHP_EOL;
+                        $validFileList .= $vf.PHP_EOL;
                     }
                     if ($fileTypeValidateFunc == 'noVidation') {
                         $checkReturn = [
@@ -123,7 +123,7 @@ 
                     } else {
                         $invalidFileList = PHP_EOL;
                         foreach ($invalidFiles as $vf) {
-                            $invalidFileList .= $vf . PHP_EOL;
+                            $invalidFileList .= $vf.PHP_EOL;
                         }
 
                         if ($fileTypeValidateFunc == 'noVidation') {
@@ -144,7 +144,7 @@ 
                     }
                 }
             } else {
-                $checkReturn =  array(
+                $checkReturn = array(
                     EnvironmentCheck::ERROR,
                     sprintf("Invalid file type validation method name passed: %s ", $fileTypeValidateFunc)
                 );

src/EnvironmentCheckSuite.php

Doc Comments +2 added lines, -2 removed lines

@@ -106,7 +106,7 @@ 
     /**
      * Run this test suite and return the result code of the worst result.
      *
-     * @return int
+     * @return EnvironmentCheckSuiteResult
      */
     public function run()
     {
@@ -195,7 +195,7 @@ 
     /**
      * Register a check against the named check suite.
      *
-     * @param string|array $names
+     * @param string $names
      * @param EnvironmentCheck $check
      * @param string|array
      */

Spacing +1 added lines, -1 removed lines

@@ -150,7 +150,7 @@
             } elseif ($checkClass instanceof EnvironmentCheck) {
                 $output[] = [$checkClass, $checkTitle];
             } else {
-                throw new InvalidArgumentException("Bad EnvironmentCheck: " . var_export($check, true));
+                throw new InvalidArgumentException("Bad EnvironmentCheck: ".var_export($check, true));
             }
         }
         return $output;

src/Checks/HasFunctionCheck.php

Spacing +2 added lines, -2 removed lines

@@ -32,8 +32,8 @@
     public function check()
     {
         if (function_exists($this->functionName)) {
-            return [EnvironmentCheck::OK, $this->functionName . '() exists'];
+            return [EnvironmentCheck::OK, $this->functionName.'() exists'];
         }
-        return [EnvironmentCheck::ERROR, $this->functionName . '() doesn\'t exist'];
+        return [EnvironmentCheck::ERROR, $this->functionName.'() doesn\'t exist'];
     }
 }

src/Checks/FileAgeCheck.php

Spacing +1 added lines, -1 removed lines

@@ -96,7 +96,7 @@
      */
     public function check()
     {
-        $cutoffTime =  strtotime($this->relativeAge, DBDatetime::now()->Format('U'));
+        $cutoffTime = strtotime($this->relativeAge, DBDatetime::now()->Format('U'));
         $files = $this->getFiles();
         $invalidFiles = [];
         $validFiles = [];

Doc Comments +1 added lines, -1 removed lines

@@ -74,7 +74,7 @@
     /**
      * {@inheritDoc}
      *
-     * @return array
+     * @return string[]
      */
     public function check()
     {

src/Checks/HasClassCheck.php

Spacing +2 added lines, -2 removed lines

@@ -32,8 +32,8 @@
     public function check()
     {
         if (class_exists($this->className)) {
-            return [EnvironmentCheck::OK, 'Class ' . $this->className.' exists'];
+            return [EnvironmentCheck::OK, 'Class '.$this->className.' exists'];
         }
-        return [EnvironmentCheck::ERROR, 'Class ' . $this->className.' doesn\'t exist'];
+        return [EnvironmentCheck::ERROR, 'Class '.$this->className.' doesn\'t exist'];
     }
 }

src/Checks/FileWriteableCheck.php

Spacing +3 added lines, -3 removed lines

@@ -34,7 +34,7 @@ 
         if ($this->path[0] == '/') {
             $filename = $this->path;
         } else {
-            $filename = BASE_PATH . DIRECTORY_SEPARATOR . str_replace('/', DIRECTORY_SEPARATOR, $this->path);
+            $filename = BASE_PATH.DIRECTORY_SEPARATOR.str_replace('/', DIRECTORY_SEPARATOR, $this->path);
         }
 
         if (file_exists($filename)) {
@@ -67,8 +67,8 @@ 
                     }
                     if ($groupList) {
                         $message .= "	We recommend that you make the file group-writeable and change the group to "
-                            . "one of these groups:\n - " . implode("\n - ", $groupList)
-                            . "\n\nFor example:\nchmod g+w $filename\nchgrp " . $groupList[0] . " $filename";
+                            . "one of these groups:\n - ".implode("\n - ", $groupList)
+                            . "\n\nFor example:\nchmod g+w $filename\nchgrp ".$groupList[0]." $filename";
                     } else {
                         $message .= "  There is no user-group that contains both the web-server user and the owner "
                             . "of this file.  Change the ownership of the file, create a new group, or temporarily "

src/Checks/SMTPConnectCheck.php

Doc Comments +1 added lines, -1 removed lines

@@ -74,7 +74,7 @@
     /**
      * {@inheritDoc}
      *
-     * @return array
+     * @return string[]
      */
     public function check()
     {

src/Checks/SolrIndexCheck.php

Spacing +2 added lines, -2 removed lines

@@ -27,7 +27,7 @@ 
         if (!class_exists(Solr::class)) {
             return [
                 EnvironmentCheck::ERROR,
-                'Class `' . Solr::class . '` not found. Is the fulltextsearch module installed?'
+                'Class `'.Solr::class.'` not found. Is the fulltextsearch module installed?'
             ];
         }
 
@@ -43,7 +43,7 @@ 
         if (!empty($brokenCores)) {
             return [
                 EnvironmentCheck::ERROR,
-                'The following indexes are unavailable: ' . implode($brokenCores, ', ')
+                'The following indexes are unavailable: '.implode($brokenCores, ', ')
             ];
         }