SilverStripe\EnvironmentCheck\Checks\SMTPConnectCheck

Complexity

Total Complexity

8

Size/Duplication

Total Lines	64
Duplicated Lines	0 %

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	check()	0	20	3
A	__construct()	0	13	5

<?php

namespace SilverStripe\EnvironmentCheck\Checks;

use SilverStripe\EnvironmentCheck\EnvironmentCheck;

/**
 * Checks if the SMTP connection configured through PHP.ini works as expected.
 *
 * Only checks socket connection with HELO command, not actually sending the email.
 *
 * @package environmentcheck
 */
class SMTPConnectCheck implements EnvironmentCheck
{
    /**
     * @var string
     */
    protected $host;

    /**
     * @var int
     */
    protected $port;

    /**
     * Timeout (in seconds).
     *
     * @var int
     */
    protected $timeout;

    /**
     * @param null|string $host
     * @param null|int $port
     * @param int $timeout
     */
    public function __construct($host = null, $port = null, $timeout = 15)
    {
        $this->host = ($host) ? $host : ini_get('SMTP');
        if (!$this->host) {
            $this->host = 'localhost';
        }

        $this->port = ($port) ? $port : ini_get('smtp_port');

It seems like $port ? $port : ini_get('smtp_port') can also be of type string. However, the property $port is declared as type integer. Maybe add an additional type check?

        if (!$this->port) {
            $this->port = 25;
        }

        $this->timeout = $timeout;
    }

    /**
     * {@inheritDoc}
     *
     * @return array
     */
    public function check()
    {
        $f = @fsockopen($this->host, $this->port, $errno, $errstr, $this->timeout);
        if (!$f) {

$f is of type false|resource, thus it always evaluated to false.

            return [
                EnvironmentCheck::ERROR,
                sprintf("Couldn't connect to SMTP on %s:%s (Error: %s %s)", $this->host, $this->port, $errno, $errstr)
            ];
        }

        fwrite($f, "HELO its_me\r\n");
        $response = fread($f, 26);
        if (substr($response, 0, 3) != '220') {
            return [
                EnvironmentCheck::ERROR,
                sprintf('Invalid mail server response: %s', $response)
            ];
        }

        return [EnvironmentCheck::OK, ''];
    }
}