silverstripe / silverstripe-elemental

tests/Src/TestElement.php

<?php

namespace DNADesign\Elemental\Tests\Src;

use DNADesign\Elemental\Models\BaseElement;
use SilverStripe\Dev\TestOnly;
use SilverStripe\Security\Permission;

class TestElement extends BaseElement implements TestOnly
{
    private static $table_name = 'TestElement';

The private property $table_name is not used, and could be removed.

    private static $db = [

The private property $db is not used, and could be removed.

        'TestValue' => 'Text',
    ];

    private static $controller_class = TestElementController::class;

The private property $controller_class is not used, and could be removed.

    public function getType()
    {
        return 'A test element';
    }

    public function canView($member = null)
    {
        $check = Permission::checkMember($member, 'ADMIN');
        if ($check !== null) {

The condition $check !== null is always true.

            return $check;
        }
        return parent::canView($member);
    }
}