silverstripe / silverstripe-elemental

src/Forms/TextCheckboxGroupField.php

<?php

namespace DNADesign\Elemental\Forms;

use SilverStripe\Forms\CheckboxField;
use SilverStripe\Forms\CompositeField;
use SilverStripe\Forms\LiteralField;
use SilverStripe\Forms\TextField;

class TextCheckboxGroupField extends CompositeField
{
    protected $schemaComponent = 'TextCheckboxGroupField';

    /**
     * Set the composite's title to that of the first child
     *
     * @param string|null $title
     */
    public function __construct($title = null)
    {
        if (!$title) {
            $title = _t(__CLASS__ . '.Title', 'Title');
        }

        $fields = [
            TextField::create('Title', $title),
            CheckboxField::create('ShowTitle', _t(__CLASS__ . '.ShowTitleLabel', 'Displayed'))
        ];

        parent::__construct($fields);

        $this->setTitle($title);
    }

    /**
     * Don't use the custom template for readonly states
     *
     * {@inheritDoc}
     */
    public function performReadonlyTransformation()
    {
        $field = $this;

        if (!$this->readonly) {
            $field = parent::performReadonlyTransformation();

            $field->setTemplate(CompositeField::class);
            $field->setTitle('Title');

            $titleField = $field->fieldByName('Title');

Are you sure the assignment to $titleField is correct as $field->fieldByName('Title') targeting SilverStripe\Forms\CompositeField::fieldByName() seems to always return null.

            if ($titleField) {

$titleField is of type null, thus it always evaluated to false.

                $field->replaceField('Title', LiteralField::create(
                    'Title',
                    $titleField->Value()
                ));
            }

            $displayedText = _t(__CLASS__ . '.DISPLAYED', 'Displayed');
            $notDisplayedText = _t(__CLASS__ . '.NOT_DISPLAYED', 'Not displayed');
            $showTitle = $field->fieldByName('ShowTitle');

Are you sure the assignment to $showTitle is correct as $field->fieldByName('ShowTitle') targeting SilverStripe\Forms\CompositeField::fieldByName() seems to always return null.

            if ($showTitle) {

$showTitle is of type null, thus it always evaluated to false.

                $field->replaceField('ShowTitle', LiteralField::create(
                    'ShowTitle',
                    $showTitle->Value() === 'Yes' ? $displayedText : $notDisplayedText
                )->addExtraClass('show-title'));
            }
        }

        return $field;
    }
}