| Conditions | 2 |
| Paths | 2 |
| Total Lines | 70 |
| Code Lines | 45 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 32 | public function __construct($children = null) |
||
| 33 | { |
||
| 34 | if ($children) { |
||
| 35 | $class = get_class(); |
||
| 36 | throw new InvalidArgumentException( |
||
| 37 | "${class}::__construct does not accept extra parameters." |
||
| 38 | ); |
||
| 39 | } |
||
| 40 | |||
| 41 | // Add JS specific to this field. |
||
| 42 | Requirements::javascript('silverstripe/documentconverter: javascript/DocumentConversionField.js'); |
||
| 43 | |||
| 44 | $fields = FieldList::create([ |
||
| 45 | HeaderField::create( |
||
| 46 | 'FileWarningHeader', |
||
| 47 | _t( |
||
| 48 | __CLASS__ . '.FileWarningHeader', |
||
| 49 | 'Warning: import will remove all content and subpages of this page.' |
||
| 50 | ), |
||
| 51 | 4 |
||
| 52 | ), |
||
| 53 | $splitHeader = DropdownField::create( |
||
| 54 | 'DocumentConversionSettings-SplitHeader', |
||
| 55 | _t( |
||
| 56 | __CLASS__ . '.SplitHeader', |
||
| 57 | 'Split document into pages' |
||
| 58 | ), |
||
| 59 | [ |
||
| 60 | 0 => _t(__CLASS__ . '.No', 'no'), |
||
| 61 | 1 => _t(__CLASS__ . '.EachH1', 'for each heading 1'), |
||
| 62 | 2 => _t(__CLASS__ . '.EachH2', 'for each heading 2') |
||
| 63 | ] |
||
| 64 | ), |
||
| 65 | $keepSource = CheckboxField::create( |
||
| 66 | 'DocumentConversionSettings-KeepSource', |
||
| 67 | _t( |
||
| 68 | __CLASS__ . '.KeepSource', |
||
| 69 | 'Keep the original document. Adds a link to it on TOC, if enabled.' |
||
| 70 | ) |
||
| 71 | ), |
||
| 72 | $chosenFolderID = TreeDropdownField::create( |
||
| 73 | 'DocumentConversionSettings-ChosenFolderID', |
||
| 74 | _t(__CLASS__ . '.ChooseFolder', 'Choose a folder to save this file'), |
||
| 75 | Folder::class |
||
| 76 | ), |
||
| 77 | $includeTOC = CheckboxField::create( |
||
| 78 | 'DocumentConversionSettings-IncludeTOC', |
||
| 79 | _t(__CLASS__ . '.IncludeTOC', 'Replace this page with a Table of Contents.') |
||
| 80 | ), |
||
| 81 | $publishPages = CheckboxField::create( |
||
| 82 | 'DocumentConversionSettings-PublishPages', |
||
| 83 | _t( |
||
| 84 | __CLASS__ . '.publishPages', |
||
| 85 | 'Publish modified pages (not recommended unless you are sure about the conversion outcome)' |
||
| 86 | ) |
||
| 87 | ), |
||
| 88 | $this->innerField = ImportField::create( |
||
| 89 | 'ImportedFromFile', |
||
| 90 | _t(__CLASS__ . '.ImportedFromFile', 'Import content from a word document') |
||
| 91 | ) |
||
| 92 | ]); |
||
| 93 | |||
| 94 | // Prevent the warning popup that appears when navigating away from the page. |
||
| 95 | $splitHeader->addExtraClass('no-change-track'); |
||
| 96 | $keepSource->addExtraClass('no-change-track'); |
||
| 97 | $chosenFolderID->addExtraClass('no-change-track'); |
||
| 98 | $includeTOC->addExtraClass('no-change-track'); |
||
| 99 | $publishPages->addExtraClass('no-change-track'); |
||
| 100 | |||
| 101 | return parent::__construct($fields); |
||
| 102 | } |
||
| 109 |