Issues in DMSDocument_versions.php (master) - Issues in master - silverstripe/silverstripe-dms - Measure and Improve Code Quality continuously with Scrutinizer

Issues (399)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

code/model/DMSDocument_versions.php (21 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

/**
 * DataObject to store versions of uploaded Documents.
 *
 * Versions are only created when replacing a document, not on every save of the
 * DMSDocument dataobject. So, versions store the various versions of the
 * underlying Document, not the DataObject with information about that object.
 *
 * @package dms
 */
class DMSDocument_versions extends DataObject
{

    /**
     * @var bool $enable_versions Flag that turns on or off versions of
     * documents when replacing them
     */
    public static $enable_versions = true;

    private static $db = array(

        'VersionCounter' => 'Int',
        'VersionViewCount' => 'Int'
    );

    private static $has_one = array(

        'Document' => 'DMSDocument'
    );

    private static $defaults = array(

        'VersionCounter' => 0
    );

    private static $display_fields = array(
        'VersionCounter' => 'Version Counter',
        'FilenameWithoutID' => 'Filename',
        'LastEdited' => 'Last Changed'
    );

    private static $summary_fields = array(

        'VersionCounter',
        'FilenameWithoutID'
    );

    private static $field_labels = array(

        'FilenameWithoutID'=>'Filename'
    );

    private static $default_sort = array(

        'LastEdited' => 'DESC'
    );


    /**
     * Creates a new version of a document by moving the current file and
     * renaming it to the versioned filename.
     *
     * This method assumes that the method calling this is just about to upload
     * a new file to replace the old file.
     *
     * @static
     * @param DMSDocument $doc
     *
     * @return bool Success or failure
     */
    public static function create_version(DMSDocument $doc)
    {
        $success = false;

        $existingPath = $doc->getFullPath();
        if (is_file($existingPath)) {
            $docData = $doc->toMap();
            unset($docData['ID']);
            $version = new DMSDocument_versions($docData);  //create a copy of the current DMSDocument as a version

            $previousVersionCounter  = 0;
            $newestExistingVersion = self::get_versions($doc)->sort(array('Created'=>'DESC', 'ID'=>'DESC'))->limit(1);
            if ($newestExistingVersion && $newestExistingVersion->Count() > 0) {
                $previousVersionCounter = $newestExistingVersion->first()->VersionCounter;
            }

            //change the filename field to a field containing the new soon-to-be versioned file
            $version->VersionCounter = $previousVersionCounter + 1; //start versions at 1
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            $newFilename = $version->generateVersionedFilename($doc, $version->VersionCounter);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            $version->Filename = $newFilename;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

            //add a relation back to the origin ID;
            $version->DocumentID = $doc->ID;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            $id = $version->write();

            if (!empty($id)) {
                rename($existingPath, $version->getFullPath());
                $success = true;
            }
        }

        return $success;
    }

    public function delete()
    {
        $path = $this->getFullPath();

        if (file_exists($path)) {
            unlink($path);
        }

        parent::delete();
    }

    /**
     * Returns a DataList of all previous Versions of a document (check the
     * LastEdited date of each object to find the correct one).
     *
     * @static
     * @param DMSDocument $doc
     *
     * @return DataList List of Document objects
     */
    public static function get_versions(DMSDocument $doc)
    {
        if (!DMSDocument_versions::$enable_versions) {
            user_error("DMSDocument versions are disabled", E_USER_WARNING);
        }
        return DMSDocument_versions::get()->filter(array('DocumentID' => $doc->ID));
    }

    public function __construct($record = null, $isSingleton = false, $model = null)
    {
        //check what the constructor was passed
        $dmsObject = null;
        if ($record && is_subclass_of($record, 'DMSDocumentInterface')) {
            $dmsObject = $record;
            $record = null; //cancel the record creation to just create an empty object
        }

        //create the object
        parent::__construct($record, $isSingleton, $model);

        //copy the DMSDocument object, if passed into the constructor
        if ($dmsObject) {
            foreach (array_keys(DataObject::custom_database_fields($dmsObject->ClassName)) as $key) {
                $this->$key = $dmsObject->$key;
            }
        }
    }

    /**
     * Returns a link to download this document from the DMS store.
     *
     * @return string
     */
    public function getLink()
    {
        return Controller::join_links(Director::baseURL(), 'dmsdocument/version'.$this->ID);
    }

    /**
     * Document versions are always hidden from outside viewing. Only admins can
     * download them.
     *
     * @return bool
     */
    public function isHidden()
    {
        return true;
    }

    /**
     * Returns the full filename of the document stored in this object. Can
     * optionally specify which filename to use at the end.
     *
     * @param string
     *
     * @return string
     */
    public function getFullPath($filename = null)
    {
        if (!$filename) {
            $filename = $this->Filename;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        }
        return DMS::inst()->getStoragePath() . DIRECTORY_SEPARATOR . $this->Folder . DIRECTORY_SEPARATOR . $filename;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
    }

    /**
     * @return string
     */
    public function getFilenameWithoutID()
    {
        $filenameParts = explode('~', $this->Filename);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $filename = array_pop($filenameParts);

        return $filename;
    }

    /**
     * Creates a new filename for the current Document's file when replacing the
     * current file with a new file.
     *
     * @param DMSDocument $filename The original filename
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     *
     * @return string The new filename

     */
    protected function generateVersionedFilename(DMSDocument $doc, $versionCounter)
    {
        $filename = $doc->Filename;

        do {
            // Add leading zeros to make sorting accurate up to 10,000 documents
            $versionPaddingString = str_pad($versionCounter, 4, '0', STR_PAD_LEFT);
            $newVersionFilename = preg_replace('/([0-9]+~)(.*?)/', '$1~'.$versionPaddingString.'~$2', $filename);

            // Sanity check for crazy document names
            if ($newVersionFilename == $filename || empty($newVersionFilename)) {
                user_error('Cannot generate new document filename for file: '.$filename, E_USER_ERROR);
            }

            // Increase the counter for the next loop run, if necessary
            $versionCounter++;
        } while (file_exists($this->getFullPath($newVersionFilename)));

        return $newVersionFilename;
    }

    /**
     * Return the extension of the file associated with the document.
     *
     * @return string
     */
    public function getExtension()
    {
        return strtolower(pathinfo($this->Filename, PATHINFO_EXTENSION));
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
    }

    /**
     * @return string

     */
    public function getSize()
    {
        $size = $this->getAbsoluteSize();

        return ($size) ? File::format_size($size) : false;
    }

    /**
     * Return the size of the file associated with the document.
     *
     * @return string

     */
    public function getAbsoluteSize()
    {
        return filesize($this->getFullPath());
    }

    /**
     * An alias to DMSDocument::getSize()
     *
     * @return string

     */
    public function getFileSizeFormatted()
    {
        return $this->getSize();
    }

    /**
     * @return DMSDocument_versions
     */
    public function trackView()
    {
        if ($this->ID > 0) {
            $this->VersionViewCount++;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

            $count = $this->VersionViewCount;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

            DB::query("UPDATE \"DMSDocument_versions\" SET \"VersionViewCount\"='$count' WHERE \"ID\"={$this->ID}");
        }

        return $this;
    }
}


silverstripe / silverstripe-dms

Issues (399)

Security Analysis not enabled

code/model/DMSDocument_versions.php (21 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like