DMSDocumentControllerTest

Complexity

Total Complexity

4

Size/Duplication

Total Lines	66
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	7

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	setUp()	0	11	1
A	tearDown()	0	5	1
A	testDownloadBehaviourOpen()	0	20	1
A	behaviourProvider()	0	7	1

<?php

/**
 * Class DMSDocumentControllerTest
 */
class DMSDocumentControllerTest extends SapphireTest

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{
    protected static $fixture_file = 'dmstest.yml';

    /**
     * @var DMSDocument_Controller
     */
    protected $controller;

    public function setUp()
    {
        parent::setUp();

        Config::inst()->update('DMS', 'folder_name', 'assets/_unit-test-123');
        $this->logInWithPermission('ADMIN');

        $this->controller = $this->getMockBuilder('DMSDocument_Controller')

The method getMockBuilder() does not seem to exist on object<DMSDocumentControllerTest>.

            ->setMethods(array('sendFile'))
            ->getMock();
    }

    public function tearDown()
    {
        DMSFilesystemTestHelper::delete('assets/_unit-test-123');
        parent::tearDown();
    }

    /**
     * Test that the download behaviour is either "open" or "download"
     *
     * @param string $behaviour
     * @param string $expectedDisposition
     * @dataProvider behaviourProvider
     */
    public function testDownloadBehaviourOpen($behaviour, $expectedDisposition)
    {
        $self = $this;
        $this->controller->expects($this->once())

The method once() does not seem to exist on object<DMSDocumentControllerTest>.

The method expects does not exist on object<DMSDocument_Controller>? Since you implemented __call, maybe consider adding a @method annotation.

            ->method('sendFile')
            ->will(
                $this->returnCallback(function ($path, $mime, $name, $disposition) use ($self, $expectedDisposition) {

The method returnCallback() does not seem to exist on object<DMSDocumentControllerTest>.

                    $self->assertEquals($expectedDisposition, $disposition);

The method assertEquals() does not seem to exist on object<DMSDocumentControllerTest>.

                })
            );

        $openDoc = DMS::inst()->storeDocument('dms/tests/DMS-test-lorum-file.pdf');
        $openDoc->DownloadBehavior = $behaviour;
        $openDoc->clearEmbargo(false);
        $openDoc->write();

        $request = new SS_HTTPRequest('GET', $openDoc->Link());
        $request->match('dmsdocument/$ID');
        $this->controller->index($request);
    }

    /**
     * @return array[]
     */
    public function behaviourProvider()
    {
        return array(
            array('open', 'inline'),
            array('download', 'attachment')
        );
    }
}