DMSDocumentSet::getCMSFields() - Code Metrics - Inspection of "Merge pull request #124 from robbieaverill/feature..." - silverstripe/silverstripe-dms - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( e4ab2b...e8d46a )

by Franco

created 2017-05-18 10:49 UTC

DMSDocumentSet::getCMSFields() B

↳ Parent: DMSDocumentSet

Complexity

Conditions	6
Paths	1

Size

Total Lines	99
Code Lines	68

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	99
rs	8.1585
c	0
b	0
f	0
cc	6
eloc	68
nc	1
nop	0

How to fix Long Method

<?php
/**
 * A document set is attached to Pages, and contains many DMSDocuments
 *
 * @property Varchar Title
 * @property  Text KeyValuePairs
 * @property  Enum SortBy
 * @property Enum SortByDirection
 */
class DMSDocumentSet extends DataObject
namespace YourVendor;

class YourClass { }
{
    private static $db = array(

        'Title' => 'Varchar(255)',
        'KeyValuePairs' => 'Text',
        'SortBy' => "Enum('LastEdited,Created,Title')')",
        'SortByDirection' => "Enum('DESC,ASC')')",
    );

    private static $has_one = array(

        'Page' => 'SiteTree',
    );

    private static $many_many = array(

        'Documents' => 'DMSDocument',
    );

    private static $many_many_extraFields = array(

        'Documents' => array(
            // Flag indicating if a document was added directly to a set - in which case it is set - or added
            // via the query-builder.
            'ManuallyAdded' => 'Boolean(1)',
        ),
    );

    /**
     * Retrieve a list of the documents in this set. An extension hook is provided before the result is returned.
     *
     * You can attach an extension to this event:
     *
     * <code>
     * public function updateDocuments($document)
     * {
     *     // do something
     * }
     * </code>
     *
     * @return DataList|null
     */
    public function getDocuments()
    {
        $documents = $this->Documents();

        $this->extend('updateDocuments', $documents);
        return $documents;
    }

    /**
     * Put the "documents" list into the main tab instead of its own tab, and replace the default "Add Document" button
     * with a customised button for DMS documents
     *
     * @return FieldList
     */
    public function getCMSFields()
    {
        // PHP 5.3 only
        $self = $this;
        $this->beforeUpdateCMSFields(function (FieldList $fields) use ($self) {
            $fields->removeFieldsFromTab(
                'Root.Main',
                array('KeyValuePairs', 'SortBy', 'SortByDirection')
            );
            // Don't put the GridField for documents in until the set has been created
            if (!$self->isInDB()) {
                $fields->addFieldToTab(
                    'Root.Main',
                    LiteralField::create(
                        'GridFieldNotice',
                        '<p class="message warning">' . _t(
                            'DMSDocumentSet.GRIDFIELD_NOTICE',
                            'Managing documents will be available once you have created this document set.'
                        ) . '</p>'
                    ),
                    'Title'
                );
            } else {
                // Document listing
                $gridFieldConfig = GridFieldConfig::create()
                    ->addComponents(
                        new GridFieldToolbarHeader(),
                        new GridFieldFilterHeader(),
                        new GridFieldSortableHeader(),
                        new GridFieldDataColumns(),
                        new GridFieldEditButton(),
                        // Special delete dialog to handle custom behaviour of unlinking and deleting
                        new GridFieldDeleteAction(true),
                        new GridFieldDetailForm()
                    );

                if (class_exists('GridFieldPaginatorWithShowAll')) {
                    $paginatorComponent = new GridFieldPaginatorWithShowAll(15);
                } else {
                    $paginatorComponent = new GridFieldPaginator(15);
                }
                $gridFieldConfig->addComponent($paginatorComponent);

                if (class_exists('GridFieldSortableRows')) {
                    $sortableComponent = new GridFieldSortableRows('DocumentSort');
                    // setUsePagination method removed from newer version of SortableGridField.
                    if (method_exists($sortableComponent, 'setUsePagination')) {
                        $sortableComponent->setUsePagination(false)->setForceRedraw(true);
                    }
                    $gridFieldConfig->addComponent($sortableComponent);
                }

                $gridFieldConfig->getComponentByType('GridFieldDataColumns')
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
                    ->setDisplayFields($self->getDocumentDisplayFields())
                    ->setFieldCasting(array('LastEdited' => 'Datetime->Ago'))
                    ->setFieldFormatting(
                        array(
                            'FilenameWithoutID' => '<a target=\'_blank\' class=\'file-url\' href=\'$Link\'>$FilenameWithoutID</a>',
                            'ManuallyAdded' => function ($value) {
                                if ($value) {
                                    return _t('DMSDocumentSet.MANUAL', 'Manually');
                                }
                                return _t('DMSDocumentSet.QUERYBUILDER', 'Query Builder');
                            }
                        )
                    );

                // Override delete functionality with this class
                $gridFieldConfig->getComponentByType('GridFieldDetailForm')
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
                    ->setItemRequestClass('DMSGridFieldDetailForm_ItemRequest');
                $gridField = GridField::create(
                    'Documents',
                    false,
                    $self->Documents(),

                    $gridFieldConfig
                );
                $gridField->setModelClass('DMSDocument');
                $gridField->addExtraClass('documents');

                $gridFieldConfig->addComponent(
                    $addNewButton = new DMSGridFieldAddNewButton,
                    'GridFieldExportButton'
                );
                $addNewButton->setDocumentSetId($self->ID);

                $fields->removeByName('Documents');
                $fields->addFieldsToTab(
                    'Root.Main',
                    array(
                        $gridField,
                        HiddenField::create('DMSShortcodeHandlerKey', false, DMS::inst()->getShortcodeHandlerKey())
                    )
                );
                $self->addQueryFields($fields);
            }
        });
        $this->addRequirements();
        return parent::getCMSFields();
    }

    /**
     * Add required CSS and Javascript requirements for managing documents
     *
     * @return $this
     */
    protected function addRequirements()
    {
        // Javascript to customize the grid field for the DMS document (overriding entwine
        // in FRAMEWORK_DIR.'/javascript/GridField.js'
        Requirements::javascript(DMS_DIR . '/javascript/DMSGridField.js');
        Requirements::css(DMS_DIR . '/dist/css/dmsbundle.css');

        // Javascript for the link editor pop-up in TinyMCE
        Requirements::javascript(DMS_DIR . '/javascript/DocumentHtmlEditorFieldToolbar.js');

        return $this;
    }

    /**
     * Adds the query fields to build the document logic to the DMSDocumentSet.
     *
     * To extend use the following from within an Extension subclass:
     *
     * <code>
     * public function updateQueryFields($result)
     * {
     *     // Do something here
     * }
     * </code>
     *
     * @param FieldList $fields
     */
    public function addQueryFields($fields)
    {
        /** @var DMSDocument $doc */
        $doc = singleton('DMSDocument');
        /** @var FormField $field */
        $dmsDocFields = $doc->scaffoldSearchFields(array('fieldClasses' => true));
        $membersMap = Member::get()->map('ID', 'Name')->toArray();
        asort($membersMap);

        foreach ($dmsDocFields as $field) {
            if ($field instanceof ListboxField) {
                $map = ($field->getName() === 'Tags__ID') ? $doc->getAllTagsMap() : $membersMap;
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
                $field->setMultiple(true)->setSource($map);
            }
        }
        $keyValPairs = JsonField::create('KeyValuePairs', $dmsDocFields->toArray());

        // Now lastly add the sort fields
        $sortedBy = FieldGroup::create('SortedBy', array(
            DropdownField::create('SortBy', '', array(
                'LastEdited'  => 'Last changed',
                'Created'     => 'Created',
                'Title'       => 'Document title',
            ), 'LastEdited'),
            DropdownField::create('SortByDirection', '', $this->dbObject('SortByDirection')->enumValues(), 'DESC'),
        ));

        $sortedBy->setTitle(_t('DMSDocumentSet.SORTED_BY', 'Sort the document set by:'));
        $fields->addFieldsToTab('Root.QueryBuilder', array($keyValPairs, $sortedBy));
        $this->extend('updateQueryFields', $fields);
    }

    public function onBeforeWrite()
    {
        parent::onBeforeWrite();

        $this->saveLinkedDocuments();
    }

    /**
     * Retrieve a list of the documents in this set. An extension hook is provided before the result is returned.
     */
    public function saveLinkedDocuments()
    {
        if (empty($this->KeyValuePairs) || !$this->isChanged('KeyValuePairs')) {
            return;
        }

        $keyValuesPair = Convert::json2array($this->KeyValuePairs);

        /** @var DMSDocument $dmsDoc */
        $dmsDoc = singleton('DMSDocument');
        $context = $dmsDoc->getDefaultSearchContext();

        $sortBy = $this->SortBy ? $this->SortBy : 'LastEdited';
        $sortByDirection = $this->SortByDirection ? $this->SortByDirection : 'DESC';
        $sortedBy = sprintf('%s %s', $sortBy, $sortByDirection);

        /** @var DataList $documents */
        $documents = $context->getResults($keyValuesPair, $sortedBy);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
        $documents = $this->addEmbargoConditions($documents);
        $documents = $this->addQueryBuilderSearchResults($documents);
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
    }

    /**
     * Add embargo date conditions to a search query
     *
     * @param  DataList $documents
     * @return DataList
     */
    protected function addEmbargoConditions(DataList $documents)
    {
        $now = SS_Datetime::now()->Rfc2822();

        return $documents->where(
            "\"EmbargoedIndefinitely\" = 0 AND "
            . " \"EmbargoedUntilPublished\" = 0 AND "
            . "(\"EmbargoedUntilDate\" IS NULL OR "
            . "(\"EmbargoedUntilDate\" IS NOT NULL AND '{$now}' >= \"EmbargoedUntilDate\")) AND "
            . "\"ExpireAtDate\" IS NULL OR (\"ExpireAtDate\" IS NOT NULL AND '{$now}' < \"ExpireAtDate\")"
        );
    }

    /**
     * Remove all ManuallyAdded = 0 original results and add in the new documents returned by the search context
     *
     * @param  DataList $documents
     * @return DataList
     */
    protected function addQueryBuilderSearchResults(DataList $documents)
    {
        /** @var ManyManyList $originals Documents that belong to just this set. */
        $originals = $this->Documents();

        $originals->removeByFilter('"ManuallyAdded" = 0');

        foreach ($documents as $document) {
            $originals->add($document, array('ManuallyAdded' => 0));
        }

        return $originals;
    }

    /**
     * Customise the display fields for the documents GridField
     *
     * @return array
     */
    public function getDocumentDisplayFields()
    {
        return array_merge(
            (array) DMSDocument::create()->config()->get('display_fields'),
            array('ManuallyAdded' => _t('DMSDocumentSet.ADDEDMETHOD', 'Added'))
        );
    }
}


Push — master ( e4ab2b...e8d46a )

DMSDocumentSet::getCMSFields() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Available Fixes

Available Fixes

1			<?php
2			/**
3			* A document set is attached to Pages, and contains many DMSDocuments
4			*
5			* @property Varchar Title
6			* @property Text KeyValuePairs
7			* @property Enum SortBy
8			* @property Enum SortByDirection
9			*/
10			class DMSDocumentSet extends DataObject
			0 ignored issues – show Coding Style Compatibility introduced 2017-05-05 01:36 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
11			{
12			private static $db = array(
			0 ignored issues – show Comprehensibility introduced 2017-05-09 22:22 UTC by Report Bug Copy Issue Report Consider using a different property name as you override a private property of the parent class. Loading history... Unused Code introduced 2017-05-09 22:22 UTC by Report Bug Copy Issue Report The property `$db` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
13			'Title' => 'Varchar(255)',
14			'KeyValuePairs' => 'Text',
15			'SortBy' => "Enum('LastEdited,Created,Title')')",
16			'SortByDirection' => "Enum('DESC,ASC')')",
17			);
18
19			private static $has_one = array(
			0 ignored issues – show Comprehensibility introduced 2017-05-15 05:21 UTC by Report Bug Copy Issue Report Consider using a different property name as you override a private property of the parent class. Loading history... Unused Code introduced 2017-05-05 01:36 UTC by Report Bug Copy Issue Report The property `$has_one` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
20			'Page' => 'SiteTree',
21			);
22
23			private static $many_many = array(
			0 ignored issues – show Comprehensibility introduced 2017-05-05 01:36 UTC by Report Bug Copy Issue Report Consider using a different property name as you override a private property of the parent class. Loading history... Unused Code introduced 2017-05-01 04:05 UTC by Report Bug Copy Issue Report The property `$many_many` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
24			'Documents' => 'DMSDocument',
25			);
26
27			private static $many_many_extraFields = array(
			0 ignored issues – show Comprehensibility introduced 2017-05-01 04:05 UTC by Report Bug Copy Issue Report Consider using a different property name as you override a private property of the parent class. Loading history... Unused Code introduced 2017-05-01 04:05 UTC by Report Bug Copy Issue Report The property `$many_many_extraFields` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
28			'Documents' => array(
29			// Flag indicating if a document was added directly to a set - in which case it is set - or added
30			// via the query-builder.
31			'ManuallyAdded' => 'Boolean(1)',
32			),
33			);
34
35			/**
36			* Retrieve a list of the documents in this set. An extension hook is provided before the result is returned.
37			*
38			* You can attach an extension to this event:
39			*
40			* <code>
41			* public function updateDocuments($document)
42			* {
43			* // do something
44			* }
45			* </code>
46			*
47			* @return DataList\|null
48			*/
49			public function getDocuments()
50			{
51			$documents = $this->Documents();
			0 ignored issues – show Bug introduced 2017-05-05 01:36 UTC by Report Bug Copy Issue Report The method `Documents()` does not exist on `DMSDocumentSet`. Did you maybe mean `getDocuments()`? This check marks calls to methods that do not seem to exist on an object. This is most likely the result of a method being renamed without all references to it being renamed likewise. Loading history...
52			$this->extend('updateDocuments', $documents);
53			return $documents;
54			}
55
56			/**
57			* Put the "documents" list into the main tab instead of its own tab, and replace the default "Add Document" button
58			* with a customised button for DMS documents
59			*
60			* @return FieldList
61			*/
62			public function getCMSFields()
63			{
64			// PHP 5.3 only
65			$self = $this;
66			$this->beforeUpdateCMSFields(function (FieldList $fields) use ($self) {
67			$fields->removeFieldsFromTab(
68			'Root.Main',
69			array('KeyValuePairs', 'SortBy', 'SortByDirection')
70			);
71			// Don't put the GridField for documents in until the set has been created
72			if (!$self->isInDB()) {
73			$fields->addFieldToTab(
74			'Root.Main',
75			LiteralField::create(
76			'GridFieldNotice',
77			'<p class="message warning">' . _t(
78			'DMSDocumentSet.GRIDFIELD_NOTICE',
79			'Managing documents will be available once you have created this document set.'
80			) . '</p>'
81			),
82			'Title'
83			);
84			} else {
85			// Document listing
86			$gridFieldConfig = GridFieldConfig::create()
87			->addComponents(
88			new GridFieldToolbarHeader(),
89			new GridFieldFilterHeader(),
90			new GridFieldSortableHeader(),
91			new GridFieldDataColumns(),
92			new GridFieldEditButton(),
93			// Special delete dialog to handle custom behaviour of unlinking and deleting
94			new GridFieldDeleteAction(true),
95			new GridFieldDetailForm()
96			);
97
98			if (class_exists('GridFieldPaginatorWithShowAll')) {
99			$paginatorComponent = new GridFieldPaginatorWithShowAll(15);
100			} else {
101			$paginatorComponent = new GridFieldPaginator(15);
102			}
103			$gridFieldConfig->addComponent($paginatorComponent);
104
105			if (class_exists('GridFieldSortableRows')) {
106			$sortableComponent = new GridFieldSortableRows('DocumentSort');
107			// setUsePagination method removed from newer version of SortableGridField.
108			if (method_exists($sortableComponent, 'setUsePagination')) {
109			$sortableComponent->setUsePagination(false)->setForceRedraw(true);
110			}
111			$gridFieldConfig->addComponent($sortableComponent);
112			}
113
114			$gridFieldConfig->getComponentByType('GridFieldDataColumns')
			0 ignored issues – show Bug introduced 2017-05-01 04:05 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `GridFieldComponent` as the method `setDisplayFields()` does only exist in the following implementations of said interface: `GridFieldDataColumns`, `GridFieldEditableColumns`, `GridFieldExternalLink`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
115			->setDisplayFields($self->getDocumentDisplayFields())
116			->setFieldCasting(array('LastEdited' => 'Datetime->Ago'))
117			->setFieldFormatting(
118			array(
119			'FilenameWithoutID' => '<a target=\'_blank\' class=\'file-url\' href=\'$Link\'>$FilenameWithoutID</a>',
120			'ManuallyAdded' => function ($value) {
121			if ($value) {
122			return _t('DMSDocumentSet.MANUAL', 'Manually');
123			}
124			return _t('DMSDocumentSet.QUERYBUILDER', 'Query Builder');
125			}
126			)
127			);
128
129			// Override delete functionality with this class
130			$gridFieldConfig->getComponentByType('GridFieldDetailForm')
			0 ignored issues – show Bug introduced 2017-05-01 21:16 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `GridFieldComponent` as the method `setItemRequestClass()` does only exist in the following implementations of said interface: `GridFieldAddNewMultiClass`, `GridFieldDetailForm`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
131			->setItemRequestClass('DMSGridFieldDetailForm_ItemRequest');
132			$gridField = GridField::create(
133			'Documents',
134			false,
135			$self->Documents(),
			0 ignored issues – show Bug introduced 2017-05-09 13:40 UTC by Report Bug Copy Issue Report The method `Documents()` does not exist on `DMSDocumentSet`. Did you maybe mean `getDocuments()`? This check marks calls to methods that do not seem to exist on an object. This is most likely the result of a method being renamed without all references to it being renamed likewise. Loading history...
136			$gridFieldConfig
137			);
138			$gridField->setModelClass('DMSDocument');
139			$gridField->addExtraClass('documents');
140
141			$gridFieldConfig->addComponent(
142			$addNewButton = new DMSGridFieldAddNewButton,
143			'GridFieldExportButton'
144			);
145			$addNewButton->setDocumentSetId($self->ID);
146
147			$fields->removeByName('Documents');
148			$fields->addFieldsToTab(
149			'Root.Main',
150			array(
151			$gridField,
152			HiddenField::create('DMSShortcodeHandlerKey', false, DMS::inst()->getShortcodeHandlerKey())
153			)
154			);
155			$self->addQueryFields($fields);
156			}
157			});
158			$this->addRequirements();
159			return parent::getCMSFields();
160			}
161
162			/**
163			* Add required CSS and Javascript requirements for managing documents
164			*
165			* @return $this
166			*/
167			protected function addRequirements()
168			{
169			// Javascript to customize the grid field for the DMS document (overriding entwine
170			// in FRAMEWORK_DIR.'/javascript/GridField.js'
171			Requirements::javascript(DMS_DIR . '/javascript/DMSGridField.js');
172			Requirements::css(DMS_DIR . '/dist/css/dmsbundle.css');
173
174			// Javascript for the link editor pop-up in TinyMCE
175			Requirements::javascript(DMS_DIR . '/javascript/DocumentHtmlEditorFieldToolbar.js');
176
177			return $this;
178			}
179
180			/**
181			* Adds the query fields to build the document logic to the DMSDocumentSet.
182			*
183			* To extend use the following from within an Extension subclass:
184			*
185			* <code>
186			* public function updateQueryFields($result)
187			* {
188			* // Do something here
189			* }
190			* </code>
191			*
192			* @param FieldList $fields
193			*/
194			public function addQueryFields($fields)
195			{
196			/** @var DMSDocument $doc */
197			$doc = singleton('DMSDocument');
198			/** @var FormField $field */
199			$dmsDocFields = $doc->scaffoldSearchFields(array('fieldClasses' => true));
200			$membersMap = Member::get()->map('ID', 'Name')->toArray();
201			asort($membersMap);
202
203			foreach ($dmsDocFields as $field) {
204			if ($field instanceof ListboxField) {
205			$map = ($field->getName() === 'Tags__ID') ? $doc->getAllTagsMap() : $membersMap;
			0 ignored issues – show Documentation Bug introduced 2017-05-16 23:02 UTC by Report Bug Copy Issue Report The method `getAllTagsMap` does not exist on `object<DMSDocument>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
206			$field->setMultiple(true)->setSource($map);
207			}
208			}
209			$keyValPairs = JsonField::create('KeyValuePairs', $dmsDocFields->toArray());
210
211			// Now lastly add the sort fields
212			$sortedBy = FieldGroup::create('SortedBy', array(
213			DropdownField::create('SortBy', '', array(
214			'LastEdited' => 'Last changed',
215			'Created' => 'Created',
216			'Title' => 'Document title',
217			), 'LastEdited'),
218			DropdownField::create('SortByDirection', '', $this->dbObject('SortByDirection')->enumValues(), 'DESC'),
219			));
220
221			$sortedBy->setTitle(_t('DMSDocumentSet.SORTED_BY', 'Sort the document set by:'));
222			$fields->addFieldsToTab('Root.QueryBuilder', array($keyValPairs, $sortedBy));
223			$this->extend('updateQueryFields', $fields);
224			}
225
226			public function onBeforeWrite()
227			{
228			parent::onBeforeWrite();
229
230			$this->saveLinkedDocuments();
231			}
232
233			/**
234			* Retrieve a list of the documents in this set. An extension hook is provided before the result is returned.
235			*/
236			public function saveLinkedDocuments()
237			{
238			if (empty($this->KeyValuePairs) \|\| !$this->isChanged('KeyValuePairs')) {
239			return;
240			}
241
242			$keyValuesPair = Convert::json2array($this->KeyValuePairs);
243
244			/** @var DMSDocument $dmsDoc */
245			$dmsDoc = singleton('DMSDocument');
246			$context = $dmsDoc->getDefaultSearchContext();
247
248			$sortBy = $this->SortBy ? $this->SortBy : 'LastEdited';
249			$sortByDirection = $this->SortByDirection ? $this->SortByDirection : 'DESC';
250			$sortedBy = sprintf('%s %s', $sortBy, $sortByDirection);
251
252			/** @var DataList $documents */
253			$documents = $context->getResults($keyValuesPair, $sortedBy);
			0 ignored issues – show Bug introduced 2017-05-09 13:40 UTC by Report Bug Copy Issue Report It seems like `$keyValuesPair` defined by `\Convert::json2array($this->KeyValuePairs)` on line `242` can also be of type `boolean`; however, `SearchContext::getResults()` does only seem to accept `array`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
254			$documents = $this->addEmbargoConditions($documents);
255			$documents = $this->addQueryBuilderSearchResults($documents);
			0 ignored issues – show Unused Code introduced 2017-05-16 23:02 UTC by Report Bug Copy Issue Report `$documents` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
256			}
257
258			/**
259			* Add embargo date conditions to a search query
260			*
261			* @param DataList $documents
262			* @return DataList
263			*/
264			protected function addEmbargoConditions(DataList $documents)
265			{
266			$now = SS_Datetime::now()->Rfc2822();
267
268			return $documents->where(
269			"\"EmbargoedIndefinitely\" = 0 AND "
270			. " \"EmbargoedUntilPublished\" = 0 AND "
271			. "(\"EmbargoedUntilDate\" IS NULL OR "
272			. "(\"EmbargoedUntilDate\" IS NOT NULL AND '{$now}' >= \"EmbargoedUntilDate\")) AND "
273			. "\"ExpireAtDate\" IS NULL OR (\"ExpireAtDate\" IS NOT NULL AND '{$now}' < \"ExpireAtDate\")"
274			);
275			}
276
277			/**
278			* Remove all ManuallyAdded = 0 original results and add in the new documents returned by the search context
279			*
280			* @param DataList $documents
281			* @return DataList
282			*/
283			protected function addQueryBuilderSearchResults(DataList $documents)
284			{
285			/** @var ManyManyList $originals Documents that belong to just this set. */
286			$originals = $this->Documents();
			0 ignored issues – show Bug introduced 2017-05-09 13:40 UTC by Report Bug Copy Issue Report The method `Documents()` does not exist on `DMSDocumentSet`. Did you maybe mean `getDocuments()`? This check marks calls to methods that do not seem to exist on an object. This is most likely the result of a method being renamed without all references to it being renamed likewise. Loading history...
287			$originals->removeByFilter('"ManuallyAdded" = 0');
288
289			foreach ($documents as $document) {
290			$originals->add($document, array('ManuallyAdded' => 0));
291			}
292
293			return $originals;
294			}
295
296			/**
297			* Customise the display fields for the documents GridField
298			*
299			* @return array
300			*/
301			public function getDocumentDisplayFields()
302			{
303			return array_merge(
304			(array) DMSDocument::create()->config()->get('display_fields'),
305			array('ManuallyAdded' => _t('DMSDocumentSet.ADDEDMETHOD', 'Added'))
306			);
307			}
308			}
309

silverstripe / silverstripe-dms

Push — master ( e4ab2b...e8d46a )

DMSDocumentSet::getCMSFields() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like