JsonFieldTest::testJsonFieldDataValueCouldDealWithArray() - Code Metrics - Inspection of "Added Query Builder functionality to Document Sets" - silverstripe/silverstripe-dms - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#119)

by Franco

created 2017-05-10 10:21 UTC

testJsonFieldDataValueCouldDealWithArray() A

↳ Parent: JsonFieldTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	19
Code Lines	12

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	19
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	12
nc	1
nop	0

<?php

class JsonFieldTest extends FunctionalTest
namespace YourVendor;

class YourClass { }
{
    function testJsonFieldConstructorMultiWays()

    {
        $jsonField = new JsonField('MyJsonField', new FieldList(
            new TextField('FirstName', 'Given name'),
            new TextField('Surname', 'Last name')
        ));
        $this->assertEquals($jsonField->FieldList()->count(), 2);

        $this->assertNotNull($jsonField->FieldList()->dataFieldByName('MyJsonField[FirstName]'));


        $jsonField = new JsonField('MyJsonField', array(new TextField('FirstName', 'Given name'),
            new TextField('Surname', 'Last name')));
        $this->assertEquals($jsonField->FieldList()->count(), 2);

        $this->assertNotNull($jsonField->FieldList()->dataFieldByName('MyJsonField[FirstName]'));


        $jsonField = new JsonField(
            'MyJsonField',
            new TextField('FirstName', 'Given name'),
            new TextField('Surname', 'Last name')
        );
        $this->assertEquals($jsonField->FieldList()->count(), 2);

        $this->assertNotNull($jsonField->FieldList()->dataFieldByName('MyJsonField[FirstName]'));

    }

    function testJsonFieldDataValueCouldDealWithArray()

    {
        $jsonField = new JsonField('MyJsonField', new FieldList(
            new TextField('FirstName', 'Given name'),
            new TextField('Surname', 'Last name')
        ));
        $jsonField->setValue($value = array(
            'MyJsonField'=>array(
                'FirstName' => 'Normann',
                'Surname' => 'Lou',
            ),
        ));

        $this->assertEquals($jsonField->dataValue(), Convert::array2json($value));

        $jsonField->setValue($value = array(
            'MyJsonField'=>array(),
        ));
        $this->assertNull($jsonField->dataValue());

    }
}


1			<?php
2
3			class JsonFieldTest extends FunctionalTest
			0 ignored issues – show Coding Style Compatibility introduced 2017-05-10 09:49 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
4			{
5			function testJsonFieldConstructorMultiWays()
			0 ignored issues – show Best Practice introduced 2017-05-10 09:49 UTC by Report Bug Copy Issue Report It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
6			{
7			$jsonField = new JsonField('MyJsonField', new FieldList(
8			new TextField('FirstName', 'Given name'),
9			new TextField('Surname', 'Last name')
10			));
11			$this->assertEquals($jsonField->FieldList()->count(), 2);
			0 ignored issues – show Bug introduced 2017-05-10 09:49 UTC by Report Bug Copy Issue Report The method `assertEquals()` does not seem to exist on `object<JsonFieldTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
12			$this->assertNotNull($jsonField->FieldList()->dataFieldByName('MyJsonField[FirstName]'));
			0 ignored issues – show Bug introduced 2017-05-10 09:49 UTC by Report Bug Copy Issue Report The method `assertNotNull()` does not seem to exist on `object<JsonFieldTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
13
14			$jsonField = new JsonField('MyJsonField', array(new TextField('FirstName', 'Given name'),
15			new TextField('Surname', 'Last name')));
16			$this->assertEquals($jsonField->FieldList()->count(), 2);
			0 ignored issues – show Bug introduced 2017-05-10 09:49 UTC by Report Bug Copy Issue Report The method `assertEquals()` does not seem to exist on `object<JsonFieldTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
17			$this->assertNotNull($jsonField->FieldList()->dataFieldByName('MyJsonField[FirstName]'));
			0 ignored issues – show Bug introduced 2017-05-10 09:49 UTC by Report Bug Copy Issue Report The method `assertNotNull()` does not seem to exist on `object<JsonFieldTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
18
19			$jsonField = new JsonField(
20			'MyJsonField',
21			new TextField('FirstName', 'Given name'),
22			new TextField('Surname', 'Last name')
23			);
24			$this->assertEquals($jsonField->FieldList()->count(), 2);
			0 ignored issues – show Bug introduced 2017-05-10 09:49 UTC by Report Bug Copy Issue Report The method `assertEquals()` does not seem to exist on `object<JsonFieldTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
25			$this->assertNotNull($jsonField->FieldList()->dataFieldByName('MyJsonField[FirstName]'));
			0 ignored issues – show Bug introduced 2017-05-10 09:49 UTC by Report Bug Copy Issue Report The method `assertNotNull()` does not seem to exist on `object<JsonFieldTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
26			}
27
28			function testJsonFieldDataValueCouldDealWithArray()
			0 ignored issues – show Best Practice introduced 2017-05-10 09:49 UTC by Report Bug Copy Issue Report It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
29			{
30			$jsonField = new JsonField('MyJsonField', new FieldList(
31			new TextField('FirstName', 'Given name'),
32			new TextField('Surname', 'Last name')
33			));
34			$jsonField->setValue($value = array(
35			'MyJsonField'=>array(
36			'FirstName' => 'Normann',
37			'Surname' => 'Lou',
38			),
39			));
40
41			$this->assertEquals($jsonField->dataValue(), Convert::array2json($value));
			0 ignored issues – show Bug introduced 2017-05-10 09:49 UTC by Report Bug Copy Issue Report The method `assertEquals()` does not seem to exist on `object<JsonFieldTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
42			$jsonField->setValue($value = array(
43			'MyJsonField'=>array(),
44			));
45			$this->assertNull($jsonField->dataValue());
			0 ignored issues – show Bug introduced 2017-05-10 09:49 UTC by Report Bug Copy Issue Report The method `assertNull()` does not seem to exist on `object<JsonFieldTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
46			}
47			}
48

silverstripe / silverstripe-dms

Pull Request — master (#119)

testJsonFieldDataValueCouldDealWithArray() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like