DMSShortcodeHandler

Complexity

Total Complexity

7

Size/Duplication

Total Lines	34
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	3

Importance

Changes

0

1 Method

Rating	Name	Duplication	Size	Complexity
B	handle()	0	31	7

<?php

/**
 * Handles replacing `dms_document_link` shortcodes with links to the actual
 * document.
 *
 * @package dms
 */
class DMSShortcodeHandler
{
    public static function handle($arguments, $content, ShortcodeParser $parser, $tag, array $extra = array())

The return type could not be reliably inferred; please add a @return annotation.

The parameter $tag is not used and could be removed.

    {
        if (!empty($arguments['id'])) {
            $document = DMSDocument::get()->byID($arguments['id']);

            if ($document && !$document->isHidden()) {
                if ($content) {
                    return sprintf(
                        '<a href="%s">%s</a>',
                        $document->Link(),
                        $parser->parse($content)
                    );
                }

                if (isset($extra['element'])) {
                    $extra['element']->setAttribute('data-ext', $document->getExtension());

The method getExtension() does not exist on DataObject. Did you maybe mean getExtensionInstance()?

                    $extra['element']->setAttribute('data-size', $document->getFileSizeFormatted());
                }

                return $document->Link();
            }
        }

        $error = ErrorPage::get()->filter('ErrorCode', '404')->First();

        if ($error) {
            return $error->Link();
        }

        return '';
    }
}