Issues in DMSDocumentCartControllerTest.php (master) - Issues in master - silverstripe/silverstripe-dms-cart - Measure and Improve Code Quality continuously with Scrutinizer

Issues (199)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

controllers/DMSDocumentCartControllerTest.php (33 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

/**
 * Class DMSDocumentCartControllerTest contains all the tests for {@link DMSDocumentCartController}
 */
class DMSDocumentCartControllerTest extends FunctionalTest
namespace YourVendor;

class YourClass { }
{
    protected static $fixture_file = 'dms-cart/tests/DMSDocumentCartTest.yml';

    /**
     * @var DMSDocumentCartController
     */
    protected $controller;

    /**
     * @var DMSDocumentCart
     */
    protected $cart;

    public function setUp()
    {
        parent::setUp();
        DMSDocumentCartController::add_extension('StubDMSDocumentCheckoutPageExtension');
        $this->controller = DMSDocumentCartController::create();
        $this->cart = $this->controller->getCart();
        $this->cart->emptyCart();
    }

    /**
     * Test the items method of the controller
     */
    public function testItems()
    {
        /** @var DMSDocument $doc1 */
        $doc1 = $this->objFromFixture('DMSDocument', 'doc1');
        /** @var DMSDocument $doc2 */
        $doc2 = $this->objFromFixture('DMSDocument', 'doc2');
        /** @var DMSRequestItem $item */
        $item1 = DMSRequestItem::create()->setDocument($doc1)->setQuantity(2);
        $item2 = DMSRequestItem::create()->setDocument($doc2)->setQuantity(5);
        $this->cart->addItem($item1);
        $this->cart->addItem($item2);
        $this->assertInstanceOf(

            'ArrayList',
            $this->controller->items(),
            'DMSDocumentCartController->Items() returned an ArrayList'
        );
        $this->assertCount(

            2,
            $this->controller->items(),
            'DMSDocumentCartController->Items()->count() returned the requisite number of items'
        );
    }

    public function testReceiverInfo()
    {
        // Now add some info
        $this->cart->setReceiverInfo(array('Name' => 'Joe', 'Surname' => 'Soap'));
        $this->assertCount(2, $this->controller->getReceiverInfo());

    }

    public function testIsCartEmpty()
    {
        $this->assertTrue($this->controller->getIsCartEmpty());

        /** @var DMSDocument $doc */
        $doc1 = $this->objFromFixture('DMSDocument', 'doc1');
        /** @var DMSRequestItem $item */
        $item1 = DMSRequestItem::create()->setDocument($doc1)->setQuantity(2);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $this->cart->addItem($item1);
        $this->assertFalse($this->controller->getIsCartEmpty());

    }

    public function testAdd()
    {
        $this->logInWithPermission();
        $doc1 = $this->objFromFixture('DMSDocument', 'doc1');
        // Check cart is initially empty
        $this->assertTrue($this->controller->getIsCartEmpty());

        // Now call controller add
        $request = new SS_HTTPRequest('POST', '', array(), array('quantity' => 5));
        $request->setRouteParams(array('ID' => $doc1->ID));
        $this->controller->add($request);
        $this->assertFalse($this->controller->getIsCartEmpty());


        // Do it again and assert quantity was updated
        $request = new SS_HTTPRequest('POST', '', array(), array('quantity' => 7));
        $request->setRouteParams(array('ID' => $doc1->ID));
        $this->controller->add($request);

        // Test ajax
        $request = new SS_HTTPRequest('POST', '', array(), array('quantity' => 7, 'ajax' => 1));
        $request->setRouteParams(array('ID' => $doc1->ID));
        $response = $this->controller->add($request);
        $this->assertTrue($request->isAjax());

        $this->assertJson($response, 'Confirmed that an ajax call to add() responded with json JSON');


        $item = $this->cart->getItem($doc1->ID);
        $this->assertEquals(19, $item->getQuantity());

    }



    public function testDeduct()
    {
        $doc1 = $this->objFromFixture('DMSDocument', 'doc1');
        // Check catty is initially empty
        $this->assertTrue($this->controller->getIsCartEmpty());

        // Now call controller add
        $request = new SS_HTTPRequest('POST', '', array(), array('quantity'=>5));
        $request->setRouteParams(array('ID' => $doc1->ID));
        $this->controller->deduct($request);
        // Assert cart still empty because item doesn't exist
        $this->assertTrue($this->controller->getIsCartEmpty());

        // Now add item
        $this->controller->add($request);
        $this->assertFalse($this->controller->getIsCartEmpty());



        // Now try and deduct 2 from the items
        $request = new SS_HTTPRequest('POST', '', array(), array('quantity' => -2));
        $request->setRouteParams(array('ID' => $doc1->ID));
        $this->controller->deduct($request);

        $item = $this->cart->getItem($doc1->ID);
        $this->assertEquals(3, $item->getQuantity());


        // Test ajax
        $request = new SS_HTTPRequest('POST', '', array(), array('quantity' => 7, 'ajax' => 1));
        $request->setRouteParams(array('ID' => $doc1->ID));
        $response = $this->controller->deduct($request);
        $this->assertTrue($request->isAjax());

        $this->assertJson($response, 'Confirmed that an ajax call to deduct() method responded with JSON');

    }

    public function testRemove()
    {
        $doc1 = $this->objFromFixture('DMSDocument', 'doc1');
        // Check catty is initially empty
        $this->assertTrue($this->controller->getIsCartEmpty());

        // Now call controller add
        $request = new SS_HTTPRequest('POST', '', array(), array('quantity'=>5));
        $request->setRouteParams(array('ID' => $doc1->ID));
        // Now add item
        $this->controller->add($request);
        $this->assertFalse($this->controller->getIsCartEmpty());

        $this->controller->remove($request);
        $this->assertTrue($this->controller->getIsCartEmpty());


        // Test ajax
        $request = new SS_HTTPRequest('POST', '', array(), array('quantity' => 7, 'ajax' => 1));
        $request->setRouteParams(array('ID' => $doc1->ID));
        $response = $this->controller->remove($request);
        $this->assertTrue($request->isAjax());

        $this->assertJson($response, 'Confirmed that  an ajax call to remove() method responded with JSON');

    }

    /**
     * Ensure that a validation error is shown when requesting to add more of a document that is allowed
     */
    public function testCannotAddMoreThanSuggestedQuantityOfItem()
    {
        $document = $this->objFromFixture('DMSDocument', 'limited_supply');
        $result = $this->get('/documentcart/add/' . $document->ID . '?quantity=5&ajax=1');
        $this->assertContains(
            'Maximum of 3 documents exceeded for \"Doc3\", please select a lower quantity.',
            (string) $result->getBody()
        );
    }

    /**
     * Ensure that multiple validation errors are returned in the failure message, if any
     */
    public function testMultipleValidationErrorsReturned()
    {
        $document1 = $this->objFromFixture('DMSDocument', 'limited_supply');
        $document2 = $this->objFromFixture('DMSDocument', 'very_limited_supply');

        $this->cart
            ->addItem(DMSRequestItem::create($document1))
            ->addItem(DMSRequestItem::create($document2));

        $input = array('ItemQuantity' => array(
            $document1->ID => 15000,
            $document2->ID => 12000
        ));

        $form = Form::create($this->controller, '', new FieldList, new FieldList);
        $result = $this->controller->updateCartItems($input, $form, new SS_HTTPRequest('POST', '/'));
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

        $this->assertContains('Maximum of 3 documents exceeded for "Doc3"', $form->Message());
        $this->assertContains('Maximum of 2 documents exceeded for "Doc5"', $form->Message());
    }

    /**
     * Ensure that when a document that cannot be added to the cart is added to the cart, a validation error is
     * returned
     */
    public function testValidationErrorReturnedOnInvalidAdd()
    {
        $document = $this->objFromFixture('DMSDocument', 'not_allowed_in_cart');
        $result = $this->get('/documentcart/add/' . $document->ID . '?ajax=1');
        $this->assertContains('You are not allowed to add this document', (string) $result->getBody());
    }

    /**
     * Tests whether the cart items are updated from the controller
     *
     * @param array $quantity
     * @param int|string $expectedCount
     * @dataProvider updateCartItemsProvider
     */
    public function testUpdateCartItems($quantity, $expectedCount)
    {
        $document = $this->objFromFixture('DMSDocument', 'doc1');
        $item = DMSRequestItem::create()->setDocument($document)->setQuantity(2);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $this->cart->addItem($item);

        $quantities = array('ItemQuantity' => array($document->ID => $quantity));

        $form = Form::create($this->controller, 'Test', FieldList::create(), FieldList::create());
        $request = new SS_HTTPRequest('POST', '');
        $response = $this->controller->updateCartItems($quantities, $form, $request);
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

        $item = $this->cart->getItem($item->getItemId());
        if (is_numeric($quantity) && $quantity <= 0) {
            $this->assertFalse($item);

        } else {
            $this->assertEquals($expectedCount, $item->getQuantity());

        }
    }

    /**
     * @return array[]
     */
    public function updateCartItemsProvider()
    {
        return array(
            // Invalid quantity, leave it unchanged
            array('non-numeric', 2),
            // Existing quantity remains the same
            array(2, 2),
            // Valid quantity increase
            array(5, 5),
            // Zero, remove it
            array(0, 0),
            // Negative, treat as zero
            array(-10, 0)
        );
    }

    /**
     * Tests DMSCartEditForm form has a FieldList
     */
    public function testDMSCartEditForm()
    {
        $form = $this->controller->DMSCartEditForm();
        $this->assertInstanceOf('FieldList', $form->Fields());

    }

    /**
     * Tests if the DMSCartEditForm is extensible
     */
    public function testDMSCartEditFormIsExtensible()
    {
        $controller = $this->controller;
        $form = $controller->DMSCartEditForm();
        $this->assertNotNull(

            $form->Fields()->fieldByName('NewTextField'),
            'DMSDocumentRequestForm() is extensible as it included the field from the extension'
        );
    }

    /**
     * Tests that the cart summary view is returned.
     */
    public function testView()
    {
        $result = $this->get('documentcart/view');
        $this->assertInstanceOf('SS_HTTPResponse', $result);

        $this->assertContains('Updating cart items', $result->getBody());
    }

    /**
     * Ensure the link is "friendly", not a class name
     */
    public function testLink()
    {
        $this->assertSame('documentcart', $this->controller->Link());

        $this->assertSame('documentcart/view', $this->controller->Link('view'));

    }

    /**
     * Ensure that the user is notified when the cart is empty
     */
    public function testEmptyCartShowsNoticeOnCheckout()
    {
        $result = $this->get('checkout');
        $this->assertContains('Your cart is currently empty.', $result->getBody());
    }
}


1			<?php
2
3			/**
4			* Class DMSDocumentCartControllerTest contains all the tests for {@link DMSDocumentCartController}
5			*/
6			class DMSDocumentCartControllerTest extends FunctionalTest
			0 ignored issues – show Coding Style Compatibility introduced 2017-05-23 04:54 UTC by Report Bug Copy Issue Report Show Similar Issues like this PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
7			{
8			protected static $fixture_file = 'dms-cart/tests/DMSDocumentCartTest.yml';
9
10			/**
11			* @var DMSDocumentCartController
12			*/
13			protected $controller;
14
15			/**
16			* @var DMSDocumentCart
17			*/
18			protected $cart;
19
20			public function setUp()
21			{
22			parent::setUp();
23			DMSDocumentCartController::add_extension('StubDMSDocumentCheckoutPageExtension');
24			$this->controller = DMSDocumentCartController::create();
25			$this->cart = $this->controller->getCart();
26			$this->cart->emptyCart();
27			}
28
29			/**
30			* Test the items method of the controller
31			*/
32			public function testItems()
33			{
34			/** @var DMSDocument $doc1 */
35			$doc1 = $this->objFromFixture('DMSDocument', 'doc1');
36			/** @var DMSDocument $doc2 */
37			$doc2 = $this->objFromFixture('DMSDocument', 'doc2');
38			/** @var DMSRequestItem $item */
39			$item1 = DMSRequestItem::create()->setDocument($doc1)->setQuantity(2);

silverstripe / silverstripe-dms-cart

Issues (199)

Security Analysis not enabled

controllers/DMSDocumentCartControllerTest.php (33 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like