DMSDocumentCartTest::testSaveSubmission() - Code Metrics - Inspection of "FIX document print counts incremented upon checkou..." - silverstripe/silverstripe-dms-cart - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#18)

by Franco

created 2017-05-25 04:50 UTC

DMSDocumentCartTest::testSaveSubmission() A

↳ Parent: DMSDocumentCartTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	16
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	16
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	10
nc	1
nop	0

<?php

/**
 * Class DMSDocumentCartTest contains all the tests for {@link DMSDocumentCart}
 */
class DMSDocumentCartTest extends SapphireTest
namespace YourVendor;

class YourClass { }
{
    protected static $fixture_file = 'DMSDocumentCartTest.yml';

    /**
     * @var DMSDocumentCart
     */
    protected $cart;

    public function setUp()
    {
        parent::setUp();
        $this->cart = singleton('DMSDocumentCart');
    }

    public function testAddItem()

    {
        $doc = $this->objFromFixture('DMSDocument', 'doc1');
        /** @var DMSRequestItem $item */
        $item = DMSRequestItem::create();
        $item->setDocument($doc)->setQuantity(2);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $this->cart->addItem($item);
        $this->assertFalse($this->cart->isCartEmpty());

    }

    public function testEmptyCart()

    {
        $doc = $this->objFromFixture('DMSDocument', 'doc1');
        /** @var DMSRequestItem $item */
        $item = DMSRequestItem::create();
        $item->setDocument($doc)->setQuantity(18);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $this->cart->addItem($item);
        $this->assertFalse($this->cart->isCartEmpty());


        $this->cart->emptyCart();
        $this->assertTrue($this->cart->isCartEmpty());

    }

    public function testGetBackend()
    {
        /** @var DMSDocumentCart $cart */
        $this->assertEquals('DMSSessionBackend', get_class($this->cart->getBackend()));

    }

    public function testGetBackURL()
    {
        $url = 'TestURL';
        $this->cart->setBackUrl($url);
        $this->assertEquals($url, $this->cart->getBackUrl());

    }

    public function testGetItem()

    {
        $doc = $this->objFromFixture('DMSDocument', 'doc1');
        /** @var DMSRequestItem $item */
        $item = DMSRequestItem::create();
        $item->setDocument($doc)->setQuantity(2);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $this->cart->addItem($item);

        $this->assertEquals($doc, $this->cart->getItem($doc->ID)->getDocument());

    }

    public function testGetItems()

    {
        $doc = $this->objFromFixture('DMSDocument', 'doc1');
        /** @var DMSRequestItem $item */
        $item = DMSRequestItem::create();
        $item->setDocument($doc)->setQuantity(2);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $this->cart->addItem($item);

        $this->assertCount(1, $this->cart->getItems());

    }

    public function testGetReceiverInfo()
    {
        $info = array('Name' => 'Jane');
        $this->cart->setReceiverInfo($info);
        $this->assertEquals($info, $this->cart->getReceiverInfo());

    }

    public function testIsCartEmpty()
    {
        $this->assertTrue($this->cart->isCartEmpty());

        $doc = $this->objFromFixture('DMSDocument', 'doc1');
        /** @var DMSRequestItem $item */
        $item = DMSRequestItem::create()->setDocument($doc)->setQuantity(2);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $this->cart->addItem($item);
        $this->assertFalse($this->cart->isCartEmpty());

    }

    public function testRemoveItem()

    {
        $this->assertTrue($this->cart->isCartEmpty());

        $doc = $this->objFromFixture('DMSDocument', 'doc1');
        /** @var DMSRequestItem $item */
        $item = DMSRequestItem::create();
        $item->setDocument($doc)->setQuantity(2);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $this->cart->addItem($item);
        $this->assertFalse($this->cart->isCartEmpty());


        $this->cart->removeItem($item);
        $this->assertTrue($this->cart->isCartEmpty());

    }

    public function testRemoveItemByID()

    {
        $this->assertTrue($this->cart->isCartEmpty());

        $doc = $this->objFromFixture('DMSDocument', 'doc1');
        /** @var DMSRequestItem $item */
        $item = DMSRequestItem::create();
        $item->setDocument($doc)->setQuantity(2);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $this->cart->addItem($item);
        $this->assertFalse($this->cart->isCartEmpty());


        $this->cart->removeItemByID($doc->ID);
        $this->assertTrue($this->cart->isCartEmpty());

    }

    public function testUpdateItemQuantity()
    {
        $doc = $this->objFromFixture('DMSDocument', 'doc1');

        // Test Update
        /** @var DMSRequestItem $item */
        $item = DMSRequestItem::create();
        $item->setDocument($doc)->setQuantity(2);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $this->cart->addItem($item);
        $this->assertEquals(2, $this->cart->getItem($doc->ID)->getQuantity());


        $this->cart->updateItemQuantity($item->getItemID(), 17);
        $this->assertEquals(19, $this->cart->getItem($doc->ID)->getQuantity());


        // Test Add
        $this->cart->updateItemQuantity($doc->ID, 16);
        $this->assertEquals(35, $this->cart->getItem($doc->ID)->getQuantity());


        // Test Deduct
        $this->cart->updateItemQuantity($doc->ID, -16);
        $this->assertEquals(19, $this->cart->getItem($doc->ID)->getQuantity());


        // Test deduct all items that it removes it
        $this->cart->updateItemQuantity($doc->ID, -19);
        $this->assertTrue($this->cart->isCartEmpty());

    }

    public function testSaveSubmission()
    {
        $page = $this->objFromFixture('DMSDocumentCartCheckoutPage', 'page1');
        /** @var DMSDocumentCartCheckoutPage_Controller $controller */
        $controller = ModelAsController::controller_for($page);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        // Form for use later
        $form = $controller->DMSDocumentRequestForm();
        $doc = $this->objFromFixture('DMSDocument', 'doc1');
        // Add some an item to the cart to assert later that its empty
        $item = DMSRequestItem::create()->setDocument($doc)->setQuantity(15);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $controller->getCart()->addItem($item);

        $submissionID = $controller->getCart()->saveSubmission($form);
        $submission = DMSDocumentCartSubmission::get()->byID($submissionID);
        $this->assertEquals(15, $submission->Items()->first()->Quantity);

    }


    public function testIsInCart()

    {
        $doc = $this->objFromFixture('DMSDocument', 'doc1');
        /** @var DMSRequestItem $item */
        $item = DMSRequestItem::create()->setDocument($doc)->setQuantity(2);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $this->assertFalse($this->cart->isInCart($item->getItemId()));

        $this->cart->addItem($item);
        $this->assertTrue($this->cart->isInCart($item->getItemId()));

    }
}


1		<?php
2
3		/**
4		* Class DMSDocumentCartTest contains all the tests for {@link DMSDocumentCart}
5		*/
6		class DMSDocumentCartTest extends SapphireTest
		0 ignored issues – show Coding Style Compatibility introduced 2017-05-23 04:54 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
7		{
8		protected static $fixture_file = 'DMSDocumentCartTest.yml';
9
10		/**
11		* @var DMSDocumentCart
12		*/
13		protected $cart;
14
15		public function setUp()
16		{
17		parent::setUp();
18		$this->cart = singleton('DMSDocumentCart');
19		}
20
21	View Code Duplication	public function testAddItem()
		0 ignored issues – show Duplication introduced 2017-05-23 04:54 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
22		{
23		$doc = $this->objFromFixture('DMSDocument', 'doc1');
24		/** @var DMSRequestItem $item */
25		$item = DMSRequestItem::create();
26		$item->setDocument($doc)->setQuantity(2);
		0 ignored issues – show Documentation introduced 2017-05-23 04:54 UTC by Report Bug Copy Issue Report `$doc` is of type `object<DataObject>\|null`, but the function expects a `object<DMSDocument>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
27		$this->cart->addItem($item);
28		$this->assertFalse($this->cart->isCartEmpty());
		0 ignored issues – show Bug introduced 2017-05-23 04:54 UTC by Report Bug Copy Issue Report The method `assertFalse()` does not seem to exist on `object<DMSDocumentCartTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
29		}
30
31	View Code Duplication	public function testEmptyCart()
		0 ignored issues – show Duplication introduced 2017-05-23 04:54 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
32		{
33		$doc = $this->objFromFixture('DMSDocument', 'doc1');
34		/** @var DMSRequestItem $item */
35		$item = DMSRequestItem::create();

silverstripe / silverstripe-dms-cart

Pull Request — master (#18)

DMSDocumentCartTest::testSaveSubmission() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like