DMSDocumentCartTest - Code Metrics - Inspection of "Merge pull request #37 from creative-commoners/pul..." - silverstripe/silverstripe-dms-cart - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 660d11...e1d670 )

by Franco

created 2017-06-07 04:16 UTC

DMSDocumentCartTest A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	199
Duplicated Lines	33.17 %

Coupling/Cohesion

Components	1
Dependencies	8

Importance

Changes

Metric	Value
wmc	16
lcom	1
cbo	8
dl	66
loc	199
rs	10
c	0
b	0
f	0

16 Methods

Rating	Name	Duplication	Size	Complexity
A	setUp()	0	5	1
A	testRemoveItem()	13	13	1
A	testRemoveItemByID()	13	13	1
A	testConstructorThrowsExceptionWhenProvidedBackendDoesNotImplementInterface()	0	4	1
A	testAddItem()	9	9	1
A	testEmptyCart()	12	12	1
A	testGetBackend()	0	4	1
A	testGetBackURL()	0	6	1
A	testGetItem()	10	10	1
A	testGetItems()	0	16	1
A	testGetReceiverInfo()	0	6	1
A	testIsCartEmpty()	0	8	1
B	testUpdateItemQuantity()	0	25	1
A	testSaveSubmission()	0	16	1
A	testIsInCart()	9	9	1
A	testGetCartSummaryCacheKey()	0	10	1

How to fix Duplicated Code

<?php

/**
 * Class DMSDocumentCartTest contains all the tests for {@link DMSDocumentCart}
 */
class DMSDocumentCartTest extends SapphireTest
namespace YourVendor;

class YourClass { }
{
    protected static $fixture_file = 'DMSDocumentCartTest.yml';

    /**
     * @var DMSDocumentCart
     */
    protected $cart;

    public function setUp()
    {
        parent::setUp();
        $this->cart = singleton('DMSDocumentCart');
    }

    /**
     * @expectedException DMSDocumentCartException
     * @expectedExceptionMessage Backend must implement DMSCartBackendInterface!
     */
    public function testConstructorThrowsExceptionWhenProvidedBackendDoesNotImplementInterface()
    {
        DMSDocumentCart::create(new DMSDocument);
    }

    public function testAddItem()

    {
        $doc = $this->objFromFixture('DMSDocument', 'doc1');

        $item = DMSRequestItem::create();
        $item->setDocument($doc)->setQuantity(2);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $this->cart->addItem($item);
        $this->assertFalse($this->cart->isCartEmpty());

    }

    public function testEmptyCart()

    {
        $doc = $this->objFromFixture('DMSDocument', 'doc1');

        $item = DMSRequestItem::create();
        $item->setDocument($doc)->setQuantity(18);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $this->cart->addItem($item);
        $this->assertFalse($this->cart->isCartEmpty());


        $this->cart->emptyCart();
        $this->assertTrue($this->cart->isCartEmpty());

    }

    public function testGetBackend()
    {
        $this->assertInstanceOf('DMSSessionBackend', $this->cart->getBackend());

    }

    public function testGetBackURL()
    {
        $url = 'TestURL';
        $this->cart->setBackUrl($url);
        $this->assertEquals($url, $this->cart->getBackUrl());

    }

    public function testGetItem()

    {
        $doc = $this->objFromFixture('DMSDocument', 'doc1');

        $item = DMSRequestItem::create();
        $item->setDocument($doc)->setQuantity(2);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $this->cart->addItem($item);

        $this->assertEquals($doc, $this->cart->getItem($doc->ID)->getDocument());

    }

    public function testGetItems()
    {
        $item = DMSRequestItem::create();
        $item->setDocument($this->objFromFixture('DMSDocument', 'doc1'))->setQuantity(2);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $this->cart->addItem($item);
        $this->assertCount(1, $this->cart->getItems());


        $item2 = DMSRequestItem::create();
        $item2->setDocument($this->objFromFixture('DMSDocument', 'limited_supply'))->setQuantity(2);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $this->cart->addItem($item2);
        $this->assertCount(2, $this->cart->getItems());


        // Edge case handling for when a document is deleted in the background
        $item2->getDocument()->delete();
        $this->assertCount(1, $this->cart->getItems());

    }

    public function testGetReceiverInfo()
    {
        $info = array('Name' => 'Jane');
        $this->cart->setReceiverInfo($info);
        $this->assertEquals($info, $this->cart->getReceiverInfo());

    }

    public function testIsCartEmpty()
    {
        $this->assertTrue($this->cart->isCartEmpty());

        $doc = $this->objFromFixture('DMSDocument', 'doc1');
        $item = DMSRequestItem::create()->setDocument($doc)->setQuantity(2);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $this->cart->addItem($item);
        $this->assertFalse($this->cart->isCartEmpty());

    }

    public function testRemoveItem()

    {
        $this->assertTrue($this->cart->isCartEmpty());

        $doc = $this->objFromFixture('DMSDocument', 'doc1');

        $item = DMSRequestItem::create();
        $item->setDocument($doc)->setQuantity(2);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $this->cart->addItem($item);
        $this->assertFalse($this->cart->isCartEmpty());


        $this->cart->removeItem($item);
        $this->assertTrue($this->cart->isCartEmpty());

    }

    public function testRemoveItemByID()

    {
        $this->assertTrue($this->cart->isCartEmpty());

        $doc = $this->objFromFixture('DMSDocument', 'doc1');

        $item = DMSRequestItem::create();
        $item->setDocument($doc)->setQuantity(2);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $this->cart->addItem($item);
        $this->assertFalse($this->cart->isCartEmpty());


        $this->cart->removeItemByID($doc->ID);
        $this->assertTrue($this->cart->isCartEmpty());

    }

    public function testUpdateItemQuantity()
    {
        $doc = $this->objFromFixture('DMSDocument', 'doc1');

        // Test Update
        $item = DMSRequestItem::create();
        $item->setDocument($doc)->setQuantity(2);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $this->cart->addItem($item);
        $this->assertEquals(2, $this->cart->getItem($doc->ID)->getQuantity());


        $this->cart->updateItemQuantity($item->getItemID(), 17);
        $this->assertEquals(19, $this->cart->getItem($doc->ID)->getQuantity());


        // Test Add
        $this->cart->updateItemQuantity($doc->ID, 16);
        $this->assertEquals(35, $this->cart->getItem($doc->ID)->getQuantity());


        // Test Deduct
        $this->cart->updateItemQuantity($doc->ID, -16);
        $this->assertEquals(19, $this->cart->getItem($doc->ID)->getQuantity());


        // Test deduct all items that it removes it
        $this->cart->updateItemQuantity($doc->ID, -19);
        $this->assertTrue($this->cart->isCartEmpty());

    }

    public function testSaveSubmission()
    {
        $controller = DMSCheckoutController::create();

        // Form for use later
        $form = $controller->DMSDocumentRequestForm();
        $doc = $this->objFromFixture('DMSDocument', 'doc1');

        // Add some an item to the cart to assert later that its empty
        $item = DMSRequestItem::create($doc)->setQuantity(15);
        $controller->getCart()->addItem($item);

        $submissionID = $controller->getCart()->saveSubmission($form);
        $submission = DMSDocumentCartSubmission::get()->byID($submissionID);
        $this->assertEquals(15, $submission->Items()->first()->Quantity);

    }


    public function testIsInCart()

    {
        $doc = $this->objFromFixture('DMSDocument', 'doc1');
        $item = DMSRequestItem::create()->setDocument($doc)->setQuantity(2);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $this->assertFalse($this->cart->isInCart($item->getItemId()));


        $this->cart->addItem($item);
        $this->assertTrue($this->cart->isInCart($item->getItemId()));

    }

    /**
     * Ensure that the cart contents are hashed an used for the cart summary cache key
     */
    public function testGetCartSummaryCacheKey()
    {
        $item = DMSRequestItem::create($this->objFromFixture('DMSDocument', 'doc1'))->setQuantity(2);
        $item2 = DMSRequestItem::create($this->objFromFixture('DMSDocument', 'limited_supply'))->setQuantity(2);

        $this->cart->addItem($item)->addItem($item2);

        $hash = md5(serialize($this->cart->getItems()));
        $this->assertContains($hash, $this->cart->getCartSummaryCacheKey());
    }
}


1		<?php
2
3		/**
4		* Class DMSDocumentCartTest contains all the tests for {@link DMSDocumentCart}
5		*/
6		class DMSDocumentCartTest extends SapphireTest
		0 ignored issues – show Coding Style Compatibility introduced 2017-05-26 03:30 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
7		{
8		protected static $fixture_file = 'DMSDocumentCartTest.yml';
9
10		/**
11		* @var DMSDocumentCart
12		*/
13		protected $cart;
14
15		public function setUp()
16		{
17		parent::setUp();
18		$this->cart = singleton('DMSDocumentCart');
19		}
20
21		/**
22		* @expectedException DMSDocumentCartException
23		* @expectedExceptionMessage Backend must implement DMSCartBackendInterface!
24		*/
25		public function testConstructorThrowsExceptionWhenProvidedBackendDoesNotImplementInterface()
26		{
27		DMSDocumentCart::create(new DMSDocument);
28		}
29
30	View Code Duplication	public function testAddItem()
		0 ignored issues – show Duplication introduced 2017-05-23 04:54 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
31		{
32		$doc = $this->objFromFixture('DMSDocument', 'doc1');
33
34		$item = DMSRequestItem::create();
35		$item->setDocument($doc)->setQuantity(2);
		0 ignored issues – show Documentation introduced 2017-05-23 04:54 UTC by Report Bug Copy Issue Report `$doc` is of type `object<DataObject>\|null`, but the function expects a `object<DMSDocument>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
36		$this->cart->addItem($item);
37		$this->assertFalse($this->cart->isCartEmpty());

silverstripe / silverstripe-dms-cart

Push — master ( 660d11...e1d670 )

DMSDocumentCartTest A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

16 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like