DMSDocumentCartSubmission

Complexity

Total Complexity

4

Size/Duplication

Total Lines	65
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	5

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	getCMSFields()	0	19	2
A	onBeforeWrite()	0	7	2

<?php

class DMSDocumentCartSubmission extends DataObject

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{
    private static $db = array(

Consider using a different property name as you override a private property of the parent class.

The property $db is not used and could be removed.

        'ReceiverName'            => 'Varchar(100)',
        'ReceiverPhone'           => 'Varchar(20)',
        'ReceiverEmail'           => 'Varchar(254)',
        'DeliveryAddressLine1'    => 'Varchar(200)',
        'DeliveryAddressLine2'    => 'Varchar(200)',
        'DeliveryAddressCountry'  => 'Varchar(50)',
        'DeliveryAddressPostCode' => 'Varchar(20)',
        'CreatedAt'               => 'Datetime',
    );

    private static $has_many = array(

Consider using a different property name as you override a private property of the parent class.

The property $has_many is not used and could be removed.

        'Items' => 'DMSDocumentCartSubmissionItem',
    );

    private static $summary_fields = array(

Consider using a different property name as you override a private property of the parent class.

The property $summary_fields is not used and could be removed.

        'ReceiverName' => 'Receiver Name',
        'ReceiverPhone' => 'Receiver Phone',
        'ReceiverEmail' => 'Receiver Email',
        'Items.Count' => 'No. Items',
        'CreatedAt.Nice' => 'Created At'
    );

    private static $singular_name = 'Cart Submission';

Consider using a different property name as you override a private property of the parent class.

The property $singular_name is not used and could be removed.

    private static $plural_name = 'Cart Submissions';

Consider using a different property name as you override a private property of the parent class.

The property $plural_name is not used and could be removed.

    /**
     * Removing the add and existing GridField components to ensure that the model admin for submissions doesn't
     * let you add new records
     *
     * @return FieldList
     */
    public function getCMSFields()
    {
        // PHP 5.3 support
        $self = $this;
        $this->beforeUpdateCMSFields(function (FieldList $fields) use ($self) {
            $fields->addFieldToTab(
                'Root.Main',
                $fields->fieldByName('Root.Main.CreatedAt')->performReadonlyTransformation()
            );

            $gridField = GridField::create('Items', null, $self->Items(), $config = new GridFieldConfig_RecordEditor);

The method Items does not exist on object<DMSDocumentCartSubmission>? Since you implemented __call, maybe consider adding a @method annotation.

            $fields->addFieldToTab('Root.Items', $gridField);

            foreach (array('GridFieldAddExistingAutocompleter', 'GridFieldAddNewButton') as $component) {
                $config->removeComponentsByType($component);
            }
        });
        return parent::getCMSFields();
    }

    /**
     * Set the created at datetime if it hasn't been set already
     */
    public function onBeforeWrite()
    {
        if (!$this->CreatedAt) {

The property CreatedAt does not seem to exist. Did you mean Created?

            $this->CreatedAt = SS_Datetime::now();

The property CreatedAt does not seem to exist. Did you mean Created?

        }
        return parent::onBeforeWrite();
    }
}