DMSDocumentCartSubmission::getCMSFields() - Code Metrics - Inspection of "Merge pull request #27 from creative-commoners/pul..." - silverstripe/silverstripe-dms-cart - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 4392d1...1f0f27 )

by Robbie

created 2017-05-30 02:33 UTC

DMSDocumentCartSubmission::getCMSFields() A

↳ Parent: DMSDocumentCartSubmission

Complexity

Conditions	2
Paths	2

Size

Total Lines	13
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	13
rs	9.4285
c	0
b	0
f	0
cc	2
eloc	7
nc	2
nop	0

<?php

class DMSDocumentCartSubmission extends DataObject
namespace YourVendor;

class YourClass { }
{
    private static $db = array(

        'ReceiverName'            => 'Varchar(100)',
        'ReceiverPhone'           => 'Varchar(20)',
        'ReceiverEmail'           => 'Varchar(254)',
        'DeliveryAddressLine1'    => 'Varchar(200)',
        'DeliveryAddressLine2'    => 'Varchar(200)',
        'DeliveryAddressCountry'  => 'Varchar(50)',
        'DeliveryAddressPostCode' => 'Varchar(20)',
    );

    private static $has_many = array(

        'Items' => 'DMSDocumentCartSubmissionItem',
    );

    private static $summary_fields = array(

        'ReceiverName' => 'Receiver Name',
        'ReceiverPhone' => 'Receiver Phone',
        'ReceiverEmail' => 'Receiver Email',
        'Items.Count' => 'No. Items'
    );

    private static $singular_name = 'Cart Submission';

    private static $plural_name = 'Cart Submissions';


    /**
     * Removing the add and existing GridField components to ensure that the model admin for submissions doesn't
     * let you add new records
     *
     * @return FieldList
     */
    public function getCMSFields()
    {
        $fields = parent::getCMSFields();

        $gridField = GridField::create('Items', null, $this->Items(), $config = new GridFieldConfig_RecordEditor);
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
        $fields->addFieldToTab('Root.Items', $gridField);

        foreach (array('GridFieldAddExistingAutocompleter', 'GridFieldAddNewButton') as $component) {
            $config->removeComponentsByType($component);
        }

        return $fields;
    }
}


1			<?php
2
3			class DMSDocumentCartSubmission extends DataObject
			0 ignored issues – show Coding Style Compatibility introduced 2017-05-24 03:31 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
4			{
5			private static $db = array(
			0 ignored issues – show Comprehensibility introduced 2017-05-24 03:31 UTC by Report Bug Copy Issue Report Consider using a different property name as you override a private property of the parent class. Loading history... Unused Code introduced 2017-05-24 03:31 UTC by Report Bug Copy Issue Report The property `$db` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
6			'ReceiverName' => 'Varchar(100)',
7			'ReceiverPhone' => 'Varchar(20)',
8			'ReceiverEmail' => 'Varchar(254)',
9			'DeliveryAddressLine1' => 'Varchar(200)',
10			'DeliveryAddressLine2' => 'Varchar(200)',
11			'DeliveryAddressCountry' => 'Varchar(50)',
12			'DeliveryAddressPostCode' => 'Varchar(20)',
13			);
14
15			private static $has_many = array(
			0 ignored issues – show Comprehensibility introduced 2017-05-24 03:31 UTC by Report Bug Copy Issue Report Consider using a different property name as you override a private property of the parent class. Loading history... Unused Code introduced 2017-05-24 03:31 UTC by Report Bug Copy Issue Report The property `$has_many` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
16			'Items' => 'DMSDocumentCartSubmissionItem',
17			);
18
19			private static $summary_fields = array(
			0 ignored issues – show Comprehensibility introduced 2017-05-26 01:27 UTC by Report Bug Copy Issue Report Consider using a different property name as you override a private property of the parent class. Loading history... Unused Code introduced 2017-05-30 02:11 UTC by Report Bug Copy Issue Report The property `$summary_fields` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
20			'ReceiverName' => 'Receiver Name',
21			'ReceiverPhone' => 'Receiver Phone',
22			'ReceiverEmail' => 'Receiver Email',
23			'Items.Count' => 'No. Items'
24			);
25
26			private static $singular_name = 'Cart Submission';
			0 ignored issues – show Comprehensibility introduced 2017-05-26 01:27 UTC by Report Bug Copy Issue Report Consider using a different property name as you override a private property of the parent class. Loading history... Unused Code introduced 2017-05-26 01:27 UTC by Report Bug Copy Issue Report The property `$singular_name` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
27			private static $plural_name = 'Cart Submissions';
			0 ignored issues – show Comprehensibility introduced 2017-05-26 01:27 UTC by Report Bug Copy Issue Report Consider using a different property name as you override a private property of the parent class. Loading history... Unused Code introduced 2017-05-26 01:27 UTC by Report Bug Copy Issue Report The property `$plural_name` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
28
29			/**
30			* Removing the add and existing GridField components to ensure that the model admin for submissions doesn't
31			* let you add new records
32			*
33			* @return FieldList
34			*/
35			public function getCMSFields()
36			{
37			$fields = parent::getCMSFields();
38
39			$gridField = GridField::create('Items', null, $this->Items(), $config = new GridFieldConfig_RecordEditor);
			0 ignored issues – show Documentation Bug introduced 2017-05-26 01:50 UTC by Report Bug Copy Issue Report The method `Items` does not exist on `object<DMSDocumentCartSubmission>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
40			$fields->addFieldToTab('Root.Items', $gridField);
41
42			foreach (array('GridFieldAddExistingAutocompleter', 'GridFieldAddNewButton') as $component) {
43			$config->removeComponentsByType($component);
44			}
45
46			return $fields;
47			}
48			}
49

silverstripe / silverstripe-dms-cart

Push — master ( 4392d1...1f0f27 )

DMSDocumentCartSubmission::getCMSFields() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like