DMSDocumentCartSubmissionItemTest::testOriginalIdFieldHasHelptip() - Code Metrics - Inspection of "API Make submission items store persistent data in..." - silverstripe/silverstripe-dms-cart - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#42)

by Robbie

created 2017-06-07 22:22 UTC

testOriginalIdFieldHasHelptip() A

↳ Parent: DMSDocumentCartSubmissionItemTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	8
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	8
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	5
nc	1
nop	0

<?php

class DMSDocumentCartSubmissionItemTest extends SapphireTest
namespace YourVendor;

class YourClass { }
{
    /**
     * Test that the default parent "submission" ID field is gone
     */
    public function testNoParentIdField()
    {
        $fields = DMSDocumentCartSubmissionItem::create()->getCMSFields();
        $this->assertNull($fields->fieldByName('DMSDocumentCartSubmissionID'));

    }

    /**
     * The "original ID" field points to the initial ID of the document that was ordered at the time it was placed.
     * This can easily change, so test that we have a helptip to say this.
     */
    public function testOriginalIdFieldHasHelptip()
    {
        $fields = DMSDocumentCartSubmissionItem::create()->getCMSFields();
        $this->assertContains(
            'The original document may have been modified',
            $fields->fieldByName('Root.Main.OriginalID')->getDescription()
        );
    }
}


1			<?php
2
3			class DMSDocumentCartSubmissionItemTest extends SapphireTest
			0 ignored issues – show Coding Style Compatibility introduced 2017-05-26 01:50 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
4			{
5			/**
6			* Test that the default parent "submission" ID field is gone
7			*/
8			public function testNoParentIdField()
9			{
10			$fields = DMSDocumentCartSubmissionItem::create()->getCMSFields();
11			$this->assertNull($fields->fieldByName('DMSDocumentCartSubmissionID'));
			0 ignored issues – show Bug introduced 2017-05-26 03:30 UTC by Report Bug Copy Issue Report The method `assertNull()` does not seem to exist on `object<DMSDocumentCartSubmissionItemTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
12			}
13
14			/**
15			* The "original ID" field points to the initial ID of the document that was ordered at the time it was placed.
16			* This can easily change, so test that we have a helptip to say this.
17			*/
18			public function testOriginalIdFieldHasHelptip()
19			{
20			$fields = DMSDocumentCartSubmissionItem::create()->getCMSFields();
21			$this->assertContains(
22			'The original document may have been modified',
23			$fields->fieldByName('Root.Main.OriginalID')->getDescription()
24			);
25			}
26			}
27

silverstripe / silverstripe-dms-cart

Pull Request — master (#42)

testOriginalIdFieldHasHelptip() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like