Issues in SiteTreeContentReviewTest.php (master) - Issues in master - silverstripe/silverstripe-contentreview - Measure and Improve Code Quality continuously with Scrutinizer

Issues (93)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

tests/php/SiteTreeContentReviewTest.php (26 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace SilverStripe\ContentReview\Tests;

use Page;
use SilverStripe\CMS\Controllers\CMSPageEditController;
use SilverStripe\CMS\Model\SiteTree;
use SilverStripe\ContentReview\Extensions\SiteTreeContentReview;
use SilverStripe\ContentReview\Extensions\ContentReviewOwner;
use SilverStripe\ContentReview\Extensions\ContentReviewCMSExtension;
use SilverStripe\ContentReview\Extensions\ContentReviewDefaultSettings;
use SilverStripe\Forms\LiteralField;
use SilverStripe\Security\Group;
use SilverStripe\Security\Member;
use SilverStripe\SiteConfig\SiteConfig;
use SilverStripe\ORM\FieldType\DBDatetime;
use SilverStripe\Versioned\Versioned;

/**
 * @mixin PHPUnit_Framework_TestCase
 */
class SiteTreeContentReviewTest extends ContentReviewBaseTest
{
    /**
     * @var string
     */
    protected static $fixture_file = 'ContentReviewTest.yml';

    /**
     * @var array
     */
    protected static $required_extensions = [
        SiteTree::class              => [SiteTreeContentReview::class],
        Group::class                 => [ContentReviewOwner::class],
        Member::class                => [ContentReviewOwner::class],
        CMSPageEditController::class => [ContentReviewCMSExtension::class],
        SiteConfig::class            => [ContentReviewDefaultSettings::class],
    ];

    public function testOwnerNames()
    {
        /** @var Member $editor */
        $editor = $this->objFromFixture(Member::class, "editor");

        $this->logInAs($editor);

        /** @var Page|SiteTreeContentReview $page */
        $page = new Page();
        $page->ReviewPeriodDays = 10;
        $page->ContentReviewType = "Custom";

        $page->ContentReviewUsers()->push($editor);
        $page->write();


        $this->assertTrue($page->canPublish());

        $this->assertTrue($page->doPublish());

        $this->assertEquals($page->OwnerNames, "Test Editor", "Test Editor should be the owner");

        /** @var Page|SiteTreeContentReview $page */
        $page = $this->objFromFixture(Page::class, "about");

        $page->OwnerUsers()->removeAll();
        $page->write();


        $this->assertTrue($page->canPublish());

        $this->assertTrue($page->doPublish());

        $this->assertEquals("", $page->OwnerNames);
    }

    public function testPermissionsExists()
    {
        $perms = singleton(SiteTreeContentReview::class)->providePermissions();

        $this->assertTrue(isset($perms["EDIT_CONTENT_REVIEW_FIELDS"]));
    }

    public function testUserWithPermissionCanEdit()

    {
        /** @var Member $editor */
        $editor = $this->objFromFixture(Member::class, "editor");

        $this->logInAs($editor);

        /** @var Page|SiteTreeContentReview $page */
        $page = new Page();

        $fields = $page->getSettingsFields();


        $this->assertNotNull($fields->dataFieldByName("NextReviewDate"));
    }

    public function testUserWithoutPermissionCannotEdit()

    {
        /** @var Member $author */
        $author = $this->objFromFixture(Member::class, "author");

        $this->logInAs($author);

        /** @var Page|SiteTreeContentReview $page */
        $page = new Page();

        $fields = $page->getSettingsFields();


        $this->assertNull($fields->dataFieldByName("NextReviewDate"));
    }

    public function testAutomaticallyToNotSetReviewDate()
    {
        /** @var Member $editor */
        $editor = $this->objFromFixture(Member::class, "editor");

        $this->logInAs($editor);

        /** @var Page|SiteTreeContentReview $page */
        $page = new Page();

        $page->ReviewPeriodDays = 10;
        $page->write();


        $this->assertTrue($page->doPublish());

        $this->assertEquals(null, $page->NextReviewDate);
    }

    public function testAddReviewNote()
    {
        /** @var Member $author */
        $author = $this->objFromFixture(Member::class, "author");

        /** @var Page|SiteTreeContentReview $page */
        $page = $this->objFromFixture(Page::class, "home");

        $page->addReviewNote($author, "This is a message");

        /** @var Page|SiteTreeContentReview $page */
        $homepage = $this->objFromFixture(Page::class, "home");

        $this->assertEquals(1, $homepage->ReviewLogs()->count());
        $this->assertEquals("This is a message", $homepage->ReviewLogs()->first()->Note);
    }

    public function testGetContentReviewOwners()
    {
        /** @var Page|SiteTreeContentReview $page */
        $page = $this->objFromFixture(Page::class, "group-owned");

        $owners = $page->ContentReviewOwners();

        $this->assertEquals(1, $owners->count());
        $this->assertEquals("[email protected]", $owners->first()->Email);
    }

    public function testCanNotBeReviewBecauseNoReviewDate()

    {
        DBDatetime::set_mock_now("2010-01-01 12:00:00");

        /** @var Member $author */
        $author = $this->objFromFixture(Member::class, "author");

        /** @var Page|SiteTreeContentReview $page */
        $page = $this->objFromFixture(Page::class, "no-review");

        $this->assertFalse($page->canBeReviewedBy($author));

        DBDatetime::clear_mock_now();
    }

    public function testCanNotBeReviewedBecauseInFuture()

    {
        DBDatetime::set_mock_now("2010-01-01 12:00:00");

        /** @var Member $author */
        $author = $this->objFromFixture(Member::class, "author");

        /** @var Page|SiteTreeContentReview $page */
        $page = $this->objFromFixture(Page::class, "staff");

        $this->assertFalse($page->canBeReviewedBy($author));

        DBDatetime::clear_mock_now();
    }

    public function testCanNotBeReviewedByUser()

    {
        DBDatetime::set_mock_now("2010-03-01 12:00:00");

        /** @var Member $author */
        $author = $this->objFromFixture(Member::class, "author");

        /** @var Page|SiteTreeContentReview $page */
        $page = $this->objFromFixture(Page::class, "home");

        $this->assertFalse($page->canBeReviewedBy($author));

        DBDatetime::clear_mock_now();
    }

    public function testCanBeReviewedByUser()

    {
        DBDatetime::set_mock_now("2010-03-01 12:00:00");

        /** @var Member $author */
        $author = $this->objFromFixture(Member::class, "author");

        /** @var Page|SiteTreeContentReview $page */
        $page = $this->objFromFixture(Page::class, "staff");

        $this->assertTrue($page->canBeReviewedBy($author));

        DBDatetime::clear_mock_now();
    }

    public function testCanNotBeReviewedByGroup()

    {
        DBDatetime::set_mock_now("2010-03-01 12:00:00");

        /** @var Member $author */
        $author = $this->objFromFixture(Member::class, "editor");

        /** @var Page|SiteTreeContentReview $page */
        $page = $this->objFromFixture(Page::class, "contact");

        $this->assertFalse($page->canBeReviewedBy($author));

        DBDatetime::clear_mock_now();
    }

    public function testCanBeReviewedByGroup()

    {
        DBDatetime::set_mock_now("2010-03-01 12:00:00");

        /** @var Member $author */
        $author = $this->objFromFixture(Member::class, "author");

        /** @var Page|SiteTreeContentReview $page */
        $page = $this->objFromFixture(Page::class, "contact");

        $this->assertTrue($page->canBeReviewedBy($author));

        DBDatetime::clear_mock_now();
    }

    public function testCanBeReviewedFromInheritedSetting()

    {
        DBDatetime::set_mock_now("2013-03-01 12:00:00");

        /** @var Member $author */
        $author = $this->objFromFixture(Member::class, "author");

        /** @var Page|SiteTreeContentReview $parentPage */
        $parentPage = $this->objFromFixture(Page::class, "contact");

        $parentPage->NextReviewDate = "2013-01-01";
        $parentPage->write();


        /** @var Page|SiteTreeContentReview $page */
        $page = $this->objFromFixture(Page::class, "contact-child");

        $this->assertTrue($page->canBeReviewedBy($author));

        DBDatetime::clear_mock_now();
    }

    public function testUnModifiedPagesDontChangeEditor()
    {
        DBDatetime::set_mock_now("2013-03-01 12:00:00");

        /** @var Member $author */
        $author = $this->objFromFixture(Member::class, "author");
        $this->logInAs($author);

        // Page which is un-modified doesn't advance version of have an editor assigned
        $contactPage = $this->objFromFixture(Page::class, "contact");
        $contactPageVersion = $contactPage->Version;
        $contactPage->write();
        $this->assertEmpty($contactPage->LastEditedByName);

        $this->assertEquals(
            $contactPageVersion,
            Versioned::get_versionnumber_by_stage(SiteTree::class, 'Stage', $contactPage->ID, false)
        );

        // Page with modifications gets marked
        $homePage = $this->objFromFixture(Page::class, "home");
        $homePageVersion = $homePage->Version;
        $homePage->Content = '<p>Welcome!</p>';
        $homePage->write();
        $this->assertNotEmpty($homePage->LastEditedByName);

        $this->assertEquals($author->getTitle(), $homePage->LastEditedByName);

        $this->assertGreaterThan(
            $homePageVersion,
            Versioned::get_versionnumber_by_stage(SiteTree::class, 'Stage', $homePage->ID, false)
        );

        DBDatetime::clear_mock_now();
    }

    public function testReviewActionVisibleForAuthor()
    {
        DBDatetime::set_mock_now('2020-03-01 12:00:00');

        /** @var Page|SiteTreeContentReview $page */
        $page = $this->objFromFixture(Page::class, 'contact');

        /** @var Member $author */
        $author = $this->objFromFixture(Member::class, 'author');

        $this->logInAs($author);

        $fields = $page->getCMSActions();


        $this->assertInstanceOf(LiteralField::class, $fields->fieldByName('ContentReviewButton'));

        DBDatetime::clear_mock_now();
    }

    public function testReviewActionNotVisibleForEditor()

    {
        DBDatetime::set_mock_now("2020-03-01 12:00:00");

        /** @var Page|SiteTreeContentReview $page */
        $page = $this->objFromFixture(Page::class, "contact");

        /** @var Member $author */
        $author = $this->objFromFixture(Member::class, "editor");

        $this->logInAs($author);

        $fields = $page->getCMSActions();


        $this->assertNull($fields->fieldByName("ActionMenus.ReviewContent"));

        DBDatetime::clear_mock_now();
    }

    public function testSiteConfigSettingsAreUsedAsDefaults()
    {
        DBDatetime::set_mock_now("2020-03-01 12:00:00");

        /** @var Member $author */
        $author = $this->objFromFixture(Member::class, 'editor');

        /** @var SiteConfig $siteConfig */
        $siteConfig = SiteConfig::current_site_config();

        // Set the author to a default user for reviewing
        $siteConfig->OwnerUsers()->add($author);

        $emptyPage = new Page;
        $emptyPage->NextReviewDate = '2020-02-20 12:00:00';

        $this->assertTrue($emptyPage->canBeReviewedBy($author));

        DBDatetime::clear_mock_now();
    }
}


1			<?php
2
3			namespace SilverStripe\ContentReview\Tests;
4
5			use Page;
6			use SilverStripe\CMS\Controllers\CMSPageEditController;
7			use SilverStripe\CMS\Model\SiteTree;
8			use SilverStripe\ContentReview\Extensions\SiteTreeContentReview;
9			use SilverStripe\ContentReview\Extensions\ContentReviewOwner;
10			use SilverStripe\ContentReview\Extensions\ContentReviewCMSExtension;
11			use SilverStripe\ContentReview\Extensions\ContentReviewDefaultSettings;
12			use SilverStripe\Forms\LiteralField;
13			use SilverStripe\Security\Group;
14			use SilverStripe\Security\Member;
15			use SilverStripe\SiteConfig\SiteConfig;
16			use SilverStripe\ORM\FieldType\DBDatetime;
17			use SilverStripe\Versioned\Versioned;
18
19			/**
20			* @mixin PHPUnit_Framework_TestCase
21			*/
22			class SiteTreeContentReviewTest extends ContentReviewBaseTest
23			{
24			/**
25			* @var string
26			*/
27			protected static $fixture_file = 'ContentReviewTest.yml';
28
29			/**
30			* @var array
31			*/
32			protected static $required_extensions = [
33			SiteTree::class => [SiteTreeContentReview::class],
34			Group::class => [ContentReviewOwner::class],
35			Member::class => [ContentReviewOwner::class],
36			CMSPageEditController::class => [ContentReviewCMSExtension::class],
37			SiteConfig::class => [ContentReviewDefaultSettings::class],
38			];
39
40			public function testOwnerNames()

silverstripe / silverstripe-contentreview

Issues (93)

Security Analysis not enabled

tests/php/SiteTreeContentReviewTest.php (26 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like