Issues in ContentReviewSettingsTest.php (master) - Issues in master - silverstripe/silverstripe-contentreview - Measure and Improve Code Quality continuously with Scrutinizer

Issues (93)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

tests/php/ContentReviewSettingsTest.php (14 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace SilverStripe\ContentReview\Tests;

use Page;
use SilverStripe\CMS\Controllers\CMSPageEditController;
use SilverStripe\CMS\Model\SiteTree;
use SilverStripe\ContentReview\Extensions\ContentReviewCMSExtension;
use SilverStripe\ContentReview\Extensions\ContentReviewDefaultSettings;
use SilverStripe\ContentReview\Extensions\ContentReviewOwner;
use SilverStripe\ContentReview\Extensions\SiteTreeContentReview;
use SilverStripe\Dev\SapphireTest;
use SilverStripe\ORM\DataObject;
use SilverStripe\ORM\FieldType\DBDate;
use SilverStripe\ORM\FieldType\DBDatetime;
use SilverStripe\Security\Group;
use SilverStripe\Security\Member;
use SilverStripe\SiteConfig\SiteConfig;

/**
 * This class tests that settings are inherited correctly based on the inherited,
 * custom or disabled settings.
 *
 * @mixin PHPUnit_Framework_TestCase
 */
class ContentReviewSettingsTest extends SapphireTest
{
    /**
     * @var string
     */
    protected static $fixture_file = 'ContentReviewSettingsTest.yml';

    /**
     * @var array
     */
    protected static $required_extensions = [
        SiteTree::class              => [SiteTreeContentReview::class],
        Group::class                 => [ContentReviewOwner::class],
        Member::class                => [ContentReviewOwner::class],
        CMSPageEditController::class => [ContentReviewCMSExtension::class],
        SiteConfig::class            => [ContentReviewDefaultSettings::class],
    ];

    public function testAdvanceReviewDate10Days()
    {
        /** @var Page|SiteTreeContentReview $page */
        $page = new Page();

        $page->ContentReviewType = "Custom";
        $page->ReviewPeriodDays = 10;

        $this->assertTrue($page->advanceReviewDate());

        $page->write();


        $this->assertEquals(date('Y-m-d', strtotime("now + 10 days")), $page->NextReviewDate);
    }

    public function testAdvanceReviewDateNull()
    {
        /** @var Page|SiteTreeContentReview $page */
        $page = new Page();

        $page->ContentReviewType = "Custom";
        $page->ReviewPeriodDays = 0;

        $this->assertFalse($page->advanceReviewDate());

        $page->write();


        $this->assertEquals(null, $page->NextReviewDate);
    }

    public function testAdvanceReviewFromCustomSettings()

    {
        /** @var Page|SiteTreeContentReview $page */
        $page = $this->objFromFixture(Page::class, "custom");

        $this->assertTrue($page->advanceReviewDate());

        $page->write();


        $this->assertEquals(date('Y-m-d', strtotime("now + " . $page->ReviewPeriodDays . " days")), $page->NextReviewDate);
    }

    public function testAdvanceReviewFromInheritedSettings()
    {
        // When a parent page is advanced, the next review date of the child is not automatically advanced
        $parentPage = $this->objFromFixture(Page::class, "page-1");
        $this->assertTrue($parentPage->advanceReviewDate());
        $parentPage->write();

        $page = $this->objFromFixture(Page::class, "page-1-1");
        $this->assertEquals(date('Y-m-d', strtotime("now + 5 days")), $parentPage->NextReviewDate);
        $this->assertEquals('2011-04-12', $page->NextReviewDate);

        // When a sub page is advanced, the next review date is advanced by the number of days in the parent
        $this->assertTrue($page->advanceReviewDate());
        $page->write();
        $this->assertEquals(date('Y-m-d', strtotime("now + 5 days")), $page->NextReviewDate);
    }

    public function testAdvanceReviewFromInheritedSiteConfigSettings()

    {
        /** @var Page|SiteTreeContentReview $page */
        $page = $this->objFromFixture(Page::class, "inherit");

        /** @var SiteConfig|ContentReviewDefaultSettings $siteConfig */
        $siteConfig = $this->objFromFixture(SiteConfig::class, "default");

        $this->assertTrue($page->advanceReviewDate());

        $page->write();


        $this->assertEquals(date('Y-m-d', strtotime("now + " . $siteConfig->ReviewPeriodDays . " days")), $page->NextReviewDate);
    }

    public function testGetSettingsObjectFromCustom()

    {
        /** @var Page|SiteTreeContentReview $page */
        $page = $this->objFromFixture(Page::class, "custom");

        $this->assertEquals("Custom", $page->ContentReviewType);
        $this->assertEquals($page, $page->getOptions());
    }

    public function testGetSettingsObjectFromDisabled()

    {
        /** @var Page|SiteTreeContentReview $page */
        $page = $this->objFromFixture(Page::class, "disabled");

        $this->assertEquals("Disabled", $page->ContentReviewType);
        $this->assertFalse($page->getOptions());
    }

    public function testGetOptionObjectFromInheritedDisabled()

    {
        /** @var Page|SiteTreeContentReview $page */
        $page = $this->objFromFixture(Page::class, "page-2-1-1");

        $this->assertEquals("Inherit", $page->ContentReviewType);
        $this->assertFalse($page->getOptions());
    }

    public function testGetOptionObjectFromDeeplyInheritedPage()

    {
        /** @var Page|SiteTreeContentReview $page */
        $page = $this->objFromFixture(Page::class, "page-3-1-1-1");

        $this->assertEquals("Inherit", $page->ContentReviewType);
        $this->assertInstanceOf(SiteConfig::class, $page->getOptions());
    }

    public function testGetSettingsObjectFromInheritPage()
    {
        /** @var Page|SiteTreeContentReview $page */
        $page = $this->objFromFixture(Page::class, "page-1-1");

        /** @var Page|SiteTreeContentReview $parentPage */
        $parentPage = $this->objFromFixture(Page::class, "page-1");

        $this->assertEquals("Inherit", $page->ContentReviewType);
        $this->assertEquals(get_class($parentPage), get_class($page->getOptions()));
        $this->assertEquals($parentPage->ID, $page->getOptions()->ID);
    }

    public function testGetSettingsObjectFromInheritedRootPage()

    {
        /** @var Page|SiteTreeContentReview $page */
        $page = $this->objFromFixture(Page::class, "inherit");

        $this->assertEquals("Inherit", $page->ContentReviewType);
        $this->assertEquals($this->objFromFixture(SiteConfig::class, "default")->ID, $page->getOptions()->ID);
    }

    public function testGetNextReviewDateFromCustomSettings()
    {
        /** @var Page|SiteTreeContentReview $page */
        $page = $this->objFromFixture(Page::class, 'custom');

        $date = $page->getReviewDate();

        $this->assertEquals('2010-02-01', $date->format('Y-MM-dd'));
    }

    public function testGetNextReviewDateFromSiteConfigInheritedSetting()
    {
        /** @var Page|SiteTreeContentReview $page */
        $page = $this->objFromFixture(Page::class, "inherit");

        $nextReviewDate = $page->getReviewDate();

        $this->assertInstanceOf(DBDate::class, $nextReviewDate);

        /** @var SiteConfig|ContentReviewDefaultSettings $siteConfig */
        $siteConfig = $this->objFromFixture(SiteConfig::class, "default");

        $expected = $this->addDaysToDate(DBDatetime::now(), $siteConfig->ReviewPeriodDays);

        $this->assertEquals($expected, $nextReviewDate->format('Y-MM-dd'));
    }

    public function testGetNextReviewDateFromPageInheritedSetting()
    {
        // Although page-1-1 inherits from page-1, it has an independent review date
        $page = $this->objFromFixture(Page::class, "page-1-1");
        $nextReviewDate = $page->getReviewDate();
        $this->assertInstanceOf(DBDate::class, $nextReviewDate);
        $this->assertEquals('2011-04-12', $nextReviewDate->format('Y-MM-dd'));
    }

    public function testUpdateNextReviewDateFromCustomToDisabled()
    {
        /** @var Page|SiteTreeContentReview $page */
        $page = $this->objFromFixture(Page::class, "custom");

        // before write()
        $this->assertEquals("2010-02-01", $page->NextReviewDate);

        $page->ContentReviewType = "Disabled";
        $page->write();


        DataObject::flush_and_destroy_cache();
        unset($page);

        /** @var Page|SiteTreeContentReview $page */
        $page = $this->objFromFixture(Page::class, "custom");

        $this->assertNull($page->NextReviewDate);
    }

    public function testUpdateNextReviewDateFromDisabledToCustom()
    {
        /** @var Page|SiteTreeContentReview $page */
        $page = $this->objFromFixture(Page::class, "disabled");

        $this->assertNull($page->NextReviewDate);

        $page->ContentReviewType = "Custom";
        $page->ReviewPeriodDays = "7";
        $page->write();


        DataObject::flush_and_destroy_cache();
        unset($page);

        /** @var Page|SiteTreeContentReview $page */
        $page = $this->objFromFixture(Page::class, "disabled");

        $expected = date('Y-m-d', strtotime("+ " . $page->ReviewPeriodDays . " days"));

        $this->assertEquals($expected, $page->NextReviewDate);
    }

    public function testParentChangedOptionsAndChildShouldToo()
    {
        /** @var Page|SiteTreeContentReview $parentPage */
        $parentPage = $this->objFromFixture(Page::class, "page-1");

        /** @var Page|SiteTreeContentReview $childPage */
        $childPage = $this->objFromFixture(Page::class, "page-1-1");

        // Parent and child pages have different review dates
        $this->assertNotEquals($parentPage->NextReviewDate, $childPage->NextReviewDate);

        // But if we change the parent page ReviewPeriodDays to 10, the childs stays the same
        $parentPage->ReviewPeriodDays = 10;
        $parentPage->write();


        // Flush all the caches!
        DataObject::flush_and_destroy_cache();

        /** @var Page|SiteTreeContentReview $page */
        $parentPage = $this->objFromFixture(Page::class, "page-1");

        /** @var Page|SiteTreeContentReview $page */
        $childPage = $this->objFromFixture(Page::class, "page-1-1");

        // The parent page's date advances, but not the child's
        $this->assertEquals('2011-04-12', $childPage->NextReviewDate);
        $this->assertEquals($this->addDaysToDate(date('Y-m-d'), 10), $parentPage->NextReviewDate);

        // Reviewing the child page should, however, advance its review by 10 days
        $childPage->advanceReviewDate();
        $childPage->write();
        $this->assertEquals($this->addDaysToDate(date('Y-m-d'), 10), $childPage->NextReviewDate);
    }

    /**
     * Note: all input dates should be DBDatetime or strings in CLDR date format. See {@link DBDate} for information
     *
     * @param string|DBDatetime $date
     * @param int               $days
     * @param string            $format
     *
     * @return bool|string
     */
    private function addDaysToDate($date, $days, $format = 'Y-MM-dd')
    {
        if (is_object($date)) {
            $sec = strtotime("+ " . $days . " days", $date->getTimestamp());
        } else {
            $sec = strtotime("+ " . $days . " days", DBDate::create()->setValue($date)->getTimestamp());
        }

        return DBDate::create()->setValue($sec)->format($format);
    }
}


1		<?php
2
3		namespace SilverStripe\ContentReview\Tests;
4
5		use Page;
6		use SilverStripe\CMS\Controllers\CMSPageEditController;
7		use SilverStripe\CMS\Model\SiteTree;
8		use SilverStripe\ContentReview\Extensions\ContentReviewCMSExtension;
9		use SilverStripe\ContentReview\Extensions\ContentReviewDefaultSettings;
10		use SilverStripe\ContentReview\Extensions\ContentReviewOwner;
11		use SilverStripe\ContentReview\Extensions\SiteTreeContentReview;
12		use SilverStripe\Dev\SapphireTest;
13		use SilverStripe\ORM\DataObject;
14		use SilverStripe\ORM\FieldType\DBDate;
15		use SilverStripe\ORM\FieldType\DBDatetime;
16		use SilverStripe\Security\Group;
17		use SilverStripe\Security\Member;
18		use SilverStripe\SiteConfig\SiteConfig;
19
20		/**
21		* This class tests that settings are inherited correctly based on the inherited,
22		* custom or disabled settings.
23		*
24		* @mixin PHPUnit_Framework_TestCase
25		*/
26		class ContentReviewSettingsTest extends SapphireTest
27		{
28		/**
29		* @var string
30		*/
31		protected static $fixture_file = 'ContentReviewSettingsTest.yml';
32
33		/**
34		* @var array
35		*/
36		protected static $required_extensions = [
37		SiteTree::class => [SiteTreeContentReview::class],
38		Group::class => [ContentReviewOwner::class],
39		Member::class => [ContentReviewOwner::class],
40		CMSPageEditController::class => [ContentReviewCMSExtension::class],
41		SiteConfig::class => [ContentReviewDefaultSettings::class],
42		];
43
44		public function testAdvanceReviewDate10Days()
45		{
46		/** @var Page\|SiteTreeContentReview $page */
47		$page = new Page();
48
49		$page->ContentReviewType = "Custom";
50		$page->ReviewPeriodDays = 10;
51
52		$this->assertTrue($page->advanceReviewDate());
53
54		$page->write();
		0 ignored issues – show Bug introduced 2017-09-12 02:15 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `write()` does not seem to exist on `object<SilverStripe\Cont...\SiteTreeContentReview>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
55
56		$this->assertEquals(date('Y-m-d', strtotime("now + 10 days")), $page->NextReviewDate);
57		}
58
59		public function testAdvanceReviewDateNull()
60		{
61		/** @var Page\|SiteTreeContentReview $page */
62		$page = new Page();
63
64		$page->ContentReviewType = "Custom";
65		$page->ReviewPeriodDays = 0;
66
67		$this->assertFalse($page->advanceReviewDate());
68
69		$page->write();
		0 ignored issues – show Bug introduced 2017-09-12 02:15 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `write()` does not seem to exist on `object<SilverStripe\Cont...\SiteTreeContentReview>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
70
71		$this->assertEquals(null, $page->NextReviewDate);
72		}
73
74	View Code Duplication	public function testAdvanceReviewFromCustomSettings()
		0 ignored issues – show Duplication introduced 2017-08-22 22:05 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
75		{
76		/** @var Page\|SiteTreeContentReview $page */
77		$page = $this->objFromFixture(Page::class, "custom");
78
79		$this->assertTrue($page->advanceReviewDate());
80
81		$page->write();
		0 ignored issues – show Bug introduced 2017-09-12 02:15 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `write()` does not seem to exist on `object<SilverStripe\Cont...\SiteTreeContentReview>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
82
83		$this->assertEquals(date('Y-m-d', strtotime("now + " . $page->ReviewPeriodDays . " days")), $page->NextReviewDate);
84		}
85
86		public function testAdvanceReviewFromInheritedSettings()
87		{
88		// When a parent page is advanced, the next review date of the child is not automatically advanced
89		$parentPage = $this->objFromFixture(Page::class, "page-1");
90		$this->assertTrue($parentPage->advanceReviewDate());
91		$parentPage->write();
92
93		$page = $this->objFromFixture(Page::class, "page-1-1");
94		$this->assertEquals(date('Y-m-d', strtotime("now + 5 days")), $parentPage->NextReviewDate);
95		$this->assertEquals('2011-04-12', $page->NextReviewDate);
96
97		// When a sub page is advanced, the next review date is advanced by the number of days in the parent
98		$this->assertTrue($page->advanceReviewDate());
99		$page->write();
100		$this->assertEquals(date('Y-m-d', strtotime("now + 5 days")), $page->NextReviewDate);
101		}
102
103	View Code Duplication	public function testAdvanceReviewFromInheritedSiteConfigSettings()
		0 ignored issues – show Duplication introduced 2017-08-22 22:05 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
104		{
105		/** @var Page\|SiteTreeContentReview $page */
106		$page = $this->objFromFixture(Page::class, "inherit");
107
108		/** @var SiteConfig\|ContentReviewDefaultSettings $siteConfig */
109		$siteConfig = $this->objFromFixture(SiteConfig::class, "default");
110
111		$this->assertTrue($page->advanceReviewDate());
112
113		$page->write();
		0 ignored issues – show Bug introduced 2017-09-12 02:15 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `write()` does not seem to exist on `object<SilverStripe\Cont...\SiteTreeContentReview>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
114
115		$this->assertEquals(date('Y-m-d', strtotime("now + " . $siteConfig->ReviewPeriodDays . " days")), $page->NextReviewDate);
116		}
117
118	View Code Duplication	public function testGetSettingsObjectFromCustom()
		0 ignored issues – show Duplication introduced 2017-08-22 22:05 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
119		{
120		/** @var Page\|SiteTreeContentReview $page */
121		$page = $this->objFromFixture(Page::class, "custom");
122
123		$this->assertEquals("Custom", $page->ContentReviewType);
124		$this->assertEquals($page, $page->getOptions());
125		}
126
127	View Code Duplication	public function testGetSettingsObjectFromDisabled()
		0 ignored issues – show Duplication introduced 2017-09-06 05:13 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
128		{
129		/** @var Page\|SiteTreeContentReview $page */
130		$page = $this->objFromFixture(Page::class, "disabled");
131
132		$this->assertEquals("Disabled", $page->ContentReviewType);
133		$this->assertFalse($page->getOptions());
134		}
135
136	View Code Duplication	public function testGetOptionObjectFromInheritedDisabled()
		0 ignored issues – show Duplication introduced 2017-09-06 05:13 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
137		{
138		/** @var Page\|SiteTreeContentReview $page */
139		$page = $this->objFromFixture(Page::class, "page-2-1-1");
140
141		$this->assertEquals("Inherit", $page->ContentReviewType);
142		$this->assertFalse($page->getOptions());
143		}
144
145	View Code Duplication	public function testGetOptionObjectFromDeeplyInheritedPage()
		0 ignored issues – show Duplication introduced 2017-08-22 22:05 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
146		{
147		/** @var Page\|SiteTreeContentReview $page */
148		$page = $this->objFromFixture(Page::class, "page-3-1-1-1");
149
150		$this->assertEquals("Inherit", $page->ContentReviewType);
151		$this->assertInstanceOf(SiteConfig::class, $page->getOptions());
152		}
153
154		public function testGetSettingsObjectFromInheritPage()
155		{
156		/** @var Page\|SiteTreeContentReview $page */
157		$page = $this->objFromFixture(Page::class, "page-1-1");
158
159		/** @var Page\|SiteTreeContentReview $parentPage */
160		$parentPage = $this->objFromFixture(Page::class, "page-1");
161
162		$this->assertEquals("Inherit", $page->ContentReviewType);
163		$this->assertEquals(get_class($parentPage), get_class($page->getOptions()));
164		$this->assertEquals($parentPage->ID, $page->getOptions()->ID);
165		}
166
167	View Code Duplication	public function testGetSettingsObjectFromInheritedRootPage()
		0 ignored issues – show Duplication introduced 2017-09-06 05:13 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
168		{
169		/** @var Page\|SiteTreeContentReview $page */
170		$page = $this->objFromFixture(Page::class, "inherit");
171
172		$this->assertEquals("Inherit", $page->ContentReviewType);
173		$this->assertEquals($this->objFromFixture(SiteConfig::class, "default")->ID, $page->getOptions()->ID);
174		}
175
176		public function testGetNextReviewDateFromCustomSettings()
177		{
178		/** @var Page\|SiteTreeContentReview $page */
179		$page = $this->objFromFixture(Page::class, 'custom');
180
181		$date = $page->getReviewDate();
182
183		$this->assertEquals('2010-02-01', $date->format('Y-MM-dd'));
184		}
185
186		public function testGetNextReviewDateFromSiteConfigInheritedSetting()
187		{
188		/** @var Page\|SiteTreeContentReview $page */
189		$page = $this->objFromFixture(Page::class, "inherit");
190
191		$nextReviewDate = $page->getReviewDate();
192
193		$this->assertInstanceOf(DBDate::class, $nextReviewDate);
194
195		/** @var SiteConfig\|ContentReviewDefaultSettings $siteConfig */
196		$siteConfig = $this->objFromFixture(SiteConfig::class, "default");
197
198		$expected = $this->addDaysToDate(DBDatetime::now(), $siteConfig->ReviewPeriodDays);
199
200		$this->assertEquals($expected, $nextReviewDate->format('Y-MM-dd'));
201		}
202
203		public function testGetNextReviewDateFromPageInheritedSetting()
204		{
205		// Although page-1-1 inherits from page-1, it has an independent review date
206		$page = $this->objFromFixture(Page::class, "page-1-1");
207		$nextReviewDate = $page->getReviewDate();
208		$this->assertInstanceOf(DBDate::class, $nextReviewDate);
209		$this->assertEquals('2011-04-12', $nextReviewDate->format('Y-MM-dd'));
210		}
211
212		public function testUpdateNextReviewDateFromCustomToDisabled()
213		{
214		/** @var Page\|SiteTreeContentReview $page */
215		$page = $this->objFromFixture(Page::class, "custom");
216
217		// before write()
218		$this->assertEquals("2010-02-01", $page->NextReviewDate);
219
220		$page->ContentReviewType = "Disabled";
221		$page->write();
		0 ignored issues – show Bug introduced 2017-09-12 02:15 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `write()` does not seem to exist on `object<SilverStripe\Cont...\SiteTreeContentReview>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
222
223		DataObject::flush_and_destroy_cache();
224		unset($page);
225
226		/** @var Page\|SiteTreeContentReview $page */
227		$page = $this->objFromFixture(Page::class, "custom");
228
229		$this->assertNull($page->NextReviewDate);
230		}
231
232		public function testUpdateNextReviewDateFromDisabledToCustom()
233		{
234		/** @var Page\|SiteTreeContentReview $page */
235		$page = $this->objFromFixture(Page::class, "disabled");
236
237		$this->assertNull($page->NextReviewDate);
238
239		$page->ContentReviewType = "Custom";
240		$page->ReviewPeriodDays = "7";
241		$page->write();
		0 ignored issues – show Bug introduced 2017-09-12 02:15 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `write()` does not seem to exist on `object<SilverStripe\Cont...\SiteTreeContentReview>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
242
243		DataObject::flush_and_destroy_cache();
244		unset($page);
245
246		/** @var Page\|SiteTreeContentReview $page */
247		$page = $this->objFromFixture(Page::class, "disabled");
248
249		$expected = date('Y-m-d', strtotime("+ " . $page->ReviewPeriodDays . " days"));
250
251		$this->assertEquals($expected, $page->NextReviewDate);
252		}
253
254		public function testParentChangedOptionsAndChildShouldToo()
255		{
256		/** @var Page\|SiteTreeContentReview $parentPage */
257		$parentPage = $this->objFromFixture(Page::class, "page-1");
258
259		/** @var Page\|SiteTreeContentReview $childPage */
260		$childPage = $this->objFromFixture(Page::class, "page-1-1");
261
262		// Parent and child pages have different review dates
263		$this->assertNotEquals($parentPage->NextReviewDate, $childPage->NextReviewDate);
264
265		// But if we change the parent page ReviewPeriodDays to 10, the childs stays the same
266		$parentPage->ReviewPeriodDays = 10;
267		$parentPage->write();
		0 ignored issues – show Bug introduced 2017-09-12 02:15 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `write()` does not seem to exist on `object<SilverStripe\Cont...\SiteTreeContentReview>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
268
269		// Flush all the caches!
270		DataObject::flush_and_destroy_cache();
271
272		/** @var Page\|SiteTreeContentReview $page */
273		$parentPage = $this->objFromFixture(Page::class, "page-1");
274
275		/** @var Page\|SiteTreeContentReview $page */
276		$childPage = $this->objFromFixture(Page::class, "page-1-1");
277
278		// The parent page's date advances, but not the child's
279		$this->assertEquals('2011-04-12', $childPage->NextReviewDate);
280		$this->assertEquals($this->addDaysToDate(date('Y-m-d'), 10), $parentPage->NextReviewDate);
281
282		// Reviewing the child page should, however, advance its review by 10 days
283		$childPage->advanceReviewDate();
284		$childPage->write();
285		$this->assertEquals($this->addDaysToDate(date('Y-m-d'), 10), $childPage->NextReviewDate);
286		}
287
288		/**
289		* Note: all input dates should be DBDatetime or strings in CLDR date format. See {@link DBDate} for information
290		*
291		* @param string\|DBDatetime $date
292		* @param int $days
293		* @param string $format
294		*
295		* @return bool\|string
296		*/
297		private function addDaysToDate($date, $days, $format = 'Y-MM-dd')
298		{
299		if (is_object($date)) {
300		$sec = strtotime("+ " . $days . " days", $date->getTimestamp());
301		} else {
302		$sec = strtotime("+ " . $days . " days", DBDate::create()->setValue($date)->getTimestamp());
303		}
304
305		return DBDate::create()->setValue($sec)->format($format);
306		}
307		}
308

silverstripe / silverstripe-contentreview

Issues (93)

Security Analysis not enabled

tests/php/ContentReviewSettingsTest.php (14 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like