ContentReviewCMSPageEditControllerTest

Complexity

Total Complexity

4

Size/Duplication

Total Lines	98
Duplicated Lines	28.57 %

Coupling/Cohesion

Components	1
Dependencies	4

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	testReviewedThrowsExceptionWithNoRecordID()	14	14	1
A	testReviewedThrowsExceptionWithWrongRecordID()	14	14	1
A	testReviewedWithAuthor()	0	21	1

<?php

namespace SilverStripe\ContentReview\Tests;

use Page;
use SilverStripe\CMS\Controllers\CMSPageEditController;
use SilverStripe\CMS\Model\SiteTree;
use SilverStripe\ContentReview\Extensions\SiteTreeContentReview;
use SilverStripe\ContentReview\Extensions\ContentReviewOwner;
use SilverStripe\ContentReview\Extensions\ContentReviewCMSExtension;
use SilverStripe\ContentReview\Extensions\ContentReviewDefaultSettings;
use SilverStripe\Control\HTTPRequest;
use SilverStripe\Control\HTTPResponse_Exception;
use SilverStripe\Forms\FieldList;
use SilverStripe\Forms\Form;
use SilverStripe\Security\Group;
use SilverStripe\Security\Member;
use SilverStripe\SiteConfig\SiteConfig;

/**
 * @mixin PHPUnit_Framework_TestCase
 */
class ContentReviewCMSPageEditControllerTest extends ContentReviewBaseTest
{
    /**
     * @var string
     */
    protected static $fixture_file = 'ContentReviewTest.yml';

    /**
     * @var array
     */
    protected static $required_extensions = [
        SiteTree::class              => [SiteTreeContentReview::class],
        Group::class                 => [ContentReviewOwner::class],
        Member::class                => [ContentReviewOwner::class],
        CMSPageEditController::class => [ContentReviewCMSExtension::class],
        SiteConfig::class            => [ContentReviewDefaultSettings::class],
    ];

    public function testReviewedThrowsExceptionWithNoRecordID()

This method seems to be duplicated in your project.

    {
        $this->setExpectedException(HTTPResponse_Exception::class);

The method PHPUnit_Framework_TestCase::setExpectedException() has been deprecated with message: Method deprecated since Release 5.2.0; use expectException() instead

        /** @var CMSPageEditController|ContentReviewCMSExtension $controller */
        $controller = new CMSPageEditController();

        $dummyForm = new Form($controller, "EditForm", new FieldList(), new FieldList());

        $controller->savereview(array(
            "ID"      => null,
            "Message" => null,
        ), $dummyForm);
    }

    public function testReviewedThrowsExceptionWithWrongRecordID()

This method seems to be duplicated in your project.

    {
        $this->setExpectedException(HTTPResponse_Exception::class);

The method PHPUnit_Framework_TestCase::setExpectedException() has been deprecated with message: Method deprecated since Release 5.2.0; use expectException() instead

        /** @var CMSPageEditController|ContentReviewCMSExtension $controller */
        $controller = new CMSPageEditController();

        $dummyForm = new Form($controller, "EditForm", new FieldList(), new FieldList());

        $controller->savereview(array(
            "ID"      => "FAIL",
            "Message" => null,
        ), $dummyForm);
    }

    public function testReviewedWithAuthor()
    {
        /** @var Member $author */
        $author = $this->objFromFixture(Member::class, "author");

        $this->logInAs($author);

        /** @var Page|SiteTreeContentReview $page */
        $page = $this->objFromFixture(Page::class, "home");

        $data = array(
            "action_savereview" => 1,
            "ID" => $page->ID,
        );

        $this->get('admin/pages/edit/show/' . $page->ID);
        $response = $this->post($this->getFormAction($page), $data);

        $this->assertEquals("OK", $response->getStatusDescription());
        $this->assertEquals(200, $response->getStatusCode());
    }

    public function testSaveReview()
    {
        /** @var Member $author */
        $author = $this->objFromFixture(Member::class, "author");

        $this->logInAs($author);

        /** @var Page|SiteTreeContentReview $page */
        $page = $this->objFromFixture(Page::class, "home");

        $data = array(
            "action_savereview" => 1,
            "ID"                => $page->ID,
            "ReviewNotes"       => "This is the best page ever",
        );

        $this->get('admin/pages/edit/show/' . $page->ID);
        $response = $this->post($this->getFormAction($page), $data);

        $this->assertEquals("OK", $response->getStatusDescription());
        $this->assertEquals(200, $response->getStatusCode());
        $this->assertEquals(1, $page->ReviewLogs()->count());

        $reviewLog = $page->ReviewLogs()->first();

        $this->assertEquals($data["ReviewNotes"], $reviewLog->Note);
    }

    /**
     * Return a CMS page edit form action via using a dummy request and session
     *
     * @param Page $page
     * @return string
     */
    protected function getFormAction(Page $page)
    {
        $controller = singleton(CMSPageEditController::class);
        $controller->setRequest(new HTTPRequest('GET', '/'));
        $controller->getRequest()->setSession($this->session());

        return $controller->getEditForm($page->ID)->FormAction();
    }
}