1 | <?php |
||||
2 | |||||
3 | namespace SilverStripe\Comments\Admin\CommentsGridFieldBulkAction; |
||||
4 | |||||
5 | use Colymba\BulkManager\BulkAction\Handler; |
||||
0 ignored issues
–
show
|
|||||
6 | use Colymba\BulkTools\HTTPBulkToolsResponse; |
||||
7 | use SilverStripe\Comments\Model\Comment; |
||||
8 | use SilverStripe\Core\Convert; |
||||
9 | use SilverStripe\Control\HTTPRequest; |
||||
10 | use SilverStripe\Control\HTTPResponse; |
||||
11 | |||||
12 | abstract class CommentHandler extends Handler |
||||
13 | { |
||||
14 | protected $xhr = true; |
||||
15 | |||||
16 | protected $destructive = false; |
||||
17 | |||||
18 | /** |
||||
19 | * @param HTTPRequest $request |
||||
20 | * @return HTTPResponse |
||||
21 | */ |
||||
22 | public function index(HTTPRequest $request) |
||||
0 ignored issues
–
show
The parameter
$request is not used and could be removed.
(
Ignorable by Annotation
)
If this is a false-positive, you can also ignore this issue in your code via the
This check looks for parameters that have been defined for a function or method, but which are not used in the method body.
Loading history...
|
|||||
23 | { |
||||
24 | $ids = []; |
||||
25 | |||||
26 | $response = new HTTPBulkToolsResponse( |
||||
27 | true, |
||||
28 | $this->gridField, |
||||
29 | 200 |
||||
30 | ); |
||||
31 | |||||
32 | foreach ($this->getRecords() as $comment) { |
||||
33 | array_push($ids, $comment->ID); |
||||
34 | $this->updateComment($comment); |
||||
35 | $response->addSuccessRecord($comment); |
||||
36 | } |
||||
37 | |||||
38 | $response->setMessage(_t(__CLASS__ . '.CHANGES_APPLIED', 'Changes applied')); |
||||
39 | |||||
40 | return $response; |
||||
41 | } |
||||
42 | |||||
43 | /** |
||||
44 | * @param Comment $comment |
||||
45 | * |
||||
46 | * @return Comment |
||||
47 | */ |
||||
48 | abstract public function updateComment($comment); |
||||
49 | } |
||||
50 |
Let?s assume that you have a directory layout like this:
and let?s assume the following content of
Bar.php
:If both files
OtherDir/Foo.php
andSomeDir/Foo.php
are loaded in the same runtime, you will see a PHP error such as the following:PHP Fatal error: Cannot use SomeDir\Foo as Foo because the name is already in use in OtherDir/Foo.php
However, as
OtherDir/Foo.php
does not necessarily have to be loaded and the error is only triggered if it is loaded beforeOtherDir/Bar.php
, this problem might go unnoticed for a while. In order to prevent this error from surfacing, you must import the namespace with a different alias: