SilverStripe\Comments\Admin\CommentsGridFieldBulkAction\Handler

Complexity

Total Complexity

4

Size/Duplication

Total Lines	58
Duplicated Lines	62.07 %

Coupling/Cohesion

Components	0
Dependencies	3

Importance

Changes	1
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	spam()	18	18	2
A	approve()	18	18	2

<?php

namespace SilverStripe\Comments\Admin\CommentsGridFieldBulkAction;

use Colymba\BulkManager\BulkAction\Handler as GridFieldBulkActionHandler;
use SilverStripe\Core\Convert;
use SilverStripe\Control\HTTPRequest;
use SilverStripe\Control\HTTPResponse;

/**
 * A {@link GridFieldBulkActionHandler} for bulk marking comments as spam
 *
 * @deprecated 3.1..4.0 Abstract handlers are removed, please use concrete Spam or Approve handlers
 */
class Handler extends GridFieldBulkActionHandler
{
    private static $allowed_actions = array(

The property $allowed_actions is not used and could be removed.

Consider using a different property name as you override a private property of the parent class.

        'spam',
        'approve',
    );

    private static $url_handlers = array(

The property $url_handlers is not used and could be removed.

Consider using a different property name as you override a private property of the parent class.

        'spam' => 'spam',
        'approve' => 'approve',
    );

    /**
     * @param  HTTPRequest $request
     * @return HTTPResponse
     */
    public function spam(HTTPRequest $request)

The parameter $request is not used and could be removed.

This method seems to be duplicated in your project.

    {
        $ids = array();

        foreach ($this->getRecords() as $record) {
            array_push($ids, $record->ID);
            $record->markSpam();
        }

        $response = new HTTPResponse(Convert::raw2json(array(
            'done' => true,
            'records' => $ids
        )));

        $response->addHeader('Content-Type', 'text/json');

        return $response;
    }

    /**
     * @param  HTTPRequest $request
     * @return HTTPResponse
     */
    public function approve(HTTPRequest $request)

The parameter $request is not used and could be removed.

This method seems to be duplicated in your project.

    {
        $ids = array();

        foreach ($this->getRecords() as $record) {
            array_push($ids, $record->ID);
            $record->markApproved();
        }

        $response = new HTTPResponse(Convert::raw2json(array(
            'done' => true,
            'records' => $ids
        )));

        $response->addHeader('Content-Type', 'text/json');

        return $response;
    }
}