CommentsGridFieldBulkAction_Handlers::approve() - Code Metrics - Inspection of "Extended translation support" - silverstripe/silverstripe-comments - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#185)

by Janne

created 2016-07-05 08:26 UTC

CommentsGridFieldBulkAction_Handlers::approve() A

↳ Parent: CommentsGridFieldBulkAction_Handlers

Complexity

Conditions	2
Paths	2

Size

Total Lines	18
Code Lines	10

Duplication

Lines	17
Ratio	94.44 %

Importance

Changes	2
Bugs	0	Features	0

Metric	Value
c	2
b	0
f	0
dl	17
loc	18
rs	9.4285
cc	2
eloc	10
nc	2
nop	1

<?php

/**
 * @package comments
 */
class CommentsGridFieldBulkAction extends GridFieldBulkActionHandler
namespace YourVendor;

class YourClass { }
{
}

/**
 * A {@link GridFieldBulkActionHandler} for bulk marking comments as spam
 *
 * @package comments
 */
class CommentsGridFieldBulkAction_Handlers extends CommentsGridFieldBulkAction
namespace YourVendor;

class YourClass { }
{

    private static $allowed_actions = array(

        'spam',
        'approve',
    );

    private static $url_handlers = array(

        'spam' => 'spam',
        'approve' => 'approve',
    );


    public function spam(SS_HTTPRequest $request)

    {
        $ids = array();

        foreach ($this->getRecords() as $record) {
            array_push($ids, $record->ID);
            $record->markSpam();
        }

        $response = new SS_HTTPResponse(Convert::raw2json(array(
            'done' => true,
            'records' => $ids
        )));

        $response->addHeader('Content-Type', 'text/json');

        return $response;
    }


    public function approve(SS_HTTPRequest $request)

    {
        $ids = array();

        foreach ($this->getRecords() as $record) {
            array_push($ids, $record->ID);
            $record->markApproved();
        }

        $response = new SS_HTTPResponse(Convert::raw2json(array(
            'done' => true,
            'records' => $ids
        )));

        $response->addHeader('Content-Type', 'text/json');

        return $response;
    }
}


1		<?php
2
3		/**
4		* @package comments
5		*/
6		class CommentsGridFieldBulkAction extends GridFieldBulkActionHandler
		0 ignored issues – show Coding Style Compatibility introduced 2015-11-21 06:31 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
7		{
8		}
9
10		/**
11		* A {@link GridFieldBulkActionHandler} for bulk marking comments as spam
12		*
13		* @package comments
14		*/
15		class CommentsGridFieldBulkAction_Handlers extends CommentsGridFieldBulkAction
		0 ignored issues – show Coding Style Compatibility introduced 2015-11-21 06:31 UTC by Report Bug Copy Issue Report PSR1 recommends that each class should be in its own file to aid autoloaders. Having each class in a dedicated file usually plays nice with PSR autoloaders and is therefore a well established practice. If you use other autoloaders, you might not want to follow this rule. Loading history... Coding Style Compatibility introduced 2015-11-21 06:31 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
16		{
17
18		private static $allowed_actions = array(
		0 ignored issues – show Comprehensibility introduced 2015-11-20 23:54 UTC by Report Bug Copy Issue Report Consider using a different property name as you override a private property of the parent class. Loading history... Unused Code introduced 2015-11-21 06:31 UTC by Report Bug Copy Issue Report The property `$allowed_actions` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
19		'spam',
20		'approve',
21		);
22
23		private static $url_handlers = array(
		0 ignored issues – show Comprehensibility introduced 2015-11-20 23:54 UTC by Report Bug Copy Issue Report Consider using a different property name as you override a private property of the parent class. Loading history... Unused Code introduced 2015-11-21 06:31 UTC by Report Bug Copy Issue Report The property `$url_handlers` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
24		'spam' => 'spam',
25		'approve' => 'approve',
26		);
27
28
29	View Code Duplication	public function spam(SS_HTTPRequest $request)
		0 ignored issues – show Unused Code introduced 2015-11-20 23:54 UTC by Report Bug Copy Issue Report The parameter `$request` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history... Duplication introduced 2015-11-20 23:54 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
30		{
31		$ids = array();
32
33		foreach ($this->getRecords() as $record) {
34		array_push($ids, $record->ID);
35		$record->markSpam();
36		}
37
38		$response = new SS_HTTPResponse(Convert::raw2json(array(
39		'done' => true,
40		'records' => $ids
41		)));
42
43		$response->addHeader('Content-Type', 'text/json');
44
45		return $response;
46		}
47
48
49	View Code Duplication	public function approve(SS_HTTPRequest $request)
		0 ignored issues – show Unused Code introduced 2015-11-20 23:54 UTC by Report Bug Copy Issue Report The parameter `$request` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history... Duplication introduced 2015-11-20 23:54 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
50		{
51		$ids = array();
52
53		foreach ($this->getRecords() as $record) {
54		array_push($ids, $record->ID);
55		$record->markApproved();
56		}
57
58		$response = new SS_HTTPResponse(Convert::raw2json(array(
59		'done' => true,
60		'records' => $ids
61		)));
62
63		$response->addHeader('Content-Type', 'text/json');
64
65		return $response;
66		}
67		}
68

silverstripe / silverstripe-comments

Pull Request — master (#185)

CommentsGridFieldBulkAction_Handlers::approve() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like