CommentListTest::testRemoveNonComment() - Code Metrics - Inspection of "Merge pull request #141 from helpfulrobot/add-stan..." - silverstripe/silverstripe-comments - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 02d548...e42a4c )

by Damian

created 2016-03-21 04:35 UTC

CommentListTest::testRemoveNonComment() A

↳ Parent: CommentListTest

Complexity

Conditions	2
Paths	3

Size

Total Lines	20
Code Lines	12

Duplication

Lines	20
Ratio	100 %

Metric	Value
dl	20
loc	20
rs	9.4285
cc	2
eloc	12
nc	3
nop	0

<?php

class CommentListTest extends FunctionalTest {
namespace YourVendor;

class YourClass { }

    public static $fixture_file = 'comments/tests/CommentsTest.yml';

    protected $extraDataObjects = array(
        'CommentableItem',
        'CommentableItemEnabled',
        'CommentableItemDisabled'
    );

    public function setUp() {

        parent::setUp();
        Config::nest();

        // Set good default values
        Config::inst()->update('CommentsExtension', 'comments', array(
            'enabled' => true,
            'enabled_cms' => false,
            'require_login' => false,
            'require_login_cms' => false,
            'required_permission' => false,
            'require_moderation_nonmembers' => false,
            'require_moderation' => false,
            'require_moderation_cms' => false,
            'frontend_moderation' => false,
            'frontend_spam' => false,
        ));

        // Configure this dataobject
        Config::inst()->update('CommentableItem', 'comments', array(
            'enabled_cms' => true
        ));
    }

    public function tearDown() {
        Config::unnest();
        parent::tearDown();
    }

	public function testGetForeignClass() {
        $item = $this->objFromFixture('CommentableItem', 'first');

        // This is the class the Comments are related to
        $this->assertEquals('CommentableItem',

                                $item->Comments()->getForeignClass());
	}

    public function testAddNonComment() {

        $item = $this->objFromFixture('CommentableItem', 'first');
        $comments = $item->Comments();
        $this->assertEquals(4, $comments->count());

        $member = Member::get()->first();
        try {
            $comments->add($member);
            $this->fail('Should not have been able to add member to comments');

        } catch (InvalidArgumentException $e) {
            $this->assertEquals(

                'CommentList::add() expecting a Comment object, or ID value',
                $e->getMessage()
            );
        }
    }

	public function testAddComment() {
        $item = $this->objFromFixture('CommentableItem', 'first');
        $firstComment = $this->objFromFixture('Comment', 'firstComA');
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        $comments = $item->Comments();//->sort('Created');


        foreach ($comments as $comment) {
            error_log($comment->ID . ' ' . $comment->Created .' ' . $comment->Comment);
        }

        $this->assertEquals(4, $comments->count());

        $newComment = new Comment();
        $newComment->Name = 'Fred Bloggs';
        $newComment->Comment = 'This is a test comment';
        $newComment->write();

        $comments->add($newComment);
        // As a comment has been added, there should be 5 comments now
        $this->assertEquals(5, $item->Comments()->count());


        $newComment2 = new Comment();
        $newComment2->Name = 'John Smith';
        $newComment2->Comment = 'This is another test comment';
        $newComment2->write();

        // test adding the same comment by ID
        $comments->add($newComment2->ID);
        $this->assertEquals(6, $item->Comments()->count());


        $this->setExpectedException(

            'InvalidArgumentException',
            "CommentList::add() can't be called until a single foreign ID is set"
        );
        $list = new CommentList('CommentableItem');
        $list->add($newComment);
	}

	public function testRemoveComment() {
        // remove by comment
        $item = $this->objFromFixture('CommentableItem', 'first');
        $this->assertEquals(4, $item->Comments()->count());

        $comments = $item->Comments();
        $comment = $comments->first();
        $comments->remove($comment);

        // now remove by ID
        $comments = $item->Comments();
        $comment = $comments->first();
        $comments->remove($comment->ID);
        $this->assertEquals(2, $item->Comments()->count());

    }

    public function testRemoveNonComment() {

        $item = $this->objFromFixture('CommentableItem', 'first');
        $this->assertEquals(4, $item->Comments()->count());

        $comments = $item->Comments();

        // try and remove a non comment
        $member = Member::get()->first();



        try {
            $comments->remove($member);
            $this->fail('Should not have been able to remove member from comments');

        } catch (InvalidArgumentException $e) {
            $this->assertEquals(

                'CommentList::remove() expecting a Comment object, or ID',
                $e->getMessage()
            );
        }
    }

}


1		<?php
2
3		class CommentListTest extends FunctionalTest {
		0 ignored issues – show Coding Style Compatibility introduced 2016-03-21 04:11 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
4
5		public static $fixture_file = 'comments/tests/CommentsTest.yml';
6
7		protected $extraDataObjects = array(
8		'CommentableItem',
9		'CommentableItemEnabled',
10		'CommentableItemDisabled'
11		);
12
13	View Code Duplication	public function setUp() {
		0 ignored issues – show Duplication introduced 2016-03-21 04:11 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
14		parent::setUp();
15		Config::nest();
16
17		// Set good default values
18		Config::inst()->update('CommentsExtension', 'comments', array(
19		'enabled' => true,
20		'enabled_cms' => false,
21		'require_login' => false,
22		'require_login_cms' => false,
23		'required_permission' => false,
24		'require_moderation_nonmembers' => false,
25		'require_moderation' => false,
26		'require_moderation_cms' => false,
27		'frontend_moderation' => false,
28		'frontend_spam' => false,
29		));
30
31		// Configure this dataobject
32		Config::inst()->update('CommentableItem', 'comments', array(
33		'enabled_cms' => true
34		));
35		}
36
37		public function tearDown() {
38		Config::unnest();
39		parent::tearDown();
40		}
41
42		public function testGetForeignClass() {
43		$item = $this->objFromFixture('CommentableItem', 'first');
44
45		// This is the class the Comments are related to
46		$this->assertEquals('CommentableItem',
		0 ignored issues – show Bug introduced 2016-03-21 04:11 UTC by Report Bug Copy Issue Report The method `assertEquals()` does not seem to exist on `object<CommentListTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
47		$item->Comments()->getForeignClass());
48		}
49
50	View Code Duplication	public function testAddNonComment() {
		0 ignored issues – show Duplication introduced 2016-03-21 04:11 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
51		$item = $this->objFromFixture('CommentableItem', 'first');
52		$comments = $item->Comments();
53		$this->assertEquals(4, $comments->count());
		0 ignored issues – show Bug introduced 2016-03-21 04:11 UTC by Report Bug Copy Issue Report The method `assertEquals()` does not seem to exist on `object<CommentListTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
54		$member = Member::get()->first();
55		try {
56		$comments->add($member);
57		$this->fail('Should not have been able to add member to comments');
		0 ignored issues – show Bug introduced 2016-03-21 04:11 UTC by Report Bug Copy Issue Report The method `fail()` does not seem to exist on `object<CommentListTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
58		} catch (InvalidArgumentException $e) {
59		$this->assertEquals(
		0 ignored issues – show Bug introduced 2016-03-21 04:11 UTC by Report Bug Copy Issue Report The method `assertEquals()` does not seem to exist on `object<CommentListTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
60		'CommentList::add() expecting a Comment object, or ID value',
61		$e->getMessage()
62		);
63		}
64		}
65
66		public function testAddComment() {
67		$item = $this->objFromFixture('CommentableItem', 'first');
68		$firstComment = $this->objFromFixture('Comment', 'firstComA');
		0 ignored issues – show Unused Code introduced 2016-03-21 04:11 UTC by Report Bug Copy Issue Report `$firstComment` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
69		$comments = $item->Comments();//->sort('Created');
		0 ignored issues – show Unused Code Comprehensibility introduced 2016-03-21 04:11 UTC by Report Bug Copy Issue Report `84%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
70
71		foreach ($comments as $comment) {
72		error_log($comment->ID . ' ' . $comment->Created .' ' . $comment->Comment);
73		}
74
75		$this->assertEquals(4, $comments->count());
		0 ignored issues – show Bug introduced 2016-03-21 04:11 UTC by Report Bug Copy Issue Report The method `assertEquals()` does not seem to exist on `object<CommentListTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
76		$newComment = new Comment();
77		$newComment->Name = 'Fred Bloggs';
78		$newComment->Comment = 'This is a test comment';
79		$newComment->write();
80
81		$comments->add($newComment);
82		// As a comment has been added, there should be 5 comments now
83		$this->assertEquals(5, $item->Comments()->count());
		0 ignored issues – show Bug introduced 2016-03-21 04:11 UTC by Report Bug Copy Issue Report The method `assertEquals()` does not seem to exist on `object<CommentListTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
84
85		$newComment2 = new Comment();
86		$newComment2->Name = 'John Smith';
87		$newComment2->Comment = 'This is another test comment';
88		$newComment2->write();
89
90		// test adding the same comment by ID
91		$comments->add($newComment2->ID);
92		$this->assertEquals(6, $item->Comments()->count());
		0 ignored issues – show Bug introduced 2016-03-21 04:11 UTC by Report Bug Copy Issue Report The method `assertEquals()` does not seem to exist on `object<CommentListTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
93
94		$this->setExpectedException(
		0 ignored issues – show Bug introduced 2016-03-21 04:11 UTC by Report Bug Copy Issue Report The method `setExpectedException()` does not seem to exist on `object<CommentListTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
95		'InvalidArgumentException',
96		"CommentList::add() can't be called until a single foreign ID is set"
97		);
98		$list = new CommentList('CommentableItem');
99		$list->add($newComment);
100		}
101
102		public function testRemoveComment() {
103		// remove by comment
104		$item = $this->objFromFixture('CommentableItem', 'first');
105		$this->assertEquals(4, $item->Comments()->count());
		0 ignored issues – show Bug introduced 2016-03-21 04:11 UTC by Report Bug Copy Issue Report The method `assertEquals()` does not seem to exist on `object<CommentListTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
106		$comments = $item->Comments();
107		$comment = $comments->first();
108		$comments->remove($comment);
109
110		// now remove by ID
111		$comments = $item->Comments();
112		$comment = $comments->first();
113		$comments->remove($comment->ID);
114		$this->assertEquals(2, $item->Comments()->count());
		0 ignored issues – show Bug introduced 2016-03-21 04:11 UTC by Report Bug Copy Issue Report The method `assertEquals()` does not seem to exist on `object<CommentListTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
115		}
116
117	View Code Duplication	public function testRemoveNonComment() {
		0 ignored issues – show Duplication introduced 2016-03-21 04:11 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
118		$item = $this->objFromFixture('CommentableItem', 'first');
119		$this->assertEquals(4, $item->Comments()->count());
		0 ignored issues – show Bug introduced 2016-03-21 04:11 UTC by Report Bug Copy Issue Report The method `assertEquals()` does not seem to exist on `object<CommentListTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
120		$comments = $item->Comments();
121
122		// try and remove a non comment
123		$member = Member::get()->first();
124
125
126
127		try {
128		$comments->remove($member);
129		$this->fail('Should not have been able to remove member from comments');
		0 ignored issues – show Bug introduced 2016-03-21 04:11 UTC by Report Bug Copy Issue Report The method `fail()` does not seem to exist on `object<CommentListTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
130		} catch (InvalidArgumentException $e) {
131		$this->assertEquals(
		0 ignored issues – show Bug introduced 2016-03-21 04:11 UTC by Report Bug Copy Issue Report The method `assertEquals()` does not seem to exist on `object<CommentListTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
132		'CommentList::remove() expecting a Comment object, or ID',
133		$e->getMessage()
134		);
135		}
136		}
137
138		}
139

silverstripe / silverstripe-comments

Push — master ( 02d548...e42a4c )

CommentListTest::testRemoveNonComment() A

Complexity

Size

Duplication

Duplication Side-by-Side

Filter issues like