CommentsGridFieldBulkAction_Handlers

Complexity

Total Complexity

4

Size/Duplication

Total Lines	53
Duplicated Lines	64.15 %

Coupling/Cohesion

Components	0
Dependencies	3

Importance

Changes	4
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	spam()	17	18	2
A	approve()	17	18	2

<?php

/**
 * @package comments
 */
class CommentsGridFieldBulkAction extends GridFieldBulkActionHandler

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{
}

/**
 * A {@link GridFieldBulkActionHandler} for bulk marking comments as spam
 *
 * @package comments
 */
class CommentsGridFieldBulkAction_Handlers extends CommentsGridFieldBulkAction

PSR1 recommends that each class should be in its own file to aid autoloaders.

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{

    private static $allowed_actions = array(

Consider using a different property name as you override a private property of the parent class.

The property $allowed_actions is not used and could be removed.

        'spam',
        'approve',
    );

    private static $url_handlers = array(

Consider using a different property name as you override a private property of the parent class.

The property $url_handlers is not used and could be removed.

        'spam' => 'spam',
        'approve' => 'approve',
    );


    public function spam(SS_HTTPRequest $request)

The parameter $request is not used and could be removed.

This method seems to be duplicated in your project.

    {
        $ids = array();

        foreach ($this->getRecords() as $record) {
            array_push($ids, $record->ID);
            $record->markSpam();
        }

        $response = new SS_HTTPResponse(Convert::raw2json(array(
            'done' => true,
            'records' => $ids
        )));

        $response->addHeader('Content-Type', 'text/json');

        return $response;
    }


    public function approve(SS_HTTPRequest $request)

The parameter $request is not used and could be removed.

This method seems to be duplicated in your project.

    {
        $ids = array();

        foreach ($this->getRecords() as $record) {
            array_push($ids, $record->ID);
            $record->markApproved();
        }

        $response = new SS_HTTPResponse(Convert::raw2json(array(
            'done' => true,
            'records' => $ids
        )));

        $response->addHeader('Content-Type', 'text/json');

        return $response;
    }
}