CommentListTest

Complexity

Total Complexity

10

Size/Duplication

Total Lines	136
Duplicated Lines	42.65 %

Coupling/Cohesion

Components	1
Dependencies	6

7 Methods

Rating	Name	Duplication	Size	Complexity
A	setUp()	23	23	1
A	tearDown()	0	4	1
A	testGetForeignClass()	0	7	1
A	testAddNonComment()	15	15	2
B	testAddComment()	0	35	2
A	testRemoveComment()	0	14	1
A	testRemoveNonComment()	20	20	2

<?php

class CommentListTest extends FunctionalTest {

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

    public static $fixture_file = 'comments/tests/CommentsTest.yml';

    protected $extraDataObjects = array(
        'CommentableItem',
        'CommentableItemEnabled',
        'CommentableItemDisabled'
    );

    public function setUp() {

This method seems to be duplicated in your project.

        parent::setUp();
        Config::nest();

        // Set good default values
        Config::inst()->update('CommentsExtension', 'comments', array(
            'enabled' => true,
            'enabled_cms' => false,
            'require_login' => false,
            'require_login_cms' => false,
            'required_permission' => false,
            'require_moderation_nonmembers' => false,
            'require_moderation' => false,
            'require_moderation_cms' => false,
            'frontend_moderation' => false,
            'frontend_spam' => false,
        ));

        // Configure this dataobject
        Config::inst()->update('CommentableItem', 'comments', array(
            'enabled_cms' => true
        ));
    }

    public function tearDown() {
        Config::unnest();
        parent::tearDown();
    }

	public function testGetForeignClass() {
        $item = $this->objFromFixture('CommentableItem', 'first');

        // This is the class the Comments are related to
        $this->assertEquals('CommentableItem',

The method assertEquals() does not seem to exist on object<CommentListTest>.

                                $item->Comments()->getForeignClass());
	}

    public function testAddNonComment() {

This method seems to be duplicated in your project.

        $item = $this->objFromFixture('CommentableItem', 'first');
        $comments = $item->Comments();
        $this->assertEquals(4, $comments->count());

The method assertEquals() does not seem to exist on object<CommentListTest>.

        $member = Member::get()->first();
        try {
            $comments->add($member);
            $this->fail('Should not have been able to add member to comments');

The method fail() does not seem to exist on object<CommentListTest>.

        } catch (InvalidArgumentException $e) {
            $this->assertEquals(

The method assertEquals() does not seem to exist on object<CommentListTest>.

                'CommentList::add() expecting a Comment object, or ID value',
                $e->getMessage()
            );
        }
    }

	public function testAddComment() {
        $item = $this->objFromFixture('CommentableItem', 'first');
        $firstComment = $this->objFromFixture('Comment', 'firstComA');

$firstComment is not used, you could remove the assignment.

        $comments = $item->Comments();//->sort('Created');

84% of this comment could be valid code. Did you maybe forget this after debugging?

        foreach ($comments as $comment) {
            error_log($comment->ID . ' ' . $comment->Created .' ' . $comment->Comment);
        }

        $this->assertEquals(4, $comments->count());

The method assertEquals() does not seem to exist on object<CommentListTest>.

        $newComment = new Comment();
        $newComment->Name = 'Fred Bloggs';
        $newComment->Comment = 'This is a test comment';
        $newComment->write();

        $comments->add($newComment);
        // As a comment has been added, there should be 5 comments now
        $this->assertEquals(5, $item->Comments()->count());

The method assertEquals() does not seem to exist on object<CommentListTest>.

        $newComment2 = new Comment();
        $newComment2->Name = 'John Smith';
        $newComment2->Comment = 'This is another test comment';
        $newComment2->write();

        // test adding the same comment by ID
        $comments->add($newComment2->ID);
        $this->assertEquals(6, $item->Comments()->count());

The method assertEquals() does not seem to exist on object<CommentListTest>.

        $this->setExpectedException(

The method setExpectedException() does not seem to exist on object<CommentListTest>.

            'InvalidArgumentException',
            "CommentList::add() can't be called until a single foreign ID is set"
        );
        $list = new CommentList('CommentableItem');
        $list->add($newComment);
	}

	public function testRemoveComment() {
        // remove by comment
        $item = $this->objFromFixture('CommentableItem', 'first');
        $this->assertEquals(4, $item->Comments()->count());

The method assertEquals() does not seem to exist on object<CommentListTest>.

        $comments = $item->Comments();
        $comment = $comments->first();
        $comments->remove($comment);

        // now remove by ID
        $comments = $item->Comments();
        $comment = $comments->first();
        $comments->remove($comment->ID);
        $this->assertEquals(2, $item->Comments()->count());

The method assertEquals() does not seem to exist on object<CommentListTest>.

    }

    public function testRemoveNonComment() {

This method seems to be duplicated in your project.

        $item = $this->objFromFixture('CommentableItem', 'first');
        $this->assertEquals(4, $item->Comments()->count());

The method assertEquals() does not seem to exist on object<CommentListTest>.

        $comments = $item->Comments();

        // try and remove a non comment
        $member = Member::get()->first();



        try {
            $comments->remove($member);
            $this->fail('Should not have been able to remove member from comments');

The method fail() does not seem to exist on object<CommentListTest>.

        } catch (InvalidArgumentException $e) {
            $this->assertEquals(

The method assertEquals() does not seem to exist on object<CommentListTest>.

                'CommentList::remove() expecting a Comment object, or ID',
                $e->getMessage()
            );
        }
    }

}