CommentAdmin::getEditForm() - Code Metrics - silverstripe/silverstripe-comments - Measure and Improve Code Quality continuously with Scrutinizer

CommentAdmin::getEditForm() B
last analyzed 2019-11-05 01:22 UTC

↳ Parent: CommentAdmin

Complexity

Conditions	5
Paths	6

Size

Total Lines	93
Code Lines	61

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	5
eloc	61
nc	6
nop	2
dl	0
loc	93
rs	8.5397
c	0
b	0
f	0

How to fix Long Method

<?php

namespace SilverStripe\Comments\Admin;

use SilverStripe\Admin\LeftAndMain;
use SilverStripe\Comments\Model\Comment;
use SilverStripe\Forms\FieldList;
use SilverStripe\Forms\Form;
use SilverStripe\Forms\Tab;
use SilverStripe\Forms\TabSet;
use SilverStripe\Security\PermissionProvider;
use SilverStripe\Security\Security;

/**
 * Comment administration system within the CMS
 *
 * @package comments
 */
class CommentAdmin extends LeftAndMain implements PermissionProvider
{
    private static $url_segment = 'comments';


    private static $url_rule = '/$Action';


    private static $menu_title = 'Comments';


    private static $menu_icon_class = 'font-icon-comment';


    private static $allowed_actions = [

        'approvedmarked',
        'deleteall',
        'deletemarked',
        'hammarked',
        'showtable',
        'spammarked',
        'EditForm',
        'unmoderated'
    ];

    private static $required_permission_codes = 'CMS_ACCESS_CommentAdmin';


    public function providePermissions()
    {
        return [
            'CMS_ACCESS_CommentAdmin' => [
                'name' => _t(__CLASS__ . '.ADMIN_PERMISSION', "Access to 'Comments' section"),
                'category' => _t('SilverStripe\\Security\\Permission.CMS_ACCESS_CATEGORY', 'CMS Access')
            ],
        ];
    }

    /**
     * @return Form
     */
    public function getEditForm($id = null, $fields = null)
    {
        if (!$id) {
            $id = $this->currentPageID();
        }

        $form = parent::getEditForm($id);

        $record = $this->getRecord($id);

        if ($record && !$record->canView()) {
            return Security::permissionFailure($this);

        }

        $newComments = Comment::get()->filter('Moderated', 0);

        $newGrid = CommentsGridField::create(
            'NewComments',
            '',
            $newComments,
            CommentsGridFieldConfig::create()
        );

        $approvedComments = Comment::get()->filter('Moderated', 1)->filter('IsSpam', 0);

        $approvedGrid = CommentsGridField::create(
            'ApprovedComments',
            '',
            $approvedComments,
            CommentsGridFieldConfig::create()
        );

        $spamComments = Comment::get()->filter('Moderated', 1)->filter('IsSpam', 1);

        $spamGrid = CommentsGridField::create(
            'SpamComments',
            '',
            $spamComments,
            CommentsGridFieldConfig::create()
        );

        $fields = FieldList::create(
            $root = TabSet::create(
                'Root',
                Tab::create(
                    'NewComments',
                    _t(
                        __CLASS__.'.NewComments',
                        'New ({count})',
                        ['count' => count($newComments)]
                    ),
                    $newGrid
                ),
                Tab::create(
                    'ApprovedComments',
                    _t(
                        __CLASS__.'.ApprovedComments',
                        'Approved ({count})',
                        ['count' => count($approvedComments)]
                    ),
                    $approvedGrid
                ),
                Tab::create(
                    'SpamComments',
                    _t(
                        __CLASS__.'.SpamComments',
                        'Spam ({count})',
                        ['count' => count($spamComments)]
                    ),
                    $spamGrid
                )
            )
        );

        $actions = FieldList::create();

        $form = Form::create(
            $this,
            'EditForm',
            $fields,
            $actions
        );

        $form->addExtraClass('cms-edit-form fill-height');
        $form->setTemplate($this->getTemplatesWithSuffix('_EditForm'));

        if ($form->Fields()->hasTabset()) {
            $form->Fields()->findOrMakeTab('Root')->setTemplate('SilverStripe\\Forms\\CMSTabSet');
            $form->addExtraClass('center ss-tabset cms-tabset ' . $this->BaseCSSClasses());
        }

        $this->extend('updateEditForm', $form);

        return $form;
    }
}


1			<?php
2
3			namespace SilverStripe\Comments\Admin;
4
5			use SilverStripe\Admin\LeftAndMain;
6			use SilverStripe\Comments\Model\Comment;
7			use SilverStripe\Forms\FieldList;
8			use SilverStripe\Forms\Form;
9			use SilverStripe\Forms\Tab;
10			use SilverStripe\Forms\TabSet;
11			use SilverStripe\Security\PermissionProvider;
12			use SilverStripe\Security\Security;
13
14			/**
15			* Comment administration system within the CMS
16			*
17			* @package comments
18			*/
19			class CommentAdmin extends LeftAndMain implements PermissionProvider
20			{
21			private static $url_segment = 'comments';
			0 ignored issues – show introduced 2019-02-10 04:05 UTC by Report Bug Copy Issue Report The private property `$url_segment` is not used, and could be removed. Loading history...
22
23			private static $url_rule = '/$Action';
			0 ignored issues – show introduced 2019-02-10 04:05 UTC by Report Bug Copy Issue Report The private property `$url_rule` is not used, and could be removed. Loading history...
24
25			private static $menu_title = 'Comments';
			0 ignored issues – show introduced 2019-02-10 04:05 UTC by Report Bug Copy Issue Report The private property `$menu_title` is not used, and could be removed. Loading history...
26
27			private static $menu_icon_class = 'font-icon-comment';
			0 ignored issues – show introduced 2019-02-10 04:05 UTC by Report Bug Copy Issue Report The private property `$menu_icon_class` is not used, and could be removed. Loading history...
28
29			private static $allowed_actions = [
			0 ignored issues – show introduced 2019-02-10 04:05 UTC by Report Bug Copy Issue Report The private property `$allowed_actions` is not used, and could be removed. Loading history...
30			'approvedmarked',
31			'deleteall',
32			'deletemarked',
33			'hammarked',
34			'showtable',
35			'spammarked',
36			'EditForm',
37			'unmoderated'
38			];
39
40			private static $required_permission_codes = 'CMS_ACCESS_CommentAdmin';
			0 ignored issues – show introduced 2019-02-10 04:05 UTC by Report Bug Copy Issue Report The private property `$required_permission_codes` is not used, and could be removed. Loading history...
41
42			public function providePermissions()
43			{
44			return [
45			'CMS_ACCESS_CommentAdmin' => [
46			'name' => _t(__CLASS__ . '.ADMIN_PERMISSION', "Access to 'Comments' section"),
47			'category' => _t('SilverStripe\\Security\\Permission.CMS_ACCESS_CATEGORY', 'CMS Access')
48			],
49			];
50			}
51
52			/**
53			* @return Form
54			*/
55			public function getEditForm($id = null, $fields = null)
56			{
57			if (!$id) {
58			$id = $this->currentPageID();
59			}
60
61			$form = parent::getEditForm($id);
			0 ignored issues – show Unused Code introduced 2019-02-10 04:05 UTC by Report Bug Copy Issue Report The assignment to `$form` is dead and can be removed. Loading history...
62			$record = $this->getRecord($id);
63
64			if ($record && !$record->canView()) {
65			return Security::permissionFailure($this);
			0 ignored issues – show Bug Best Practice introduced 2019-02-10 04:05 UTC by Report Bug Copy Issue Report The expression `return SilverStripe\Secu...ermissionFailure($this)` returns the type `SilverStripe\Control\HTTPResponse` which is incompatible with the documented return type `SilverStripe\Forms\Form`. Loading history...
66			}
67
68			$newComments = Comment::get()->filter('Moderated', 0);
69
70			$newGrid = CommentsGridField::create(
71			'NewComments',
72			'',
73			$newComments,
74			CommentsGridFieldConfig::create()
75			);
76
77			$approvedComments = Comment::get()->filter('Moderated', 1)->filter('IsSpam', 0);
78
79			$approvedGrid = CommentsGridField::create(
80			'ApprovedComments',
81			'',
82			$approvedComments,
83			CommentsGridFieldConfig::create()
84			);
85
86			$spamComments = Comment::get()->filter('Moderated', 1)->filter('IsSpam', 1);
87
88			$spamGrid = CommentsGridField::create(
89			'SpamComments',
90			'',
91			$spamComments,
92			CommentsGridFieldConfig::create()
93			);
94
95			$fields = FieldList::create(
96			$root = TabSet::create(
97			'Root',
98			Tab::create(
99			'NewComments',
100			_t(
101			__CLASS__.'.NewComments',
102			'New ({count})',
103			['count' => count($newComments)]
104			),
105			$newGrid
106			),
107			Tab::create(
108			'ApprovedComments',
109			_t(
110			__CLASS__.'.ApprovedComments',
111			'Approved ({count})',
112			['count' => count($approvedComments)]
113			),
114			$approvedGrid
115			),
116			Tab::create(
117			'SpamComments',
118			_t(
119			__CLASS__.'.SpamComments',
120			'Spam ({count})',
121			['count' => count($spamComments)]
122			),
123			$spamGrid
124			)
125			)
126			);
127
128			$actions = FieldList::create();
129
130			$form = Form::create(
131			$this,
132			'EditForm',
133			$fields,
134			$actions
135			);
136
137			$form->addExtraClass('cms-edit-form fill-height');
138			$form->setTemplate($this->getTemplatesWithSuffix('_EditForm'));
139
140			if ($form->Fields()->hasTabset()) {
141			$form->Fields()->findOrMakeTab('Root')->setTemplate('SilverStripe\\Forms\\CMSTabSet');
142			$form->addExtraClass('center ss-tabset cms-tabset ' . $this->BaseCSSClasses());
143			}
144
145			$this->extend('updateEditForm', $form);
146
147			return $form;
148			}
149			}
150

silverstripe / silverstripe-comments

CommentAdmin::getEditForm() B last analyzed 2019-11-05 01:22 UTC

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like

CommentAdmin::getEditForm() B
last analyzed 2019-11-05 01:22 UTC