Completed
Push — master ( 1cc1aa...91444b )
by Daniel
03:40
created
code/Controllers/CMSMain.php 2 patches
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -5,7 +5,6 @@
 block discarded – undo
5 5
 use FormField;
6 6
 use Injector;
7 7
 use ResetFormAction;
8
-use SilverStripe\ORM\FieldType\DBHTMLText;
9 8
 use SilverStripe\ORM\SS_List;
10 9
 use SilverStripe\ORM\Versioning\Versioned;
11 10
 use SilverStripe\ORM\HiddenClass;
Please login to merge, or discard this patch.
Doc Comments   +6 added lines, -3 removed lines patch added patch discarded remove patch
@@ -284,6 +284,9 @@  discard block
 block discarded – undo
284 284
 		}
285 285
 	}
286 286
 
287
+	/**
288
+	 * @param string $link
289
+	 */
287 290
 	public function LinkWithSearch($link) {
288 291
 		// Whitelist to avoid side effects
289 292
 		$params = array(
@@ -766,7 +769,7 @@  discard block
 block discarded – undo
766 769
 
767 770
 	/**
768 771
 	 * @param SS_HTTPRequest $request
769
-	 * @return string HTML
772
+	 * @return DBHTMLText HTML
770 773
 	 */
771 774
 	public function treeview($request) {
772 775
 		return $this->renderWith($this->getTemplatesWithSuffix('_TreeView'));
@@ -774,7 +777,7 @@  discard block
 block discarded – undo
774 777
 
775 778
 	/**
776 779
 	 * @param SS_HTTPRequest $request
777
-	 * @return string HTML
780
+	 * @return DBHTMLText HTML
778 781
 	 */
779 782
 	public function listview($request) {
780 783
 		return $this->renderWith($this->getTemplatesWithSuffix('_ListView'));
@@ -1095,7 +1098,7 @@  discard block
 block discarded – undo
1095 1098
 	 * Actually perform the publication step
1096 1099
 	 *
1097 1100
 	 * @param Versioned|DataObject $record
1098
-	 * @return mixed
1101
+	 * @return SS_HTTPResponse|null
1099 1102
 	 */
1100 1103
 	public function performPublish($record) {
1101 1104
 		if($record && !$record->canPublish()) {
Please login to merge, or discard this patch.
code/Controllers/CMSPageEditController.php 1 patch
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -39,7 +39,7 @@  discard block
 block discarded – undo
39 39
 	 *
40 40
 	 * @param array $data
41 41
 	 * @param Form $form
42
-	 * @return DBHTMLText|SS_HTTPResponse
42
+	 * @return SS_HTTPResponse|null
43 43
 	 */
44 44
 	public function addtocampaign($data, $form)
45 45
 	{
@@ -66,7 +66,7 @@  discard block
 block discarded – undo
66 66
 	 * Url handler for add to campaign form
67 67
 	 *
68 68
 	 * @param SS_HTTPRequest $request
69
-	 * @return Form
69
+	 * @return null|\Form
70 70
 	 */
71 71
 	public function AddToCampaignForm($request)
72 72
 	{
@@ -77,7 +77,7 @@  discard block
 block discarded – undo
77 77
 
78 78
 	/**
79 79
 	 * @param int $id
80
-	 * @return Form
80
+	 * @return null|\Form
81 81
 	 */
82 82
 	public function getAddToCampaignForm($id)
83 83
 	{
Please login to merge, or discard this patch.
code/Controllers/SilverStripeNavigatorItem.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -27,7 +27,7 @@  discard block
 block discarded – undo
27 27
 	protected $recordLink;
28 28
 
29 29
 	/**
30
-	 * @param DataObject|CMSPreviewable $record
30
+	 * @param CMSPreviewable $record
31 31
 	 */
32 32
 	public function __construct(CMSPreviewable $record)
33 33
 	{
@@ -76,7 +76,7 @@  discard block
 block discarded – undo
76 76
 	}
77 77
 
78 78
 	/**
79
-	 * @return DataObject
79
+	 * @return CMSPreviewable
80 80
 	 */
81 81
 	public function getRecord()
82 82
 	{
Please login to merge, or discard this patch.
code/Controllers/OldPageRedirector.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -2,7 +2,6 @@
 block discarded – undo
2 2
 
3 3
 namespace SilverStripe\CMS\Controllers;
4 4
 
5
-use SilverStripe\ORM\Queries\SQLSelect;
6 5
 use SilverStripe\CMS\Model\SiteTree;
7 6
 use Extension;
8 7
 use Director;
Please login to merge, or discard this patch.
code/Controllers/SilverStripeNavigatorItem_ArchiveLink.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -3,7 +3,6 @@
 block discarded – undo
3 3
 
4 4
 use Controller;
5 5
 use SilverStripe\CMS\Model\RedirectorPage;
6
-use SilverStripe\ORM\FieldType\DBDatetime;
7 6
 use SilverStripe\ORM\FieldType\DBField;
8 7
 use SilverStripe\ORM\Versioning\Versioned;
9 8
 
Please login to merge, or discard this patch.