silverstripe / silverstripe-cms

code/Controllers/CMSMain.php

Unused Use Statements -1 removed lines

@@ -5,7 +5,6 @@
 use FormField;
 use Injector;
 use ResetFormAction;
-use SilverStripe\ORM\FieldType\DBHTMLText;
 use SilverStripe\ORM\SS_List;
 use SilverStripe\ORM\Versioning\Versioned;
 use SilverStripe\ORM\HiddenClass;

Doc Comments +6 added lines, -3 removed lines

@@ -284,6 +284,9 @@ 
 		}
 	}
 
+	/**
+	 * @param string $link
+	 */
 	public function LinkWithSearch($link) {
 		// Whitelist to avoid side effects
 		$params = array(
@@ -766,7 +769,7 @@ 
 
 	/**
 	 * @param SS_HTTPRequest $request
-	 * @return string HTML
+	 * @return DBHTMLText HTML
 	 */
 	public function treeview($request) {
 		return $this->renderWith($this->getTemplatesWithSuffix('_TreeView'));
@@ -774,7 +777,7 @@ 
 
 	/**
 	 * @param SS_HTTPRequest $request
-	 * @return string HTML
+	 * @return DBHTMLText HTML
 	 */
 	public function listview($request) {
 		return $this->renderWith($this->getTemplatesWithSuffix('_ListView'));
@@ -1095,7 +1098,7 @@ 
 	 * Actually perform the publication step
 	 *
 	 * @param Versioned|DataObject $record
-	 * @return mixed
+	 * @return SS_HTTPResponse|null
 	 */
 	public function performPublish($record) {
 		if($record && !$record->canPublish()) {

code/Controllers/CMSPageEditController.php

Doc Comments +3 added lines, -3 removed lines

@@ -39,7 +39,7 @@ 
 	 *
 	 * @param array $data
 	 * @param Form $form
-	 * @return DBHTMLText|SS_HTTPResponse
+	 * @return SS_HTTPResponse|null
 	 */
 	public function addtocampaign($data, $form)
 	{
@@ -66,7 +66,7 @@ 
 	 * Url handler for add to campaign form
 	 *
 	 * @param SS_HTTPRequest $request
-	 * @return Form
+	 * @return null|\Form
 	 */
 	public function AddToCampaignForm($request)
 	{
@@ -77,7 +77,7 @@ 
 
 	/**
 	 * @param int $id
-	 * @return Form
+	 * @return null|\Form
 	 */
 	public function getAddToCampaignForm($id)
 	{

code/Controllers/SilverStripeNavigatorItem.php

Doc Comments +2 added lines, -2 removed lines

@@ -27,7 +27,7 @@ 
 	protected $recordLink;
 
 	/**
-	 * @param DataObject|CMSPreviewable $record
+	 * @param CMSPreviewable $record
 	 */
 	public function __construct(CMSPreviewable $record)
 	{
@@ -76,7 +76,7 @@ 
 	}
 
 	/**
-	 * @return DataObject
+	 * @return CMSPreviewable
 	 */
 	public function getRecord()
 	{